Attachment 345852 Details for Bug 188063 – Patch

[patch] Patch

bug-188063-20180726103047.patch (text/plain), 1.15 KB, created by Sam Weinig on 2018-07-26 10:30:47 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Weinig

Created: 2018-07-26 10:30:47 PDT

Size: 1.15 KB

patch

obsolete

>Index: Source/WTF/ChangeLog
>===================================================================
>--- Source/WTF/ChangeLog	(revision 234266)
>+++ Source/WTF/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-07-26  Sam Weinig  <sam@webkit.org>
>+
>+        Remove unused/undefined String::appendInternal
>+        https://bugs.webkit.org/show_bug.cgi?id=188063
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * wtf/text/WTFString.h:
>+        String::appendInternal is declared in WTFString.h, but is never used
>+        and and never even defined. Remove it.
>+
> 2018-07-04  Darin Adler  <darin@apple.com>
> 
>         Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
>Index: Source/WTF/wtf/text/WTFString.h
>===================================================================
>--- Source/WTF/wtf/text/WTFString.h	(revision 234266)
>+++ Source/WTF/wtf/text/WTFString.h	(working copy)
>@@ -368,7 +368,6 @@ public:
> 
> private:
>     template<typename CharacterType> void removeInternal(const CharacterType*, unsigned, unsigned);
>-    template<typename CharacterType> void appendInternal(CharacterType);
> 
>     RefPtr<StringImpl> m_impl;
> };

Actions: View | Formatted Diff | Diff

Attachments on bug 188063: 345852