Attachment 345848 Details for Bug 188059 – Patch

[patch] Patch

bug-188059-20180726084949.patch (text/plain), 1.78 KB, created by Chris Dumez on 2018-07-26 08:49:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-07-26 08:49:50 PDT

Size: 1.78 KB

patch

obsolete

>Subversion Revision: 234257
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index a7252eee19ddc7797b3329ecbf95d0aaaedea73c..9202957157d77c6a7c06149ec5954c0a38817037 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-07-26  Chris Dumez  <cdumez@apple.com>
>+
>+        Disable Dark Mode in the Plugin process to avoid rendering issues
>+        https://bugs.webkit.org/show_bug.cgi?id=188059
>+        <rdar://problem/42369281>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Plugins generally do not support dark mode and this causes rendering issues so
>+        disable dark mode in the plugin process.
>+
>+        * PluginProcess/mac/PluginProcessMac.mm:
>+        (WebKit::PluginProcess::platformInitializePluginProcess):
>+
> 2018-07-25  Brent Fulgham  <bfulgham@apple.com>
> 
>         [macOS] Update sandboxes for revised OpenCL calls and streaming media
>diff --git a/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm b/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm
>index b1c3173b65fbda44f01d4fa22c633cc677f30848..7ec04bcfed58326c66353ee35e8b1b75ce119bfa 100644
>--- a/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm
>+++ b/Source/WebKit/PluginProcess/mac/PluginProcessMac.mm
>@@ -521,6 +521,11 @@ void PluginProcess::platformInitializePluginProcess(PluginProcessCreationParamet
>         initWithMemoryCapacity:pluginMemoryCacheSize
>         diskCapacity:pluginDiskCacheSize
>         diskPath:m_nsurlCacheDirectory]).get()];
>+
>+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400
>+    // Disable Dark Mode in the plugin process to avoid rendering issues.
>+    [NSApp setAppearance:[NSAppearance appearanceNamed:NSAppearanceNameAqua]];
>+#endif
> }
> 
> void PluginProcess::platformInitializeProcess(const ChildProcessInitializationParameters& parameters)

Actions: View | Formatted Diff | Diff

Attachments on bug 188059: 345848