Attachment 345836 Details for Bug 188040 – Patch

[patch] Patch

bug-188040-20180726182756.patch (text/plain), 1.75 KB, created by Fujii Hironori on 2018-07-26 02:27:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2018-07-26 02:27:57 PDT

Size: 1.75 KB

patch

obsolete

>Subversion Revision: 234250
>diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
>index 0123c01dfe1d764581168acf754d6e3c96b9097e..4a269a00233291197675c3eb36ba25f329704237 100644
>--- a/Source/JavaScriptCore/ChangeLog
>+++ b/Source/JavaScriptCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-07-26  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        REGRESSION(r234248) [Win] testapi.c: nonstandard extension used: non-constant aggregate initializer
>+        https://bugs.webkit.org/show_bug.cgi?id=188040
>+
>+        Unreviewed build fix for AppleWin port.
>+
>+        * API/tests/testapi.c: Disabled warning C4204.
>+        (testMarkingConstraintsAndHeapFinalizers): Added an explicit void* cast for weakRefs.
>+
> 2018-07-26  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [JSC API] We should support the symbol type in our C/Obj-C API
>diff --git a/Source/JavaScriptCore/API/tests/testapi.c b/Source/JavaScriptCore/API/tests/testapi.c
>index 5ed9ed855c819a68ac4ca4bc6d50f345d2bc5d73..3fc861219a30845aa8be86446058afb3f6207ad9 100644
>--- a/Source/JavaScriptCore/API/tests/testapi.c
>+++ b/Source/JavaScriptCore/API/tests/testapi.c
>@@ -62,6 +62,10 @@
> #include "PingPongStackOverflowTest.h"
> #include "TypedArrayCTest.h"
> 
>+#if COMPILER(MSVC)
>+#pragma warning(disable:4204)
>+#endif
>+
> #if JSC_OBJC_API_ENABLED
> void testObjectiveCAPI(void);
> #endif
>@@ -1206,7 +1210,7 @@ static void testMarkingConstraintsAndHeapFinalizers(void)
> 
>     weakRefs = (JSWeakRef*)calloc(numWeakRefs, sizeof(JSWeakRef));
> 
>-    JSContextGroupAddMarkingConstraint(group, markingConstraint, weakRefs);
>+    JSContextGroupAddMarkingConstraint(group, markingConstraint, (void*)weakRefs);
>     JSContextGroupAddHeapFinalizer(group, heapFinalizer, (void*)(uintptr_t)42);
>     
>     for (i = numWeakRefs; i--;)

Actions: View | Formatted Diff | Diff

Attachments on bug 188040: 345836