Attachment 345822 Details for Bug 188034 – Fix

[patch] Fix

188034.diff (text/plain), 2.88 KB, created by Basuke Suzuki on 2018-07-25 22:08:57 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Basuke Suzuki

Created: 2018-07-25 22:08:57 PDT

Size: 2.88 KB

patch

obsolete

>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 876573788fa..a5f88d52666 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2018-07-25  Basuke Suzuki  <Basuke.Suzuki@sony.com >
>+
>+        [Curl] Test gardening
>+        https://bugs.webkit.org/show_bug.cgi?id=188034
>+
>+        Unreviewed WinCairo gardening.
>+
>+        * http/tests/xmlhttprequest/resources/print-referer.php: Added.
>+        * http/tests/xmlhttprequest/simple-sync-expected.txt: Added.
>+        * http/tests/xmlhttprequest/simple-sync.html:
>+
> 2018-07-25  Basuke Suzuki  <Basuke.Suzuki@sony.com>
> 
>         [Curl] Test gardening
>diff --git a/LayoutTests/http/tests/xmlhttprequest/resources/print-referer.php b/LayoutTests/http/tests/xmlhttprequest/resources/print-referer.php
>new file mode 100644
>index 00000000000..d1d80cd4e02
>--- /dev/null
>+++ b/LayoutTests/http/tests/xmlhttprequest/resources/print-referer.php
>@@ -0,0 +1,4 @@
>+<?php
>+
>+header("Content-type: text/plain");
>+echo $_SERVER['HTTP_REFERER'] ?? "NO REFERER";
>diff --git a/LayoutTests/http/tests/xmlhttprequest/simple-sync-expected.txt b/LayoutTests/http/tests/xmlhttprequest/simple-sync-expected.txt
>new file mode 100644
>index 00000000000..d8361cc8f94
>--- /dev/null
>+++ b/LayoutTests/http/tests/xmlhttprequest/simple-sync-expected.txt
>@@ -0,0 +1,3 @@
>+Test for bug 188033: Syncronous XMLHTTPRequest crashes on WinCairo.
>+
>+result: OK
>diff --git a/LayoutTests/http/tests/xmlhttprequest/simple-sync.html b/LayoutTests/http/tests/xmlhttprequest/simple-sync.html
>index db99f71be51..d51df7c8ab7 100644
>--- a/LayoutTests/http/tests/xmlhttprequest/simple-sync.html
>+++ b/LayoutTests/http/tests/xmlhttprequest/simple-sync.html
>@@ -1,19 +1,19 @@
>-<body>
>-    <p>Test for <a href="http://bugs.webkit.org/show_bug.cgi?id=188033">bug 188033</a>:
>-    Syncronous XMLHTTPRequest crashes on WinCairo.</p>
>-    
>-    <div id=result>result: </div>
>-    
>-    <script>
>-    if (window.testRunner)
>-      testRunner.dumpAsText();
>-    
>-    req = new XMLHttpRequest;
>-    req.open("GET", "resources/print-referer.cgi", false);
>-    req.send(null);
>-    if (req.responseText == document.URL)
>-      document.getElementById("result").firstChild.data += "OK";
>-    else
>-      document.getElementById("result").firstChild.data += req.responseText;
>-    </script>
>-</body>
>+<body>
>+    <p>Test for <a href="http://bugs.webkit.org/show_bug.cgi?id=188033">bug 188033</a>:
>+    Syncronous XMLHTTPRequest crashes on WinCairo.</p>
>+
>+    <div id=result>result: </div>
>+
>+    <script>
>+    if (window.testRunner)
>+      testRunner.dumpAsText();
>+
>+    req = new XMLHttpRequest;
>+    req.open("GET", "resources/print-referer.php", false);
>+    req.send(null);
>+    if (req.responseText == document.URL)
>+      document.getElementById("result").firstChild.data += "OK";
>+    else
>+      document.getElementById("result").firstChild.data += req.responseText;
>+    </script>
>+</body>

Flags:

commit-queue: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 188034: 345814 | 345815 | 345822 | 345828 | 345831 | 345833