Attachment 345816 Details for Bug 188035 – Patch

[patch] Patch

bug-188035-20180725210452.patch (text/plain), 2.78 KB, created by Megan Gardner on 2018-07-25 21:04:53 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Megan Gardner

Created: 2018-07-25 21:04:53 PDT

Size: 2.78 KB

patch

obsolete

>Subversion Revision: 234067
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index cd0d20746e39c489c38a3365414e1f65fc2534ed..f89b7a21180aac58786b6501ad8edd618d7d188c 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-07-25  Megan Gardner  <megan_gardner@apple.com>
>+
>+        Manually activate the selection assistant for Tap and a Half gestures
>+        https://bugs.webkit.org/show_bug.cgi?id=188035
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        For some reason that is not fully understood yet, the tap and a half gesture does not activate
>+        the selection assistant, and thus the selection view when the gesture is starting. The easiest
>+        fix for this is to activate the selection manually when we detect that a tap and a half gesture
>+        is starting. This does not interfear with activation for other gestures, and it ensures that
>+        the selection assistant is active for this case that is missed.
>+
>+        * UIProcess/ios/WKContentViewInteraction.mm:
>+        (-[WKContentView changeSelectionWithGestureAt:withGesture:withState:withFlags:]):
>+
> 2018-07-20  Tim Horton  <timothy_horton@apple.com>
> 
>         Occasional crash under -[WKFormInputSession setSuggestions:]
>diff --git a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>index c89397cdcf15de786393a55fe969e8ec4d9de0b2..f1fcd0f551dc9846c63e6206ba6cfff846032e38 100644
>--- a/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>+++ b/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
>@@ -2726,6 +2726,12 @@ static void selectionChangedWithTouch(WKContentView *view, const WebCore::IntPoi
> - (void)changeSelectionWithGestureAt:(CGPoint)point withGesture:(UIWKGestureType)gestureType withState:(UIGestureRecognizerState)state withFlags:(UIWKSelectionFlags)flags
> {
>     _usingGestureForSelection = YES;
>+    
>+    // FIXME: This is a hacky way to fix this
>+    // <rdar://problem/42610532> Find a better way to make sure that the selection assistant is activated for tap and a half gestures
>+    if (state == UIGestureRecognizerStateBegan && gestureType == UIWKGestureTapAndAHalf)
>+        [_textSelectionAssistant activateSelection];
>+    
>     _page->selectWithGesture(WebCore::IntPoint(point), CharacterGranularity, static_cast<uint32_t>(toGestureType(gestureType)), static_cast<uint32_t>(toGestureRecognizerState(state)), [self _isInteractingWithAssistedNode], [self, state, flags](const WebCore::IntPoint& point, uint32_t gestureType, uint32_t gestureState, uint32_t innerFlags, WebKit::CallbackBase::Error error) {
>         selectionChangedWithGesture(self, point, gestureType, gestureState, flags | innerFlags, error);
>         if (state == UIGestureRecognizerStateEnded || state == UIGestureRecognizerStateCancelled)

Flags:

thorton: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188035: 345816