Attachment 345804 Details for Bug 188031 – Proposed patch

[patch] Proposed patch

ews_DownloadBuiltProduct.patch (text/plain), 4.21 KB, created by Aakash Jain on 2018-07-25 17:12:00 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-07-25 17:12:00 PDT

Size: 4.21 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 234218)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2018-07-25  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
>+        https://bugs.webkit.org/show_bug.cgi?id=188031
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
>+        (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
>+        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
>+
> 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
> 
>         [ews-build] Add build step UploadBuiltProduct
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 234218)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -26,6 +26,7 @@ from buildbot.steps import shell, transf
> from buildbot.steps.source import svn
> from twisted.internet import defer
> 
>+EWS_URL = 'http://ews-build.webkit-uat.org/'
> WithProperties = properties.WithProperties
> 
> 
>@@ -308,3 +309,24 @@ class UploadBuiltProduct(transfer.FileUp
>         kwargs['mode'] = 0644
>         kwargs['blocksize'] = 1024 * 256
>         transfer.FileUpload.__init__(self, **kwargs)
>+
>+
>+class DownloadBuiltProduct(shell.ShellCommand):
>+    command = ['python', 'Tools/BuildSlaveSupport/download-built-product',
>+        WithProperties('--platform=%(platform)s'), WithProperties('--%(configuration)s'),
>+        WithProperties(EWS_URL + 'archives/%(fullPlatform)s-%(architecture)s-%(configuration)s/%(ewspatchid)s.zip')]
>+    name = 'download-built-product'
>+    description = ['downloading built product']
>+    descriptionDone = ['downloaded built product']
>+    haltOnFailure = True
>+    flunkOnFailure = True
>+
>+
>+class ExtractBuiltProduct(shell.ShellCommand):
>+    command = ['python', 'Tools/BuildSlaveSupport/built-product-archive',
>+               WithProperties('--platform=%(fullPlatform)s'), WithProperties('--%(configuration)s'), 'extract']
>+    name = 'extract-built-product'
>+    description = ['extracting built product']
>+    descriptionDone = ['extracted built product']
>+    haltOnFailure = True
>+    flunkOnFailure = True
>Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(revision 234218)
>+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(working copy)
>@@ -822,5 +822,41 @@ class TestUploadBuiltProduct(BuildStepMi
>         return self.runStep()
> 
> 
>+class TestExtractBuiltProduct(BuildStepMixinAdditions, unittest.TestCase):
>+    def setUp(self):
>+        self.longMessage = True
>+        return self.setUpBuildStep()
>+
>+    def tearDown(self):
>+        return self.tearDownBuildStep()
>+
>+    def test_success(self):
>+        self.setupStep(ExtractBuiltProduct())
>+        self.setProperty('fullPlatform', 'ios-simulator')
>+        self.setProperty('configuration', 'release')
>+        self.expectRemoteCommands(
>+            ExpectShell(workdir='wkdir',
>+                        command=['python', 'Tools/BuildSlaveSupport/built-product-archive', '--platform=ios-simulator',  '--release', 'extract'],
>+                        )
>+            + 0,
>+        )
>+        self.expectOutcome(result=SUCCESS, state_string='extracted built product')
>+        return self.runStep()
>+
>+    def test_failure(self):
>+        self.setupStep(ExtractBuiltProduct())
>+        self.setProperty('fullPlatform', 'mac-sierra')
>+        self.setProperty('configuration', 'debug')
>+        self.expectRemoteCommands(
>+            ExpectShell(workdir='wkdir',
>+                        command=['python', 'Tools/BuildSlaveSupport/built-product-archive', '--platform=mac-sierra',  '--debug', 'extract'],
>+                        )
>+            + ExpectShell.log('stdio', stdout='Unexpected failure.')
>+            + 2,
>+        )
>+        self.expectOutcome(result=FAILURE, state_string='extracted built product (failure)')
>+        return self.runStep()
>+
>+
> if __name__ == '__main__':
>     unittest.main()

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188031: 345804