Attachment 345800 Details for Bug 188028 – Patch

[patch] Patch

bug-188028-20180725163404.patch (text/plain), 1.52 KB, created by Chris Dumez on 2018-07-25 16:34:05 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2018-07-25 16:34:05 PDT

Size: 1.52 KB

patch

obsolete

>Subversion Revision: 234214
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 519c7e498ff1bca77f1e5868b9ad96fa97bd0bb1..fdf2e78916734cdab563d7418684a8584f96189e 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2018-07-25  Chris Dumez  <cdumez@apple.com>
>+
>+        ERROR: Unhandled web process message 'WebPage:SetUseDarkAppearance' when browsing in dark mode
>+        https://bugs.webkit.org/show_bug.cgi?id=188028
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Move the call to setUseDarkAppearance() after the call to initializeWebPage() since the WebPage
>+        is not created on WebProcess side until initializeWebPage() is called.
>+
>+        * UIProcess/Cocoa/WebViewImpl.mm:
>+        (WebKit::WebViewImpl::WebViewImpl):
>+
> 2018-07-25  Tim Horton  <timothy_horton@apple.com>
> 
>         Fix the build.
>diff --git a/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm b/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
>index db6d523423ab981b2c74003f5a596a5142a4d43b..85acf2055a5cae80c6cd5582625284f474bca5fc 100644
>--- a/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
>+++ b/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm
>@@ -1312,9 +1312,8 @@ WebViewImpl::WebViewImpl(NSView <WebViewImplDelegate> *view, WKWebView *outerWeb
> 
>     m_page->setAddsVisitedLinks(processPool.historyClient().addsVisitedLinks());
> 
>-    m_page->setUseDarkAppearance(effectiveAppearanceIsDark());
>-
>     m_page->initializeWebPage();
>+    m_page->setUseDarkAppearance(effectiveAppearanceIsDark());
> 
>     registerDraggedTypes();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188028: 345800 | 345857