Attachment 345790 Details for Bug 188023 – Patch

[patch] Patch

bug-188023-20180725150636.patch (text/plain), 1.49 KB, created by Justin Fan on 2018-07-25 15:06:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Justin Fan

Created: 2018-07-25 15:06:37 PDT

Size: 1.49 KB

patch

obsolete

>Subversion Revision: 234207
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1e643d505f9c1471bb9f4a72d15bbc7e5f2aae00..1374f130a2e1978ac75856a909dbe1f43195d274 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,19 @@
>+2018-07-25  Justin Fan  <justin_fan@apple.com>
>+
>+        Systems with no NSScreens hitting assertion in rendererIDForDisplay when creating WebGL context
>+        https://bugs.webkit.org/show_bug.cgi?id=188023
>+        <rdar://problem/42476622>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        On systems with no NSScreens, PlatformScreenMac's screenData map is not populated; rendererIDForDisplay
>+        will thus hit an assertion rather than returning 0. Removing the assertion for now. 
>+
>+        Covered by existing tests.
>+
>+        * platform/mac/PlatformScreenMac.mm:
>+        (WebCore::rendererIDForDisplay):
>+
> 2018-07-25  David Fenton  <david_fenton@apple.com>
> 
>         Unreviewed, rolling out r234187.
>diff --git a/Source/WebCore/platform/mac/PlatformScreenMac.mm b/Source/WebCore/platform/mac/PlatformScreenMac.mm
>index b3ae988b71a0929020bfe3157845a4c2f1f72c39..147f26a21096245db73c0571c6234c2575f3dd16 100644
>--- a/Source/WebCore/platform/mac/PlatformScreenMac.mm
>+++ b/Source/WebCore/platform/mac/PlatformScreenMac.mm
>@@ -204,7 +204,6 @@ GLint rendererIDForDisplay(PlatformDisplayID displayID)
> #else
>     return rendererIDForDisplayMask(CGDisplayIDToOpenGLDisplayMask(displayID));
> #endif
>-    ASSERT_NOT_REACHED();
>     return 0;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188023: 345790