Attachment 345774 Details for Bug 188014 – Proposed patch

[patch] Proposed patch

ews_ArchiveBuiltProduct.patch (text/plain), 3.35 KB, created by Aakash Jain on 2018-07-25 13:05:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Aakash Jain

Created: 2018-07-25 13:05:37 PDT

Size: 3.35 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 234210)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,14 @@
>+2018-07-25  Aakash Jain  <aakash_jain@apple.com>
>+
>+        [ews-build] Add build step ArchiveBuiltProduct
>+        https://bugs.webkit.org/show_bug.cgi?id=188014
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * BuildSlaveSupport/ews-build/steps.py:
>+        (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
>+        * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
>+
> 2018-07-25  Charlie Turner  <cturner@igalia.com>
> 
>         [Flatpak] Pass more environment variables to sandbox
>Index: Tools/BuildSlaveSupport/ews-build/steps.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps.py	(revision 234210)
>+++ Tools/BuildSlaveSupport/ews-build/steps.py	(working copy)
>@@ -284,3 +284,12 @@ class RunWebKitTests(shell.Test):
>         if additionalArguments:
>             self.setCommand(self.command + additionalArguments)
>         return shell.Test.start(self)
>+
>+
>+class ArchiveBuiltProduct(shell.ShellCommand):
>+    command = ['python', 'Tools/BuildSlaveSupport/built-product-archive',
>+               WithProperties('--platform=%(fullPlatform)s'), WithProperties('--%(configuration)s'), 'archive']
>+    name = 'archive-built-product'
>+    description = ['archiving built product']
>+    descriptionDone = ['archived built product']
>+    haltOnFailure = True
>Index: Tools/BuildSlaveSupport/ews-build/steps_unittest.py
>===================================================================
>--- Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(revision 234210)
>+++ Tools/BuildSlaveSupport/ews-build/steps_unittest.py	(working copy)
>@@ -745,5 +745,41 @@ class TestRunWebKitTests(BuildStepMixinA
>         return self.runStep()
> 
> 
>+class TestArchiveBuiltProduct(BuildStepMixinAdditions, unittest.TestCase):
>+    def setUp(self):
>+        self.longMessage = True
>+        return self.setUpBuildStep()
>+
>+    def tearDown(self):
>+        return self.tearDownBuildStep()
>+
>+    def test_success(self):
>+        self.setupStep(ArchiveBuiltProduct())
>+        self.setProperty('fullPlatform', 'ios-simulator')
>+        self.setProperty('configuration', 'release')
>+        self.expectRemoteCommands(
>+            ExpectShell(workdir='wkdir',
>+                        command=['python', 'Tools/BuildSlaveSupport/built-product-archive', '--platform=ios-simulator',  '--release', 'archive'],
>+                        )
>+            + 0,
>+        )
>+        self.expectOutcome(result=SUCCESS, state_string='archived built product')
>+        return self.runStep()
>+
>+    def test_failure(self):
>+        self.setupStep(ArchiveBuiltProduct())
>+        self.setProperty('fullPlatform', 'mac-sierra')
>+        self.setProperty('configuration', 'debug')
>+        self.expectRemoteCommands(
>+            ExpectShell(workdir='wkdir',
>+                        command=['python', 'Tools/BuildSlaveSupport/built-product-archive', '--platform=mac-sierra',  '--debug', 'archive'],
>+                        )
>+            + ExpectShell.log('stdio', stdout='Unexpected failure.')
>+            + 2,
>+        )
>+        self.expectOutcome(result=FAILURE, state_string='archived built product (failure)')
>+        return self.runStep()
>+
>+
> if __name__ == '__main__':
>     unittest.main()

Flags:

lforschler: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 188014: 345774