Attachment 345771 Details for Bug 188012 – Patch

[patch] Patch

bug-188012-20180725120200.patch (text/plain), 1.68 KB, created by Sihui Liu on 2018-07-25 12:02:01 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sihui Liu

Created: 2018-07-25 12:02:01 PDT

Size: 1.68 KB

patch

obsolete

>Subversion Revision: 234089
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 4ff957621ca60284aa64b6240596508f2c8b19ef..197aed0eacd7e9792f030156bb20a4e026f3f68d 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-07-25  Sihui Liu  <sihui_liu@apple.com>
>+
>+        Remove a forward protocol declaration of '_WKWebViewPrintProvider'
>+        https://bugs.webkit.org/show_bug.cgi?id=188012
>+        <rdar://problem/42309526>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        @procotol() expressions emit invalid protocol metadata when used with forward @protocol declarations. 
>+        Clang is going to make it an error for using a forward-declared protocol in a @protocol expression, so
>+        we need to stop doing this.
>+
>+        * UIProcess/API/Cocoa/WKWebViewInternal.h:
>+
> 2018-07-20  Jer Noble  <jer.noble@apple.com>
> 
>         REGRESSION(r233925): Can't go into PiP twice
>diff --git a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
>index 906b9790ae0ac8167ae73f4043bdc03d72110340..aab3010f5d831f190b9a944af2676f871c57d0be 100644
>--- a/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
>+++ b/Source/WebKit/UIProcess/API/Cocoa/WKWebViewInternal.h
>@@ -30,6 +30,7 @@
> #import "SameDocumentNavigationType.h"
> #import "WKWebViewConfiguration.h"
> #import "_WKAttachmentInternal.h"
>+#import "_WKWebViewPrintFormatterInternal.h"
> #import <wtf/RefPtr.h>
> #import <wtf/RetainPtr.h>
> 
>@@ -61,7 +62,6 @@ struct PrintInfo;
> @class WKWebViewContentProviderRegistry;
> @class WKPasswordView;
> @class _WKFrameHandle;
>-@protocol _WKWebViewPrintProvider;
> 
> @interface WKWebView () WK_WEB_VIEW_PROTOCOLS {
>

Actions: View | Formatted Diff | Diff

Attachments on bug 188012: 345771