Attachment 345761 Details for Bug 188002 – Patch

[patch] Patch

bug-188002-20180725170136.patch (text/plain), 1.86 KB, created by Charlie Turner on 2018-07-25 09:01:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Charlie Turner

Created: 2018-07-25 09:01:38 PDT

Size: 1.86 KB

patch

obsolete

>Subversion Revision: 234192
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index d0ecc2a2babdee0d5af43a7f539fa3726aada173..884f3892bb08292f111c2268cf221ef4ffc3592f 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,13 @@
>+2018-07-25  Charlie Turner  <cturner@igalia.com>
>+
>+        [Flatpak] Pass more environment variables to sandbox
>+        https://bugs.webkit.org/show_bug.cgi?id=188002
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * flatpak/flatpakutils.py:
>+        (WebkitFlatpak.run_in_sandbox):
>+
> 2018-07-24  Thomas Denney  <tdenney@apple.com>
> 
>         Remove support for the double type from WHLSL
>diff --git a/Tools/flatpak/flatpakutils.py b/Tools/flatpak/flatpakutils.py
>index 0e90dbf7d753a4a7d1a915ed8d0e7de5d3b4999a..9abbe7a1e87c04a0e37965c72d6ec0e35e85e78e 100644
>--- a/Tools/flatpak/flatpakutils.py
>+++ b/Tools/flatpak/flatpakutils.py
>@@ -679,9 +679,27 @@ class WebkitFlatpak:
>                 "TEST_RUNNER_INJECTED_BUNDLE_FILENAME": "/app/webkit/lib/libTestRunnerInjectedBundle.so",
>             }
> 
>+            env_var_prefixes_to_keep = [
>+                "GST",
>+                "GTK",
>+                "G",
>+                "JSC",
>+                "WEBKIT",
>+                "WEBKIT2",
>+                "WPE",
>+                "GIGACAGE",
>+            ]
>+
>+            env_vars_to_keep = [
>+                "JavaScriptCoreUseJIT",
>+                "Malloc",
>+                "WAYLAND_DISPLAY",
>+                "DISPLAY",
>+                "LANG",
>+            ]
>+
>             for envvar, value in os.environ.items():
>-                if envvar.split("_")[0] in ("GST", "GTK", "G") or \
>-                        envvar in ["WAYLAND_DISPLAY", "DISPLAY", "LANG"]:
>+                if envvar.split("_")[0] in env_var_prefixes_to_keep or envvar in env_vars_to_keep:
>                     forwarded[envvar] = value
> 
>             for envvar, value in forwarded.items():

Actions: View | Formatted Diff | Diff

Attachments on bug 188002: 345757 | 345759 | 345761