Attachment 345749 Details for Bug 187991 – Patch

[patch] Patch

bug-187991-20180725021241.patch (text/plain), 1.97 KB, created by Hongxu Jia on 2018-07-25 02:12:41 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Hongxu Jia

Created: 2018-07-25 02:12:41 PDT

Size: 1.97 KB

patch

obsolete

>Subversion Revision: 234185
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 17e7bfa25b811ef16309117d29702a6045b30a40..4a7f3870d05e364632fbce593b920916929b8f30 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2018-07-25  Hongxu Jia  <hongxu.jia@windriver.com>
>+
>+        PaintingData' has no member named 'lightVector' on ARM_NEON
>+        https://bugs.webkit.org/show_bug.cgi?id=187991
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Since `1a55d8c FELighting cleanup and optimization' applied,
>+        it missed to tweak `paintingData.lightVector' for ARM_NEON which
>+        caused PaintingData' has no member named 'lightVector'
>+
>+        * platform/graphics/cpu/arm/filters/FELightingNEON.h:
>+        (WebCore::FELighting::platformApplyNeon):
>+
> 2018-07-24  Tim Horton  <timothy_horton@apple.com>
> 
>         Enable Web Content Filtering on watchOS
>diff --git a/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h b/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
>index 42af922374bd68a474ce8a6e2fd66da7fa5f3ec3..b542a4c81aa3b11777b58e62d8ea75db473e7318 100644
>--- a/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
>+++ b/Source/WebCore/platform/graphics/cpu/arm/filters/FELightingNEON.h
>@@ -144,9 +144,9 @@ inline void FELighting::platformApplyNeon(const LightingData& data, const LightS
>             neonData.flags |= FLAG_CONE_EXPONENT_IS_1;
>     } else {
>         ASSERT(m_lightSource->type() == LS_DISTANT);
>-        floatArguments.lightX = paintingData.lightVector.x();
>-        floatArguments.lightY = paintingData.lightVector.y();
>-        floatArguments.lightZ = paintingData.lightVector.z();
>+        floatArguments.lightX = paintingData.initialLightingData.lightVector.x();
>+        floatArguments.lightY = paintingData.initialLightingData.lightVector.y();
>+        floatArguments.lightZ = paintingData.initialLightingData.lightVector.z();
>         floatArguments.padding2 = 1;
>     }
>

Flags:

darin: review+
ews-watchlist: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 187991: 345748 | 345749 | 345750 | 345778