Attachment 98881 Details for Bug 61988 – Patch 3

[patch] Patch 3

bug-61988-20110628172652.patch (text/plain), 5.87 KB, created by Kent Tamura on 2011-06-28 01:26:54 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Kent Tamura

Created: 2011-06-28 01:26:54 PDT

Size: 5.87 KB

patch

obsolete

>Subversion Revision: 89891
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 6e8f1139f4d6be10061c82069ed30c53b477bc79..073db09524fd1ed6340416cc1f1934d37ee7e9f7 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2011-06-16  Kent Tamura  <tkent@chromium.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Verify cloning elements with validation messages works.
>+        https://bugs.webkit.org/show_bug.cgi?id=61988
>+
>+        * fast/forms/validation-message-clone-expected.txt: Added.
>+        * fast/forms/validation-message-clone.html: Added.
>+        * platform/gtk/Skipped:
>+        * platform/mac-wk2/Skipped:
>+        * platform/qt/Skipped:
>+        * platform/win/Skipped:
>+
> 2011-06-27  Pavel Feldman  <pfeldman@chromium.org>
> 
>         Not reviewed: chromium baselines update.
>diff --git a/LayoutTests/fast/forms/validation-message-clone-expected.txt b/LayoutTests/fast/forms/validation-message-clone-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..55bc402df7048437baa626ece902ca31971f95dd
>--- /dev/null
>+++ b/LayoutTests/fast/forms/validation-message-clone-expected.txt
>@@ -0,0 +1,8 @@
>+There are two text fields. The first one should have a validation message bubble, and another should have no validation message.
>+
>+
>+
>+
>+PASS internals.shadowPseudoId(lastInOriginalShadow) == "-webkit-validation-bubble" is true
>+PASS internals.shadowPseudoId(lastInClonedShadow) == "-webkit-validation-bubble" is false
>+
>diff --git a/LayoutTests/fast/forms/validation-message-clone.html b/LayoutTests/fast/forms/validation-message-clone.html
>new file mode 100644
>index 0000000000000000000000000000000000000000..86667bc2bc9bdb9c2d7681d5bf375ae922314e33
>--- /dev/null
>+++ b/LayoutTests/fast/forms/validation-message-clone.html
>@@ -0,0 +1,41 @@
>+<!DOCTYPE html>
>+<head>
>+<script src="../js/resources/js-test-pre.js"></script>
>+<script src="resources/common.js"></script>
>+</head>
>+<body>
>+<p>There are two text fields. The first one should have a validation message bubble, and another should have no validation message.</p>
>+<form action="validation-message-clone.html">
>+<div style="height:100px;"><input required></div>
>+<div style="height:100px;" id=dest></div>
>+<div><input type=submit id=submit></div>
>+<div id=console></div>
>+</form>
>+
>+<script>
>+var original = document.getElementsByTagName('input')[0];
>+var lastInOriginalShadow;
>+var lastInClonedShadow;
>+$('submit').click();
>+setTimeout(cloneElementWithValidationMessage, 0);
>+if (window.layoutTestController)
>+    layoutTestController.waitUntilDone();
>+
>+function cloneElementWithValidationMessage() {
>+    $('dest').appendChild(original.cloneNode());
>+    setTimeout(confirmNoBubble, 0);
>+}
>+
>+function confirmNoBubble() {
>+    if (!window.layoutTestController)
>+        return;
>+
>+    lastInOriginalShadow = internals.shadowRoot(original).lastChild;
>+    shouldBeTrue('internals.shadowPseudoId(lastInOriginalShadow) == "-webkit-validation-bubble"');
>+    lastInClonedShadow = internals.shadowRoot($('dest').firstChild).lastChild;
>+    shouldBeFalse('internals.shadowPseudoId(lastInClonedShadow) == "-webkit-validation-bubble"');
>+    layoutTestController.notifyDone();
>+}
>+</script>
>+
>+</body>
>diff --git a/LayoutTests/platform/gtk/Skipped b/LayoutTests/platform/gtk/Skipped
>index 1e181b0a5a3068f6ea84e9863807370f738e6558..81a53b64c6ad9ba4ab3ad6a8a15320971b91a5f0 100644
>--- a/LayoutTests/platform/gtk/Skipped
>+++ b/LayoutTests/platform/gtk/Skipped
>@@ -1221,6 +1221,7 @@ fast/forms/interactive-validation-select-crash.html
> fast/forms/interactive-validation-crash-by-style-override.html
> # Need to call Settings::setValidationMessageTimerMagnification(-1) in DRT.
> fast/forms/validation-message-appearance.html
>+fast/forms/validation-message-clone.html
> fast/forms/validation-message-on-checkbox.html
> fast/forms/validation-message-on-listbox.html
> fast/forms/validation-message-on-menulist.html
>diff --git a/LayoutTests/platform/mac-wk2/Skipped b/LayoutTests/platform/mac-wk2/Skipped
>index 049ed38d54690328e660d866bcd0076d8bfec137..0291171405a1b36be9ac799febaefdc7c7e3e1ff 100644
>--- a/LayoutTests/platform/mac-wk2/Skipped
>+++ b/LayoutTests/platform/mac-wk2/Skipped
>@@ -1549,6 +1549,7 @@ fast/forms/interactive-validation-select-crash.html
> # WebKitTestRunner needs support for validation message bubble tests
> # http://webkit.org/b/57455
> fast/forms/validation-message-appearance.html
>+fast/forms/validation-message-clone.html
> fast/forms/validation-message-on-checkbox.html
> fast/forms/validation-message-on-listbox.html
> fast/forms/validation-message-on-menulist.html
>diff --git a/LayoutTests/platform/qt/Skipped b/LayoutTests/platform/qt/Skipped
>index bd6204596d15d2c8075019aba8ca159f026bf37c..6f9ba00c7bba7a503a21fa9d15ccfb6c86cc253e 100644
>--- a/LayoutTests/platform/qt/Skipped
>+++ b/LayoutTests/platform/qt/Skipped
>@@ -2013,6 +2013,7 @@ fast/forms/interactive-validation-select-crash.html
> fast/forms/interactive-validation-crash-by-style-override.html
> # Need to call Settings::setValidationMessageTimerMagnification(-1) in DRT.
> fast/forms/validation-message-appearance.html
>+fast/forms/validation-message-clone.html
> fast/forms/validation-message-on-checkbox.html
> fast/forms/validation-message-on-listbox.html
> fast/forms/validation-message-on-menulist.html
>diff --git a/LayoutTests/platform/win/Skipped b/LayoutTests/platform/win/Skipped
>index 0a023951cc123b46b5e9dbcbaef67794150f4394..0a31247c880087eda0a39ab9db1997d0add30958 100644
>--- a/LayoutTests/platform/win/Skipped
>+++ b/LayoutTests/platform/win/Skipped
>@@ -1116,6 +1116,7 @@ fast/forms/interactive-validation-select-crash.html
> fast/forms/interactive-validation-crash-by-style-override.html
> # Need to call Settings::setValidationMessageTimerMagnification(-1) in DRT.
> fast/forms/validation-message-appearance.html
>+fast/forms/validation-message-clone.html
> fast/forms/validation-message-on-checkbox.html
> fast/forms/validation-message-on-listbox.html
> fast/forms/validation-message-on-menulist.html

Actions: View | Formatted Diff | Diff

Attachments on bug 61988: 97539 | 97564 | 98881