Attachment 97426 Details for Bug 62707 – Patch

[patch] Patch

bug-62707-20110616184233.patch (text/plain), 1.98 KB, created by Hyowon Kim on 2011-06-16 02:42:34 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Hyowon Kim

Created: 2011-06-16 02:42:34 PDT

Size: 1.98 KB

patch

obsolete

>Subversion Revision: 89021
>diff --git a/Source/WebCore/CMakeLists.txt b/Source/WebCore/CMakeLists.txt
>index 95e9f718062e177457b74cfae664cfda180cb504..f4d97e74360d1954461f23cab166bbbbebc11681 100644
>--- a/Source/WebCore/CMakeLists.txt
>+++ b/Source/WebCore/CMakeLists.txt
>@@ -2003,6 +2003,7 @@ IF (ENABLE_WEBGL)
>         ${THIRDPARTY_DIR}/ANGLE/src
>         ${THIRDPARTY_DIR}/ANGLE/include
>         ${THIRDPARTY_DIR}/ANGLE/include/GLSLANG
>+        ${WEBCORE_DIR}/platform/graphics/gpu
>     )
>     LIST(APPEND WebCore_LIBRARIES
>         ${OPENGL_gl_LIBRARY}
>@@ -2068,10 +2069,9 @@ IF (ENABLE_WEBGL)
>         html/canvas/WebKitLoseContext.cpp
> 
>         platform/graphics/ANGLEWebKitBridge.cpp
>-        platform/graphics/gpu/DrawingBuffer.cpp
>         platform/graphics/GraphicsContext3D.cpp
>-        platform/graphics/opengl/Extensions3DOpenGL.cpp
>-        platform/graphics/opengl/GraphicsContext3DOpenGL.cpp
>+        
>+        platform/graphics/gpu/DrawingBuffer.cpp
>     )
> ENDIF ()
> 
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 955cb2630277d8cbff4305f2d1bcb3ee017f88dd..008256d5a6b38b4b05b4e46dd5bf519cb6f50cae 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,21 @@
>+2011-06-16  Hyowon Kim  <hw1008.kim@samsung.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [CMAKE] Remove platform/graphics/opengl/*OpenGL.cpp files in CMakeLists.txt
>+        https://bugs.webkit.org/show_bug.cgi?id=62707
>+
>+        No change in fuctionality so no new tests.
>+
>+        Bug 62376 makes all ports use GraphicsContext3DOpenGL and
>+        Extensions3DOpenGL when enabling WebGL.
>+        However, some ports already have their own GC3D implementation.
>+        In QT and chromium, for example, GC3D delegates to GC3DInternal.
>+        So, it would be better to allow each port to decide whether or not
>+        to include files in platform/graphics/opengl. 
>+
>+        * CMakeLists.txt:
>+
> 2011-06-16  Hayato Ito  <hayato@chromium.org>
> 
>         Reviewed by Hajime Morita.

Actions: View | Formatted Diff | Diff

Attachments on bug 62707: 97261 | 97263 | 97426