Attachment 92611 Details for Bug 60388 – Patch

[patch] Patch

bug-60388-20110506191600.patch (text/plain), 28.16 KB, created by Tony Gentilcore on 2011-05-06 11:16:03 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Tony Gentilcore

Created: 2011-05-06 11:16:03 PDT

Size: 28.16 KB

patch

obsolete

>Subversion Revision: 85953
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index c7306338b4cd8712cdcae9d6dbfb2ce9c71892bf..ca8b8e565e18447e190094f5186fa227962b5548 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,62 @@
>+2011-05-06  Tony Gentilcore  <tonyg@chromium.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix some unnecessary includes in headers
>+        https://bugs.webkit.org/show_bug.cgi?id=60388
>+
>+        These were all found using the include-what-you-use clang plugin.
>+
>+        * css/CSSFontFaceSrcValue.h:
>+        * css/CSSImageGeneratorValue.h:
>+        * css/CSSParser.h:
>+        * css/CSSPrimitiveValueCache.cpp:
>+        * css/CSSPrimitiveValueCache.h:
>+        * css/CSSStyleSelector.cpp:
>+        * css/CSSStyleSelector.h:
>+        * css/RGBColor.cpp:
>+        * css/RGBColor.h:
>+        * dom/EventTarget.h:
>+        * dom/ExceptionBase.cpp:
>+        * dom/ExceptionBase.h:
>+        * dom/MessagePort.cpp:
>+        * dom/Range.cpp:
>+        * dom/Range.h:
>+        * dom/SelectElement.cpp:
>+        * dom/SelectElement.h:
>+        * dom/TextEvent.cpp:
>+        * dom/TextEvent.h:
>+        * dom/Touch.cpp:
>+        * dom/Touch.h:
>+        * dom/TouchEvent.cpp:
>+        * dom/TouchEvent.h:
>+        * dom/XMLDocumentParser.h:
>+        * dom/XMLDocumentParserScope.h:
>+        * editing/AppendNodeCommand.cpp:
>+        * editing/ApplyBlockElementCommand.h:
>+        * editing/DeleteFromTextNodeCommand.cpp:
>+        * editing/EditCommand.h:
>+        * editing/Editor.h:
>+        * editing/FormatBlockCommand.h:
>+        * editing/IndentOutdentCommand.h:
>+        * editing/InsertIntoTextNodeCommand.cpp:
>+        * editing/InsertNodeBeforeCommand.cpp:
>+        * editing/ReplaceSelectionCommand.h:
>+        * editing/SetNodeAttributeCommand.h:
>+        * html/HTMLSelectElement.h:
>+        * html/canvas/CanvasRenderingContext2D.cpp:
>+        * loader/appcache/DOMApplicationCache.cpp:
>+        * page/EventSource.cpp:
>+        * rendering/RenderListBox.cpp:
>+        * rendering/RenderMenuList.cpp:
>+        * rendering/RenderTextControlSingleLine.cpp:
>+        * rendering/svg/RenderSVGInlineText.cpp:
>+        * svg/SVGMatrix.h:
>+        * websockets/WebSocket.cpp:
>+        * workers/AbstractWorker.cpp:
>+        * xml/XMLHttpRequest.cpp:
>+        * xml/XPathExpression.cpp:
>+
> 2011-05-06  Eric Carlson  <eric.carlson@apple.com>
> 
>         Reviewed by Darin Adler.
>diff --git a/Source/WebCore/css/CSSFontFaceSrcValue.h b/Source/WebCore/css/CSSFontFaceSrcValue.h
>index 570652d71151fd29a472d929edb5ab67b126db33..29553cf897e98fece921a2bf62b880071af25463 100644
>--- a/Source/WebCore/css/CSSFontFaceSrcValue.h
>+++ b/Source/WebCore/css/CSSFontFaceSrcValue.h
>@@ -30,12 +30,12 @@
> #include "PlatformString.h"
> #include <wtf/PassRefPtr.h>
> 
>+namespace WebCore {
>+
> #if ENABLE(SVG_FONTS)
>-#include "SVGFontFaceElement.h"
>+class SVGFontFaceElement;
> #endif
> 
>-namespace WebCore {
>-
> class CSSFontFaceSrcValue : public CSSValue {
> public:
>     static PassRefPtr<CSSFontFaceSrcValue> create(const String& resource)
>diff --git a/Source/WebCore/css/CSSImageGeneratorValue.h b/Source/WebCore/css/CSSImageGeneratorValue.h
>index f5c17f59bbcb83703daf5f9f3afcd53bfec78448..46524fbd0c733964927409ac3801c4d981d83001 100644
>--- a/Source/WebCore/css/CSSImageGeneratorValue.h
>+++ b/Source/WebCore/css/CSSImageGeneratorValue.h
>@@ -35,8 +35,8 @@
> namespace WebCore {
> 
> class Image;
>-class StyleGeneratedImage;
> class RenderObject;
>+class StyleGeneratedImage;
> 
> class CSSImageGeneratorValue : public CSSValue {
> public:
>diff --git a/Source/WebCore/css/CSSParser.h b/Source/WebCore/css/CSSParser.h
>index 05243022623ee066385da82eaf6c9fa2686c1317..a12a094c2a8c213e6b8e05e1715207f8c34b547b 100644
>--- a/Source/WebCore/css/CSSParser.h
>+++ b/Source/WebCore/css/CSSParser.h
>@@ -26,7 +26,7 @@
> #include "CSSGradientValue.h"
> #include "CSSParserValues.h"
> #include "CSSPropertySourceData.h"
>-#include "CSSSelectorList.h"
>+#include "CSSSelector.h"
> #include "Color.h"
> #include "MediaQuery.h"
> #include <wtf/HashMap.h>
>@@ -42,8 +42,7 @@ namespace WebCore {
>     class CSSProperty;
>     class CSSRule;
>     class CSSRuleList;
>-    class CSSSelector;
>-    class CSSStyleRule;
>+    class CSSSelectorList;
>     class CSSStyleSheet;
>     class CSSValue;
>     class CSSValueList;
>@@ -51,7 +50,6 @@ namespace WebCore {
>     class MediaList;
>     class MediaQueryExp;
>     class StyleBase;
>-    class StyleList;
>     class WebKitCSSKeyframeRule;
>     class WebKitCSSKeyframesRule;
> 
>diff --git a/Source/WebCore/css/CSSPrimitiveValueCache.cpp b/Source/WebCore/css/CSSPrimitiveValueCache.cpp
>index 5c7a4c0600d8893907e1cc3f6c28be481b192126..3adadf89b7402c4e45a3f5c7904ba47c2247cfc2 100644
>--- a/Source/WebCore/css/CSSPrimitiveValueCache.cpp
>+++ b/Source/WebCore/css/CSSPrimitiveValueCache.cpp
>@@ -25,6 +25,7 @@
> 
> #include "config.h"
> #include "CSSPrimitiveValueCache.h"
>+#include "CSSValueKeywords.h"
> 
> namespace WebCore {
> 
>diff --git a/Source/WebCore/css/CSSPrimitiveValueCache.h b/Source/WebCore/css/CSSPrimitiveValueCache.h
>index 0290e4073e55d7b15dfa5040350050f03f8f0fbc..41d75a7e3a4eaa6fc4e76cf03fd26d8c0871098f 100644
>--- a/Source/WebCore/css/CSSPrimitiveValueCache.h
>+++ b/Source/WebCore/css/CSSPrimitiveValueCache.h
>@@ -27,14 +27,11 @@
> #define CSSPrimitiveValueCache_h
> 
> #include "CSSPrimitiveValue.h"
>-#include "CSSValueKeywords.h"
> #include <wtf/HashMap.h>
> #include <wtf/RefPtr.h>
> 
> namespace WebCore {
>     
>-class CSSPrimitiveValue;
>-
> class CSSPrimitiveValueCache : public RefCounted<CSSPrimitiveValueCache> {
> public:
>     static PassRefPtr<CSSPrimitiveValueCache> create() { return adoptRef(new CSSPrimitiveValueCache); }
>diff --git a/Source/WebCore/css/CSSStyleSelector.cpp b/Source/WebCore/css/CSSStyleSelector.cpp
>index 9dcdcbeec729a79c3f45e3015c111b817b81839b..d3448fd3aae0ad9eeefa43e75e049a14b7cf91b0 100644
>--- a/Source/WebCore/css/CSSStyleSelector.cpp
>+++ b/Source/WebCore/css/CSSStyleSelector.cpp
>@@ -34,6 +34,7 @@
> #include "CSSBorderImageValue.h"
> #include "CSSCursorImageValue.h"
> #include "CSSFontFaceRule.h"
>+#include "CSSFontSelector.h"
> #include "CSSImportRule.h"
> #include "CSSLineBoxContainValue.h"
> #include "CSSMediaRule.h"
>diff --git a/Source/WebCore/css/CSSStyleSelector.h b/Source/WebCore/css/CSSStyleSelector.h
>index a9b0c3e5ba9980c1f926b9301dc6384498f7f848..6d1903d070f81127df1d022873b35e4c39bb4894 100644
>--- a/Source/WebCore/css/CSSStyleSelector.h
>+++ b/Source/WebCore/css/CSSStyleSelector.h
>@@ -22,7 +22,6 @@
> #ifndef CSSStyleSelector_h
> #define CSSStyleSelector_h
> 
>-#include "CSSFontSelector.h"
> #include "CSSRule.h"
> #include "LinkHash.h"
> #include "MediaQueryExp.h"
>@@ -36,6 +35,7 @@
> 
> namespace WebCore {
> 
>+class CSSFontSelector;
> class CSSMutableStyleDeclaration;
> class CSSPageRule;
> class CSSPrimitiveValue;
>diff --git a/Source/WebCore/css/RGBColor.cpp b/Source/WebCore/css/RGBColor.cpp
>index 5c8c104e70e608fc061ed7ec473dc1f2c6ac85cc..11ebfe4fae561bcc979b37cb4743522ed9b86be7 100644
>--- a/Source/WebCore/css/RGBColor.cpp
>+++ b/Source/WebCore/css/RGBColor.cpp
>@@ -26,6 +26,7 @@
> 
> #include "config.h"
> #include "RGBColor.h"
>+#include "CSSPrimitiveValue.h"
> 
> namespace WebCore {
> 
>diff --git a/Source/WebCore/css/RGBColor.h b/Source/WebCore/css/RGBColor.h
>index 7937a08c862965a8acbce80a315d7cc4de749be1..875eb37159a75015d1d84dec0e30dc7e823ce073 100644
>--- a/Source/WebCore/css/RGBColor.h
>+++ b/Source/WebCore/css/RGBColor.h
>@@ -27,12 +27,13 @@
> #ifndef RGBColor_h
> #define RGBColor_h
> 
>-#include "CSSPrimitiveValue.h"
> #include "Color.h"
> #include <wtf/RefCounted.h>
> 
> namespace WebCore {
> 
>+    class CSSPrimitiveValue;
>+
>     class RGBColor : public RefCounted<RGBColor> {
>     public:
>         static PassRefPtr<RGBColor> create(unsigned rgbColor);
>diff --git a/Source/WebCore/dom/EventTarget.h b/Source/WebCore/dom/EventTarget.h
>index c262230a3694bedbc34b7a983bfd4a1a41dd8dce..696be88e2ebe1f3f02d005f57894eed71778d62f 100644
>--- a/Source/WebCore/dom/EventTarget.h
>+++ b/Source/WebCore/dom/EventTarget.h
>@@ -41,7 +41,6 @@
> namespace WebCore {
> 
>     class AudioContext;
>-    class AbstractWorker;
>     class DedicatedWorkerContext;
>     class DOMApplicationCache;
>     class DOMWindow;
>diff --git a/Source/WebCore/dom/ExceptionBase.cpp b/Source/WebCore/dom/ExceptionBase.cpp
>index edca70674a904eebe720f6736e3fd3cf503efe30..20b8145c8418c76fc1c6eb1545a12fceb4a2c4f1 100644
>--- a/Source/WebCore/dom/ExceptionBase.cpp
>+++ b/Source/WebCore/dom/ExceptionBase.cpp
>@@ -28,6 +28,7 @@
> 
> #include "config.h"
> #include "ExceptionBase.h"
>+#include "ExceptionCode.h"
> 
> #include <wtf/text/StringConcatenate.h>
> 
>diff --git a/Source/WebCore/dom/ExceptionBase.h b/Source/WebCore/dom/ExceptionBase.h
>index 81e2d7f9b927e9ba5ee64c05624514c2d37ee726..7449c0ce6236cd83ae6c1a6538d15f2bff99345c 100644
>--- a/Source/WebCore/dom/ExceptionBase.h
>+++ b/Source/WebCore/dom/ExceptionBase.h
>@@ -29,12 +29,13 @@
> #ifndef ExceptionBase_h
> #define ExceptionBase_h
> 
>-#include "ExceptionCode.h"
> #include "PlatformString.h"
> #include <wtf/RefCounted.h>
> 
> namespace WebCore {
> 
>+    struct ExceptionCodeDescription;
>+
>     class ExceptionBase : public RefCounted<ExceptionBase> {
>     public:
>         unsigned short code() const { return m_code; }
>diff --git a/Source/WebCore/dom/MessagePort.cpp b/Source/WebCore/dom/MessagePort.cpp
>index 83a140a0cf4c9af5aad6f922b2153e5f183af031..472b9b1efa35ae7ba730fd30253cadf3ca572e26 100644
>--- a/Source/WebCore/dom/MessagePort.cpp
>+++ b/Source/WebCore/dom/MessagePort.cpp
>@@ -31,6 +31,7 @@
> #include "Document.h"
> #include "EventException.h"
> #include "EventNames.h"
>+#include "ExceptionCode.h"
> #include "MessageEvent.h"
> #include "SecurityOrigin.h"
> #include "Timer.h"
>diff --git a/Source/WebCore/dom/Range.cpp b/Source/WebCore/dom/Range.cpp
>index be196c88579eff8c33504a0b9c81a477dcc49a68..92867f203d3d191106dcde28bbddc6e305c00bd5 100644
>--- a/Source/WebCore/dom/Range.cpp
>+++ b/Source/WebCore/dom/Range.cpp
>@@ -28,6 +28,7 @@
> #include "ClientRect.h"
> #include "ClientRectList.h"
> #include "DocumentFragment.h"
>+#include "FloatQuad.h"
> #include "FrameView.h"
> #include "HTMLElement.h"
> #include "NodeWithIndex.h"
>diff --git a/Source/WebCore/dom/Range.h b/Source/WebCore/dom/Range.h
>index 062ad6783560f1c9f58cfeb75873202f08b48255..ab8c55592dc92d0021b7bf9b0ef86b63df0910f6 100644
>--- a/Source/WebCore/dom/Range.h
>+++ b/Source/WebCore/dom/Range.h
>@@ -25,7 +25,9 @@
> #ifndef Range_h
> #define Range_h
> 
>-#include "FloatQuad.h"
>+#include "FloatRect.h"
>+#include "IntRect.h"
>+#include "Node.h"
> #include "RangeBoundaryPoint.h"
> #include <wtf/Forward.h>
> #include <wtf/RefCounted.h>
>@@ -35,7 +37,10 @@ namespace WebCore {
> 
> class ClientRect;
> class ClientRectList;
>+class ContainerNode;
>+class Document;
> class DocumentFragment;
>+class FloatQuad;
> class NodeWithIndex;
> class Text;
> 
>diff --git a/Source/WebCore/dom/SelectElement.cpp b/Source/WebCore/dom/SelectElement.cpp
>index 583314ea29b50935e4ff8845d6c2e477e21e48bd..604b8c16765619905fab28b0b2bbeff5d025a87c 100644
>--- a/Source/WebCore/dom/SelectElement.cpp
>+++ b/Source/WebCore/dom/SelectElement.cpp
>@@ -25,6 +25,7 @@
> #include "Chrome.h"
> #include "ChromeClient.h"
> #include "Element.h"
>+#include "Event.h"
> #include "EventHandler.h"
> #include "EventNames.h"
> #include "FormDataList.h"
>diff --git a/Source/WebCore/dom/SelectElement.h b/Source/WebCore/dom/SelectElement.h
>index 6d2e2bd381dd77001508a16616cc81cf945f54c1..cba17d47cda5479f5ab9955b68518af00d5c7e2a 100644
>--- a/Source/WebCore/dom/SelectElement.h
>+++ b/Source/WebCore/dom/SelectElement.h
>@@ -22,9 +22,11 @@
> #ifndef SelectElement_h
> #define SelectElement_h
> 
>-#include "Event.h"
>+#include "DOMTimeStamp.h"
>+#include "PlatformString.h"
> #include <wtf/Forward.h>
> #include <wtf/Vector.h>
>+#include <wtf/unicode/Unicode.h>
> 
> namespace WebCore {
> 
>diff --git a/Source/WebCore/dom/TextEvent.cpp b/Source/WebCore/dom/TextEvent.cpp
>index b7bd1c875e37af743cd6ee42ae75b24ed9bc6f4c..90f4e7ba962409c30f723e5163218de7f0f25e2d 100644
>--- a/Source/WebCore/dom/TextEvent.cpp
>+++ b/Source/WebCore/dom/TextEvent.cpp
>@@ -27,6 +27,7 @@
> #include "config.h"
> #include "TextEvent.h"
> 
>+#include "DocumentFragment.h"
> #include "EventNames.h"
> 
> namespace WebCore {
>diff --git a/Source/WebCore/dom/TextEvent.h b/Source/WebCore/dom/TextEvent.h
>index 26c8b93d41022835d465304097e2aa2a1e03a9b8..cf4c8f29c5bbe2076c8d1dd0d44313b19f9485ed 100644
>--- a/Source/WebCore/dom/TextEvent.h
>+++ b/Source/WebCore/dom/TextEvent.h
>@@ -27,12 +27,13 @@
> #ifndef TextEvent_h
> #define TextEvent_h
> 
>-#include "DocumentFragment.h"
> #include "TextEventInputType.h"
> #include "UIEvent.h"
> 
> namespace WebCore {
> 
>+    class DocumentFragment;
>+
>     class TextEvent : public UIEvent {
>     public:
> 
>diff --git a/Source/WebCore/dom/Touch.cpp b/Source/WebCore/dom/Touch.cpp
>index fbb3feda424c1d8abb8f346ba9f83174fbd59c0e..e0681f217c1096d71474d9fdc320b522ebdf700b 100644
>--- a/Source/WebCore/dom/Touch.cpp
>+++ b/Source/WebCore/dom/Touch.cpp
>@@ -29,6 +29,7 @@
> 
> #include "Touch.h"
> 
>+#include "Frame.h"
> #include "FrameView.h"
> 
> namespace WebCore {
>diff --git a/Source/WebCore/dom/Touch.h b/Source/WebCore/dom/Touch.h
>index 54e85a53f01a0cce7f24fd6e340c6c37d17897d6..0ffd473da00c9e03234d5d4177019e2898a9c672 100644
>--- a/Source/WebCore/dom/Touch.h
>+++ b/Source/WebCore/dom/Touch.h
>@@ -29,13 +29,14 @@
> #if ENABLE(TOUCH_EVENTS)
> 
> #include "EventTarget.h"
>-#include "Frame.h"
> #include <wtf/PassRefPtr.h>
> #include <wtf/RefCounted.h>
> #include <wtf/RefPtr.h>
> 
> namespace WebCore {
> 
>+class Frame;
>+
> class Touch : public RefCounted<Touch> {
> public:
>     static PassRefPtr<Touch> create(Frame* frame, EventTarget* target,
>diff --git a/Source/WebCore/dom/TouchEvent.cpp b/Source/WebCore/dom/TouchEvent.cpp
>index 225e3aef5574a0045c2a721d81162c1b7349be21..5277d38cec3387496fddff3e88c16ab2add77aad 100644
>--- a/Source/WebCore/dom/TouchEvent.cpp
>+++ b/Source/WebCore/dom/TouchEvent.cpp
>@@ -28,6 +28,7 @@
> #if ENABLE(TOUCH_EVENTS)
> 
> #include "TouchEvent.h"
>+#include "TouchList.h"
> 
> namespace WebCore {
> 
>diff --git a/Source/WebCore/dom/TouchEvent.h b/Source/WebCore/dom/TouchEvent.h
>index 1514cf8b04fbb881ec1370dd4c2c2ef7423713b4..26fc5fcf579158c8722c7351b9cd8be549d28ce1 100644
>--- a/Source/WebCore/dom/TouchEvent.h
>+++ b/Source/WebCore/dom/TouchEvent.h
>@@ -29,10 +29,11 @@
> #if ENABLE(TOUCH_EVENTS)
> 
> #include "MouseRelatedEvent.h"
>-#include "TouchList.h"
> 
> namespace WebCore {
> 
>+class TouchList;
>+
> class TouchEvent : public MouseRelatedEvent {
> public:
>     virtual ~TouchEvent();
>diff --git a/Source/WebCore/dom/XMLDocumentParser.h b/Source/WebCore/dom/XMLDocumentParser.h
>index 4e42a1004b6cc3da6aa000375f5df407b605088b..2043addd62e12b733375836eef1bad57e833a98b 100644
>--- a/Source/WebCore/dom/XMLDocumentParser.h
>+++ b/Source/WebCore/dom/XMLDocumentParser.h
>@@ -51,7 +51,6 @@ namespace WebCore {
>     class Element;
>     class FrameView;
>     class PendingCallbacks;
>-    class ScriptElement;
> 
> #if !USE(QXMLSTREAM)
>     class XMLParserContext : public RefCounted<XMLParserContext> {
>diff --git a/Source/WebCore/dom/XMLDocumentParserScope.h b/Source/WebCore/dom/XMLDocumentParserScope.h
>index f60471bb7816322ac97dfe2a81a4907901aa43e9..c04043b48b11ec5b88360ae3e179b5d1ee12dffb 100644
>--- a/Source/WebCore/dom/XMLDocumentParserScope.h
>+++ b/Source/WebCore/dom/XMLDocumentParserScope.h
>@@ -29,7 +29,7 @@
> #include <wtf/Noncopyable.h>
> 
> #if ENABLE(XSLT)
>-#include <libxml/tree.h>
>+#include <libxml/xmlerror.h>
> #endif
> 
> namespace WebCore {
>diff --git a/Source/WebCore/editing/AppendNodeCommand.cpp b/Source/WebCore/editing/AppendNodeCommand.cpp
>index 9395968b8c7eceda372bfb2645becabea20c2a68..e3f34e0ab7c8f2bf8c15cc6fe6ed53039ebbb5c5 100644
>--- a/Source/WebCore/editing/AppendNodeCommand.cpp
>+++ b/Source/WebCore/editing/AppendNodeCommand.cpp
>@@ -27,6 +27,7 @@
> #include "AppendNodeCommand.h"
> 
> #include "AXObjectCache.h"
>+#include "Document.h"
> #include "htmlediting.h"
> 
> namespace WebCore {
>diff --git a/Source/WebCore/editing/ApplyBlockElementCommand.h b/Source/WebCore/editing/ApplyBlockElementCommand.h
>index 535f499b0d580ac2f2ccdb97f048767e413c86f5..0d4953e75b57a60d20623049f24aeee9108606e3 100644
>--- a/Source/WebCore/editing/ApplyBlockElementCommand.h
>+++ b/Source/WebCore/editing/ApplyBlockElementCommand.h
>@@ -32,6 +32,7 @@
> #define ApplyBlockElementCommand_h
> 
> #include "CompositeEditCommand.h"
>+#include "QualifiedName.h"
> 
> namespace WebCore {
> 
>diff --git a/Source/WebCore/editing/DeleteFromTextNodeCommand.cpp b/Source/WebCore/editing/DeleteFromTextNodeCommand.cpp
>index 8ee28a1b3a029e43547b805d4182a932500d5e1f..1b4e09deb3fd38038abd45d3e11caa6dd7558946 100644
>--- a/Source/WebCore/editing/DeleteFromTextNodeCommand.cpp
>+++ b/Source/WebCore/editing/DeleteFromTextNodeCommand.cpp
>@@ -25,6 +25,7 @@
> 
> #include "config.h"
> #include "DeleteFromTextNodeCommand.h"
>+#include "Document.h"
> 
> #include "AXObjectCache.h"
> #include "Text.h"
>diff --git a/Source/WebCore/editing/EditCommand.h b/Source/WebCore/editing/EditCommand.h
>index dc20eec745e11d456ad6772d8e4231a4ce113962..ad2eab5f25f6b60130131d1e3677b51fef10f7b3 100644
>--- a/Source/WebCore/editing/EditCommand.h
>+++ b/Source/WebCore/editing/EditCommand.h
>@@ -27,12 +27,13 @@
> #define EditCommand_h
> 
> #include "EditAction.h"
>-#include "Element.h"
> #include "VisibleSelection.h"
> 
> namespace WebCore {
> 
> class CompositeEditCommand;
>+class Document;
>+class Element;
> 
> class EditCommand : public RefCounted<EditCommand> {
> public:
>diff --git a/Source/WebCore/editing/Editor.h b/Source/WebCore/editing/Editor.h
>index c02d0acc55d47974804b2a3658e661ff65af5851..2ff67afbd9c27c0c1df6bd907fa46888c3e9b0ca 100644
>--- a/Source/WebCore/editing/Editor.h
>+++ b/Source/WebCore/editing/Editor.h
>@@ -31,7 +31,7 @@
> #include "DocumentMarker.h"
> #include "EditAction.h"
> #include "EditingBehavior.h"
>-#include "EditorDeleteAction.h"
>+#include "EditingStyle.h"
> #include "EditorInsertAction.h"
> #include "FindOptions.h"
> #include "FrameSelection.h"
>@@ -46,7 +46,6 @@ typedef int NSWritingDirection;
> 
> namespace WebCore {
> 
>-class CSSMutableStyleDeclaration;
> class CSSStyleDeclaration;
> class Clipboard;
> class SpellingCorrectionController;
>diff --git a/Source/WebCore/editing/FormatBlockCommand.h b/Source/WebCore/editing/FormatBlockCommand.h
>index 4be235f173b8f23c049dbe075dd5615a0a5598d4..39128ccacfa567e850b50854f58f726298eb762f 100644
>--- a/Source/WebCore/editing/FormatBlockCommand.h
>+++ b/Source/WebCore/editing/FormatBlockCommand.h
>@@ -27,9 +27,16 @@
> #define FormatBlockCommand_h
> 
> #include "ApplyBlockElementCommand.h"
>-#include "CompositeEditCommand.h"
>+#include "EditAction.h"
>+#include "QualifiedName.h"
> 
> namespace WebCore {
>+    
>+class Document;
>+class Element;
>+class Position;
>+class Range;
>+class VisiblePosition;
> 
> class FormatBlockCommand : public ApplyBlockElementCommand {
> public:
>diff --git a/Source/WebCore/editing/IndentOutdentCommand.h b/Source/WebCore/editing/IndentOutdentCommand.h
>index c28aea3a6694791a4dd27166cd0f69c1a249d7b6..f070d3da890760e909dff94cf2a126124cc13ddf 100644
>--- a/Source/WebCore/editing/IndentOutdentCommand.h
>+++ b/Source/WebCore/editing/IndentOutdentCommand.h
>@@ -27,7 +27,7 @@
> #define IndentOutdentCommand_h
> 
> #include "ApplyBlockElementCommand.h"
>-#include "CompositeEditCommand.h"
>+#include "EditAction.h"
> 
> namespace WebCore {
> 
>diff --git a/Source/WebCore/editing/InsertIntoTextNodeCommand.cpp b/Source/WebCore/editing/InsertIntoTextNodeCommand.cpp
>index b1a455bac11b53519004f53bfd1a30096f147253..9b092f9092432a13960666cad5b7d5525e0ff660 100644
>--- a/Source/WebCore/editing/InsertIntoTextNodeCommand.cpp
>+++ b/Source/WebCore/editing/InsertIntoTextNodeCommand.cpp
>@@ -27,6 +27,7 @@
> #include "InsertIntoTextNodeCommand.h"
> 
> #include "AXObjectCache.h"
>+#include "Document.h"
> #include "Text.h"
> 
> namespace WebCore {
>diff --git a/Source/WebCore/editing/InsertNodeBeforeCommand.cpp b/Source/WebCore/editing/InsertNodeBeforeCommand.cpp
>index 4b028e71167c1662004e5455b43afdda27af713b..308e0ed4b1b64d3a747c14ebb507abfbd874d23b 100644
>--- a/Source/WebCore/editing/InsertNodeBeforeCommand.cpp
>+++ b/Source/WebCore/editing/InsertNodeBeforeCommand.cpp
>@@ -27,6 +27,7 @@
> #include "InsertNodeBeforeCommand.h"
> 
> #include "AXObjectCache.h"
>+#include "Document.h"
> #include "htmlediting.h"
> 
> namespace WebCore {
>diff --git a/Source/WebCore/editing/ReplaceSelectionCommand.h b/Source/WebCore/editing/ReplaceSelectionCommand.h
>index 3d49af11e7597abf26e3488fde7300ce0e5044d7..77559f44226bcf6dd4e56e39fdc157928494643b 100644
>--- a/Source/WebCore/editing/ReplaceSelectionCommand.h
>+++ b/Source/WebCore/editing/ReplaceSelectionCommand.h
>@@ -30,8 +30,10 @@
> 
> namespace WebCore {
> 
>+class CSSMutableStyleDeclaration;
> class DocumentFragment;
> class EditingStyle;
>+class Node;
> class ReplacementFragment;
> 
> class ReplaceSelectionCommand : public CompositeEditCommand {
>diff --git a/Source/WebCore/editing/SetNodeAttributeCommand.h b/Source/WebCore/editing/SetNodeAttributeCommand.h
>index ce3a1ec10429f817016634cde3f0f6692a00e7db..899ac627ec7501b72d7b8d337d414eccd82fce1d 100644
>--- a/Source/WebCore/editing/SetNodeAttributeCommand.h
>+++ b/Source/WebCore/editing/SetNodeAttributeCommand.h
>@@ -27,6 +27,7 @@
> #define SetNodeAttributeCommand_h
> 
> #include "EditCommand.h"
>+#include "QualifiedName.h"
> 
> namespace WebCore {
> 
>diff --git a/Source/WebCore/html/HTMLSelectElement.h b/Source/WebCore/html/HTMLSelectElement.h
>index e6e1bec2bc526d79fbdd9d15b221640c0b592ad2..47cfa6f9c300ea6bde79950177541a56a08314b5 100644
>--- a/Source/WebCore/html/HTMLSelectElement.h
>+++ b/Source/WebCore/html/HTMLSelectElement.h
>@@ -27,6 +27,7 @@
> #define HTMLSelectElement_h
> 
> #include "CollectionCache.h"
>+#include "Event.h"
> #include "HTMLFormControlElement.h"
> #include "SelectElement.h"
> 
>diff --git a/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp b/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
>index 7500854df414a97b8c8887178d551f174dccbc49..5b19c0d5c7a572f99a39f74a21d249a5f2ea8d11 100644
>--- a/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
>+++ b/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
>@@ -32,6 +32,7 @@
> #include "CanvasRenderingContext2D.h"
> 
> #include "AffineTransform.h"
>+#include "CSSFontSelector.h"
> #include "CSSMutableStyleDeclaration.h"
> #include "CSSParser.h"
> #include "CSSPropertyNames.h"
>diff --git a/Source/WebCore/loader/appcache/DOMApplicationCache.cpp b/Source/WebCore/loader/appcache/DOMApplicationCache.cpp
>index 080a3ef411bcbe86c223f5425c28171522420f47..3535b543e138934d5be4a18285a386539fee26ee 100644
>--- a/Source/WebCore/loader/appcache/DOMApplicationCache.cpp
>+++ b/Source/WebCore/loader/appcache/DOMApplicationCache.cpp
>@@ -35,6 +35,7 @@
> #include "EventException.h"
> #include "EventListener.h"
> #include "EventNames.h"
>+#include "ExceptionCode.h"
> #include "Frame.h"
> #include "FrameLoader.h"
> 
>diff --git a/Source/WebCore/page/EventSource.cpp b/Source/WebCore/page/EventSource.cpp
>index 97d76766a53448658bc826cfcff480f10df5021a..020d4648177b4c041d1a6a9ba596eb29585db023 100644
>--- a/Source/WebCore/page/EventSource.cpp
>+++ b/Source/WebCore/page/EventSource.cpp
>@@ -41,6 +41,7 @@
> #include "DOMWindow.h"
> #include "Event.h"
> #include "EventException.h"
>+#include "ExceptionCode.h"
> #include "PlatformString.h"
> #include "MessageEvent.h"
> #include "ResourceError.h"
>diff --git a/Source/WebCore/rendering/RenderListBox.cpp b/Source/WebCore/rendering/RenderListBox.cpp
>index 337903dd479801279f66ea061402c6868782b2dd..3eb0c6b9cb34ce72127bf316d84d00721fc4dd4e 100644
>--- a/Source/WebCore/rendering/RenderListBox.cpp
>+++ b/Source/WebCore/rendering/RenderListBox.cpp
>@@ -31,6 +31,7 @@
> #include "RenderListBox.h"
> 
> #include "AXObjectCache.h"
>+#include "CSSFontSelector.h"
> #include "CSSStyleSelector.h"
> #include "Document.h"
> #include "EventHandler.h"
>diff --git a/Source/WebCore/rendering/RenderMenuList.cpp b/Source/WebCore/rendering/RenderMenuList.cpp
>index f155614a8e373a6acb69c76875b4f9b50bb23e3e..f396b7d99d853dc2a7fd97d84198aeba02cea61f 100644
>--- a/Source/WebCore/rendering/RenderMenuList.cpp
>+++ b/Source/WebCore/rendering/RenderMenuList.cpp
>@@ -26,8 +26,9 @@
> #include "RenderMenuList.h"
> 
> #include "AXObjectCache.h"
>-#include "Chrome.h"
>+#include "CSSFontSelector.h"
> #include "CSSStyleSelector.h"
>+#include "Chrome.h"
> #include "Frame.h"
> #include "FrameView.h"
> #include "HTMLNames.h"
>diff --git a/Source/WebCore/rendering/RenderTextControlSingleLine.cpp b/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
>index 2adb82a2e541a19a548cc39027c0bc83f4971910..61b82940b511b1838a7f514782b23669b3cdaf0f 100644
>--- a/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
>+++ b/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
>@@ -24,8 +24,9 @@
> #include "config.h"
> #include "RenderTextControlSingleLine.h"
> 
>-#include "Chrome.h"
>+#include "CSSFontSelector.h"
> #include "CSSStyleSelector.h"
>+#include "Chrome.h"
> #include "Event.h"
> #include "EventNames.h"
> #include "Frame.h"
>diff --git a/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp b/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
>index 5760bedabeb0d5f0ba896ed5e5e0acd34347938f..0a6dd57236c75e66fc7d8ccca979ebb6e90646c6 100644
>--- a/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
>+++ b/Source/WebCore/rendering/svg/RenderSVGInlineText.cpp
>@@ -26,6 +26,7 @@
> #if ENABLE(SVG)
> #include "RenderSVGInlineText.h"
> 
>+#include "CSSFontSelector.h"
> #include "CSSStyleSelector.h"
> #include "FloatConversion.h"
> #include "FloatQuad.h"
>diff --git a/Source/WebCore/svg/SVGMatrix.h b/Source/WebCore/svg/SVGMatrix.h
>index 077eb038348664874f7bc5bc30abae33c2f6cc78..e226bf5d2527aebc00370334a7de897e1ad128d2 100644
>--- a/Source/WebCore/svg/SVGMatrix.h
>+++ b/Source/WebCore/svg/SVGMatrix.h
>@@ -22,6 +22,7 @@
> 
> #if ENABLE(SVG)
> #include "AffineTransform.h"
>+#include "ExceptionCode.h"
> #include "SVGException.h"
> 
> namespace WebCore {
>diff --git a/Source/WebCore/websockets/WebSocket.cpp b/Source/WebCore/websockets/WebSocket.cpp
>index 584444c1db1772ae0433e454761993dc9124f63e..4b5bab6bb1d340b9047bc3506944722e1d6fe8b5 100644
>--- a/Source/WebCore/websockets/WebSocket.cpp
>+++ b/Source/WebCore/websockets/WebSocket.cpp
>@@ -39,6 +39,7 @@
> #include "EventException.h"
> #include "EventListener.h"
> #include "EventNames.h"
>+#include "ExceptionCode.h"
> #include "Logging.h"
> #include "MessageEvent.h"
> #include "ScriptCallStack.h"
>diff --git a/Source/WebCore/workers/AbstractWorker.cpp b/Source/WebCore/workers/AbstractWorker.cpp
>index 18a94b59371fba9234d57f47389715667e7dbc7f..32ef9bfbbc1554e2a66683e18f370fdbff8b0087 100644
>--- a/Source/WebCore/workers/AbstractWorker.cpp
>+++ b/Source/WebCore/workers/AbstractWorker.cpp
>@@ -38,6 +38,7 @@
> #include "Event.h"
> #include "EventException.h"
> #include "EventNames.h"
>+#include "ExceptionCode.h"
> #include "InspectorInstrumentation.h"
> #include "ScriptExecutionContext.h"
> #include "SecurityOrigin.h"
>diff --git a/Source/WebCore/xml/XMLHttpRequest.cpp b/Source/WebCore/xml/XMLHttpRequest.cpp
>index ed1e2157d3aa2daa81856a47d4d076f998a90e8a..ae4f0458c661d4736df94d3d9fcd0cd335350c4f 100644
>--- a/Source/WebCore/xml/XMLHttpRequest.cpp
>+++ b/Source/WebCore/xml/XMLHttpRequest.cpp
>@@ -33,6 +33,7 @@
> #include "EventException.h"
> #include "EventListener.h"
> #include "EventNames.h"
>+#include "ExceptionCode.h"
> #include "File.h"
> #include "HTTPParsers.h"
> #include "InspectorInstrumentation.h"
>diff --git a/Source/WebCore/xml/XPathExpression.cpp b/Source/WebCore/xml/XPathExpression.cpp
>index 618842649be955a6e71145bbfd688385d7840517..91ac06c224e59fb48a23c177f3a2749b82c38b69 100644
>--- a/Source/WebCore/xml/XPathExpression.cpp
>+++ b/Source/WebCore/xml/XPathExpression.cpp
>@@ -30,6 +30,7 @@
> #if ENABLE(XPATH)
> 
> #include "Document.h"
>+#include "ExceptionCode.h"
> #include "PlatformString.h"
> #include "XPathException.h"
> #include "XPathExpressionNode.h"
>diff --git a/Source/WebKit2/ChangeLog b/Source/WebKit2/ChangeLog
>index d012ffcf5ff11807638e71fb750845b768257c11..c073657e92a92f8e21e66acfbf5e9f556aa9d7d5 100644
>--- a/Source/WebKit2/ChangeLog
>+++ b/Source/WebKit2/ChangeLog
>@@ -1,3 +1,12 @@
>+2011-05-06  Tony Gentilcore  <tonyg@chromium.org>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Fix some unnecessary includes in headers
>+        https://bugs.webkit.org/show_bug.cgi?id=60388
>+
>+        * WebProcess/FullScreen/WebFullScreenManager.cpp:
>+
> 2011-05-06  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         Reviewed by Martin Robinson.
>diff --git a/Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp b/Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp
>index 47f1d42ba3230705c47df67b3a445822935a92ac..ed8693481a683a563b7be224ec7c367a695ce7e1 100644
>--- a/Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp
>+++ b/Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp
>@@ -34,6 +34,7 @@
> #include "WebPage.h"
> #include "WebProcess.h"
> #include <WebCore/Color.h>
>+#include <WebCore/Element.h>
> #include <WebCore/Page.h>
> #include <WebCore/Settings.h>
>

Actions: View | Formatted Diff | Diff

Attachments on bug 60388: 92611 | 92770 | 92771 | 92775 | 92778 | 92782