Attachment 6965 Details for Bug 7675 – patch

[patch] patch

visible_patch.txt (text/plain), 4.89 KB, created by Adele Peterson on 2006-03-09 14:10:50 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Adele Peterson

Created: 2006-03-09 14:10:50 PST

Size: 4.89 KB

patch

obsolete

>Index: WebCore/ChangeLog
>===================================================================
>--- WebCore/ChangeLog	(revision 13236)
>+++ WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2006-03-09  Adele Peterson  <adele@apple.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7675
>+        When new text fields change from visibility:hidden to visibility:visible, value doesn't display
>+
>+        Test: fast/forms/input-appearance-visibility.html
>+
>+        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::setStyle):
>+        Sets the style directly on the children of the inner div.
>+
> 2006-03-09  David Hyatt <hyatt@apple.com>
> 
>         Make basic text rendering work on Win32.
>Index: WebCore/rendering/RenderTextField.cpp
>===================================================================
>--- WebCore/rendering/RenderTextField.cpp	(revision 13234)
>+++ WebCore/rendering/RenderTextField.cpp	(working copy)
>@@ -57,6 +57,9 @@
>         RenderBlock* divRenderer = static_cast<RenderBlock*>(m_div->renderer());
>         RenderStyle* divStyle = createDivStyle(style);
>         divRenderer->setStyle(divStyle);
>+        for (NodeImpl *n = m_div->firstChild(); n; n = n->nextSibling())
>+            if (n->renderer())
>+                n->renderer()->setStyle(style);
>     }
>     setReplaced(isInline());
> }
>Index: LayoutTests/ChangeLog
>===================================================================
>--- LayoutTests/ChangeLog	(revision 13236)
>+++ LayoutTests/ChangeLog	(working copy)
>@@ -1,6 +1,16 @@
> 2006-03-09  Adele Peterson  <adele@apple.com>
> 
>-        - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=6814
>+        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7675
>+        When new text fields change from visibility:hidden to visibility:visible, value doesn't display
>+
>+        * fast/forms/input-appearance-visibility-expected.checksum: Added.
>+        * fast/forms/input-appearance-visibility-expected.png: Added.
>+        * fast/forms/input-appearance-visibility-expected.txt: Added.
>+        * fast/forms/input-appearance-visibility.html: Added.
>+
>+2006-03-09  Adele Peterson  <adele@apple.com>
>+
>+        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6814
>         Implement selection methods for RenderTextField
> 
>         * fast/forms/input-appearance-selection-expected.checksum: Added.
>Index: LayoutTests/fast/forms/input-appearance-visibility-expected.txt
>===================================================================
>--- LayoutTests/fast/forms/input-appearance-visibility-expected.txt	(revision 0)
>+++ LayoutTests/fast/forms/input-appearance-visibility-expected.txt	(revision 0)
>@@ -0,0 +1,17 @@
>+layer at (0,0) size 800x600
>+  RenderCanvas at (0,0) size 800x600
>+layer at (0,0) size 800x600
>+  RenderBlock {HTML} at (0,0) size 800x600
>+    RenderBody {BODY} at (8,8) size 784x576
>+      RenderBlock (anonymous) at (0,0) size 784x18
>+        RenderText {TEXT} at (0,0) size 480x18
>+          text run at (0,0) width 480: "This tests that the value becomes visible when the text field becomes visible."
>+      RenderBlock {P} at (0,34) size 784x23
>+        RenderTextField {INPUT} at (2,2) size 186x19
>+        RenderText {TEXT} at (0,0) size 0x0
>+      RenderBlock {DIV} at (0,73) size 784x0
>+      RenderBlock {P} at (0,73) size 784x0
>+layer at (13,47) size 180x13
>+  RenderBlock {DIV} at (3,3) size 180x13
>+    RenderText {TEXT} at (0,0) size 63x13
>+      text run at (0,0) width 63: "Test Passed"
>Index: LayoutTests/fast/forms/input-appearance-visibility-expected.checksum
>===================================================================
>--- LayoutTests/fast/forms/input-appearance-visibility-expected.checksum	(revision 0)
>+++ LayoutTests/fast/forms/input-appearance-visibility-expected.checksum	(revision 0)
>@@ -0,0 +1 @@
>+b7fff23d0e58be5137518ff3596f9659
>\ No newline at end of file
>Index: LayoutTests/fast/forms/input-appearance-visibility.html
>===================================================================
>--- LayoutTests/fast/forms/input-appearance-visibility.html	(revision 0)
>+++ LayoutTests/fast/forms/input-appearance-visibility.html	(revision 0)
>@@ -0,0 +1,9 @@
>+<html>
>+<body onload="document.getElementById('t1').style.visibility ='visible'">
>+This tests that the value becomes visible when the text field becomes visible.
>+<p>
>+<input type="text" id="t1" style="-khtml-appearance:textfield; visibility:hidden" value="Test Passed"></input>
>+<div id="result"></div>
>+</p>
>+</body>
>+</html>
>\ No newline at end of file
>Index: LayoutTests/fast/forms/input-appearance-visibility-expected.png
>===================================================================
>Cannot display: file marked as a binary type.
>svn:mime-type = application/octet-stream
>
>Property changes on: LayoutTests/fast/forms/input-appearance-visibility-expected.png
>___________________________________________________________________
>Name: svn:mime-type
>   + application/octet-stream
>

Flags:

justin.garcia: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 7675: 6949 | 6965 | 6966