WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch to add a showModalDialog support for DumpRenderTree on Mac
DRTShowModalDialog.txt (text/plain), 57.83 KB, created by
Prasad Tammana
on 2010-06-01 16:23:26 PDT
(
hide
)
Description:
Patch to add a showModalDialog support for DumpRenderTree on Mac
Filename:
MIME Type:
Creator:
Prasad Tammana
Created:
2010-06-01 16:23:26 PDT
Size:
57.83 KB
patch
obsolete
>Index: WebKit/mac/WebCoreSupport/WebChromeClient.mm >=================================================================== >--- WebKit/mac/WebCoreSupport/WebChromeClient.mm (revision 60368) >+++ WebKit/mac/WebCoreSupport/WebChromeClient.mm (working copy) >@@ -357,7 +357,9 @@ > > [m_webView setGroupName:nil]; > [m_webView stopLoading:nil]; >- [m_webView performSelector:@selector(_closeWindow) withObject:nil afterDelay:0.0]; >+ [m_webView performSelector:@selector(_closeWindow) withObject:nil afterDelay:0.0 >+ inModes:[NSArray arrayWithObjects:NSDefaultRunLoopMode, NSModalPanelRunLoopMode, >+ NSConnectionReplyMode, NSEventTrackingRunLoopMode, nil]]; > } > > void WebChromeClient::runJavaScriptAlert(Frame* frame, const String& message) >Index: WebKit/mac/ChangeLog >=================================================================== >--- WebKit/mac/ChangeLog (revision 60374) >+++ WebKit/mac/ChangeLog (working copy) >@@ -1,3 +1,17 @@ >+2010-05-28 Prasad Tammana <prasadt@chromium.org> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ DumpRenderTree should allow tests with modal dialogs >+ https://bugs.webkit.org/show_bug.cgi?id=35350 >+ >+ * WebCoreSupport/WebChromeClient.mm: >+ (WebChromeClient::closeWindowSoon): performSelector:withObject:afterDelay method is being used to >+ post the _closeWindow message to the queue. Those message will only get dispatched if the >+ RunLoop is in NSDefaultRunLoopMode. Since RunLoop is in NSModalPanelRunLoopMode mode when a >+ modal window is being displayed, you can't close the window. Replaced the call with the inModes >+ version to allow the close window message to be dispatched in all RunLoop modes. >+ > 2010-05-27 Beth Dakin <bdakin@apple.com> > > Reviewed by Simon Fraser. >Index: LayoutTests/http/tests/security/cross-frame-access-put-expected.txt >=================================================================== >--- LayoutTests/http/tests/security/cross-frame-access-put-expected.txt (revision 60368) >+++ LayoutTests/http/tests/security/cross-frame-access-put-expected.txt (working copy) >@@ -562,7 +562,7 @@ > ALERT: PASS: window.scrollTo should be 'function scrollTo() { [native code]}' and is. > ALERT: PASS: window.setInterval should be 'function setInterval() { [native code]}' and is. > ALERT: PASS: window.setTimeout should be 'function setTimeout() { [native code]}' and is. >-ALERT: PASS: window.showModalDialog should be 'undefined' and is. >+ALERT: PASS: window.showModalDialog matched the expected value. > ALERT: PASS: window.stop should be 'function stop() { [native code]}' and is. > This test checks cross-frame access security of window attribute setters (rdar://problem/5326791). > >Index: LayoutTests/http/tests/security/cross-frame-access-get-expected.txt >=================================================================== >--- LayoutTests/http/tests/security/cross-frame-access-get-expected.txt (revision 60368) >+++ LayoutTests/http/tests/security/cross-frame-access-get-expected.txt (working copy) >@@ -372,8 +372,6 @@ > > CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-get-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-get.html. Domains, protocols and ports must match. > >-CONSOLE MESSAGE: line 1: Unsafe JavaScript attempt to access frame with URL http://localhost:8000/security/resources/cross-frame-iframe-for-get-test.html from frame with URL http://127.0.0.1:8000/security/cross-frame-access-get.html. Domains, protocols and ports must match. >- > This test checks cross-frame access security (rdar://problem/5251309). > > >@@ -533,7 +531,6 @@ > PASS: canGet('targetWindow.scrollTo') should be 'false' and is. > PASS: canGet('targetWindow.setInterval') should be 'false' and is. > PASS: canGet('targetWindow.setTimeout') should be 'false' and is. >-PASS: canGet('targetWindow.showModalDialog') should be 'false' and is. > PASS: canGet('targetWindow.stop') should be 'false' and is. > > ----- tests for getting of not allowed Attributes ----- >Index: LayoutTests/http/tests/security/cross-frame-access-get.html >=================================================================== >--- LayoutTests/http/tests/security/cross-frame-access-get.html (revision 60368) >+++ LayoutTests/http/tests/security/cross-frame-access-get.html (working copy) >@@ -132,7 +132,9 @@ > "scrollTo", > "setInterval", > "setTimeout", >- "showModalDialog", >+ // FIXME: This function is now implemented on mac and hence the expected output changes. Uncomment after adding a >+ // mac specific test for showModalDialog. Bug# 39897 >+ // "showModalDialog", > "stop" > ]; > >Index: LayoutTests/http/tests/security/cross-frame-access-call-expected.txt >=================================================================== >--- LayoutTests/http/tests/security/cross-frame-access-call-expected.txt (revision 60368) >+++ LayoutTests/http/tests/security/cross-frame-access-call-expected.txt (working copy) >@@ -82,6 +82,5 @@ > PASS: window.moveTo.call(targetWindow, 0, 0); should be 'undefined' and is. > PASS: window.resizeBy.call(targetWindow, 0, 0); should be 'undefined' and is. > PASS: window.resizeTo.call(targetWindow, 0, 0); should be 'undefined' and is. >-PASS: window.showModalDialog.call(targetWindow); should be 'TypeError: Result of expression 'window.showModalDialog' [undefined] is not an object.' and is. > PASS: window.location.toString.call(targetWindow.location) should be 'undefined' and is. > >Index: LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html >=================================================================== >--- LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html (revision 60368) >+++ LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html (working copy) >@@ -459,7 +459,9 @@ > shouldBe("window.scrollTo", "scrollToOld"); > shouldBe("window.setInterval", "setIntervalOld"); > shouldBe("window.setTimeout", "setTimeoutOld"); >- shouldBe("window.showModalDialog", "showModalDialogOld"); >+ >+ // showModalDialog is not implemented on all platforms for DumpRenderTree. So don't display the values. >+ shouldBe("window.showModalDialog", "showModalDialogOld", true); > shouldBe("window.stop", "stopOld"); > }, 0); > </script> >Index: LayoutTests/http/tests/security/cross-frame-access-call.html >=================================================================== >--- LayoutTests/http/tests/security/cross-frame-access-call.html (revision 60368) >+++ LayoutTests/http/tests/security/cross-frame-access-call.html (working copy) >@@ -55,8 +55,9 @@ > shouldBe("window.resizeBy.call(targetWindow, 0, 0);", "undefined"); > shouldBe("window.resizeTo.call(targetWindow, 0, 0);", "undefined"); > >+ // FIXME: showModalDialog now works on DRT and thus breaks this test. Will uncomment after adding a separate test for Mac for showModalDialog - Bug #39897 > // Throws a TypeError and logs to the error console >- shouldBe("window.showModalDialog.call(targetWindow);", '"TypeError: Result of expression \'window.showModalDialog\' [undefined] is not an object."'); >+ // shouldBe("window.showModalDialog.call(targetWindow);", '"TypeError: Result of expression \'window.showModalDialog\' [undefined] is not an object."'); > > // - Tests for the Location object - > // undefined value indicates failure >Index: LayoutTests/platform/chromium/test_expectations.txt >=================================================================== >--- LayoutTests/platform/chromium/test_expectations.txt (revision 60368) >+++ LayoutTests/platform/chromium/test_expectations.txt (working copy) >@@ -2859,3 +2859,29 @@ > BUG45106 WIN : svg/clip-path/clip-path-text-and-shape.svg = PASS CRASH > BUG45106 WIN : svg/text/text-text-04-t.svg = PASS CRASH > BUG45106 WIN : svg/text/text-text-05-t.svg = PASS CRASH >+ >+# Related to https://bugs.webkit.org/show_bug.cgi?id=35350 >+BUG45048 : fast/events/show-modal-dialog-onblur-onfocus.html = FAIL >+BUG45048 : fast/harness/resources/modal-dialog.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9.html = FAIL >+BUG45048 : fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9.html = FAIL >Index: LayoutTests/platform/qt/Skipped >=================================================================== >--- LayoutTests/platform/qt/Skipped (revision 60368) >+++ LayoutTests/platform/qt/Skipped (working copy) >@@ -5096,3 +5096,29 @@ > # https://bugs.webkit.org/show_bug.cgi?id=39852 > fast/encoding/yentest.html > fast/encoding/yentest2.html >+ >+# https://bugs.webkit.org/show_bug.cgi?id=35350 >+fast/events/show-modal-dialog-onblur-onfocus.html >+fast/harness/resources/modal-dialog.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9.html >Index: LayoutTests/platform/gtk/Skipped >=================================================================== >--- LayoutTests/platform/gtk/Skipped (revision 60368) >+++ LayoutTests/platform/gtk/Skipped (working copy) >@@ -5942,3 +5942,29 @@ > fast/dom/Geolocation/argument-types.html > fast/dom/Geolocation/notimer-after-unload.html > fast/dom/Geolocation/timeout-zero.html >+ >+# https://bugs.webkit.org/show_bug.cgi?id=35350 >+fast/events/show-modal-dialog-onblur-onfocus.html >+fast/harness/resources/modal-dialog.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9.html >Index: LayoutTests/platform/win/Skipped >=================================================================== >--- LayoutTests/platform/win/Skipped (revision 60368) >+++ LayoutTests/platform/win/Skipped (working copy) >@@ -887,3 +887,29 @@ > # This port doesn't support DeviceOrientation. > fast/dom/DeviceOrientation > fast/dom/Window/window-properties-on-device-orientation.html >+ >+# https://bugs.webkit.org/show_bug.cgi?id=35350 >+fast/events/show-modal-dialog-onblur-onfocus.html >+fast/harness/resources/modal-dialog.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9.html >+fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9.html >Index: LayoutTests/fast/events/show-modal-dialog-onblur-onfocus.html >=================================================================== >--- LayoutTests/fast/events/show-modal-dialog-onblur-onfocus.html (revision 0) >+++ LayoutTests/fast/events/show-modal-dialog-onblur-onfocus.html (revision 0) >@@ -0,0 +1,47 @@ >+<html> >+<head> >+<script> >+ function runTests() >+ { >+ window.onfocus = onFocusFunc; >+ window.onblur = onBlurFunc; >+ if (window.layoutTestController) { >+ layoutTestController.dumpAsText(); >+ layoutTestController.setCanOpenWindows(); >+ layoutTestController.waitUntilDone(); >+ >+ // DumpRenderTreeWindow does not respond to focus events. Forcing onblur event so >+ // that the results matches what you'll see in the browser. >+ layoutTestController.setWindowIsKey(false); >+ } >+ showModalDialog("resources/modal-dialog.html"); >+ } >+ >+ function log(message) >+ { >+ var console = document.getElementById("console"); >+ var li = document.createElement("li"); >+ var text = document.createTextNode(message); >+ >+ console.appendChild(li); >+ li.appendChild(text); >+ } >+ >+ function onBlurFunc() >+ { >+ log("onblur fired. Should see this exactly once."); >+ } >+ >+ function onFocusFunc() >+ { >+ log("ERROR: onfocus fired."); >+ } >+</script> >+</head> >+ >+<body onload="runTests()"> >+ <p>Pop up a modal dialog. Verifies that focus events are not fired while inside the message loop.</p><br/> >+ <p>You need to disable pop-up blocker for this test to run successfully in the browser.</p> >+ <ul id="console"></ul> >+</body> >+</html> >Index: LayoutTests/fast/events/resources/modal-dialog.html >=================================================================== >--- LayoutTests/fast/events/resources/modal-dialog.html (revision 0) >+++ LayoutTests/fast/events/resources/modal-dialog.html (revision 0) >@@ -0,0 +1,18 @@ >+<html> >+<head> >+<script> >+ function closeWindow() >+ { >+ if (window.layoutTestController) { >+ layoutTestController.notifyDone(); >+ } >+ opener.log("Modal dialog closing."); >+ close(); >+ } >+</script> >+</head> >+ >+<body onload="closeWindow()"> >+ This is a modal dialog. >+</body> >+</html> >Index: LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt >=================================================================== >--- LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt (revision 0) >+++ LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt (revision 0) >@@ -0,0 +1,7 @@ >+Pop up a modal dialog. Verifies that focus events are not fired while inside the message loop. >+ >+ >+You need to disable pop-up blocker for this test to run successfully in the browser. >+ >+onblur fired. Should see this exactly once. >+Modal dialog closing. >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T10 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T11 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T2 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T2 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T4 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T4 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T6 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T6 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T8 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T8 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T10 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T11 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T1 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T1 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T3 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T3 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T5 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T5 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T7 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T7 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.1_T9 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt >=================================================================== >--- LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt (revision 60368) >+++ LayoutTests/fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt (working copy) >@@ -1,6 +1,6 @@ > S10.2.2_A1.2_T9 > >-FAIL SputnikError: #1: scope chain must contain same objects in the same order as the calling context >+PASS > > TEST COMPLETE > >Index: LayoutTests/fast/dom/script-tests/prototype-inheritance.js >=================================================================== >--- LayoutTests/fast/dom/script-tests/prototype-inheritance.js (revision 60368) >+++ LayoutTests/fast/dom/script-tests/prototype-inheritance.js (working copy) >@@ -19,7 +19,7 @@ > "ArrayBuffer", > "Int8Array", "Uint8Array", "Int16Array", "Uint16Array", "Int32Array", "Uint32Array", "FloatArray", > "FileError", "FileReader", >- "indexedDB" >+ "indexedDB", "showModalDialog" > ]; > > var skippedPropertiesSet = {}; >Index: LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html >=================================================================== >--- LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html (revision 60368) >+++ LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html (working copy) >@@ -16,7 +16,7 @@ > document.getElementById("console").appendChild(paragraph); > } > >- function shouldBe(a, b) >+ function shouldBe(a, b, printOnlyOnFailure) > { > var evalA; > try { >@@ -24,8 +24,10 @@ > } catch(e) { > evalA = e; > } >- if (evalA == b) >- log("PASS: " + a + " should be " + b + " and is.", "green"); >+ if (evalA == b) { >+ if (!printOnlyOnFailure) >+ log("PASS: " + a + " should be " + b + " and is.", "green"); >+ } > else > log("FAIL: " + a + " should be " + b + " but instead is " + evalA, "red"); > } >@@ -36,7 +38,12 @@ > element.id = functionName; > document.body.appendChild(element); > >- shouldBe("typeof window." + functionName, "function"); >+ // showModalDialog only works on mac in the DRT. So run this test only if its defined and print output only on failure. >+ // This'll keep the output consistent on all platforms. >+ if (functionName == "showModalDialog" && window.showModalDialog != undefined) >+ shouldBe("typeof window." + functionName, "function", true); >+ else >+ shouldBe("typeof window." + functionName, "function"); > > document.body.removeChild(element); > } >Index: LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt >=================================================================== >--- LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt (revision 60368) >+++ LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt (working copy) >@@ -60,8 +60,6 @@ > PASS 'function setInterval() { [native code]}' is 'function setInterval() { [native code]}' > PASS 'function setTimeout() { [native code]}' is 'function setTimeout() { [native code]}' > PASS 'function setTimeout() { [native code]}' is 'function setTimeout() { [native code]}' >-FAIL win['showModalDialog'] should be null (of type object). Was undefined (of type undefined). >-FAIL win['showModalDialog'] should be null (of type object). Was undefined (of type undefined). > PASS 'function stop() { [native code]}' is 'function stop() { [native code]}' > PASS 'function stop() { [native code]}' is 'function stop() { [native code]}' > PASS 'function toString() { [native code]}' is 'function toString() { [native code]}' >Index: LayoutTests/fast/dom/Window/window-lookup-precedence.html >=================================================================== >--- LayoutTests/fast/dom/Window/window-lookup-precedence.html (revision 60368) >+++ LayoutTests/fast/dom/Window/window-lookup-precedence.html (working copy) >@@ -38,6 +38,9 @@ > function check(prop) { > var name = prop[0]; > var original = win[name]; >+ // showModalDialog is not currently implemented in DumpRenderTree for all platforms. >+ if (name == "showModalDialog") >+ return; > // Check subframe precedence. > try { > subframe[name] = name; >Index: LayoutTests/fast/dom/Window/window-properties-expected.txt >=================================================================== >--- LayoutTests/fast/dom/Window/window-properties-expected.txt (revision 60368) >+++ LayoutTests/fast/dom/Window/window-properties-expected.txt (working copy) >@@ -2224,7 +2224,6 @@ > window.sessionStorage [printed above as window.Storage.prototype] > window.setInterval [function] > window.setTimeout [function] >-window.showModalDialog [undefined] > window.status [string] > window.statusbar [object BarInfo] > window.statusbar.visible [boolean] >Index: LayoutTests/fast/dom/Window/window-function-frame-getter-precedence-expected.txt >=================================================================== >--- LayoutTests/fast/dom/Window/window-function-frame-getter-precedence-expected.txt (revision 60368) >+++ LayoutTests/fast/dom/Window/window-function-frame-getter-precedence-expected.txt (working copy) >@@ -30,7 +30,6 @@ > PASS: typeof window.clearInterval should be object and is. > PASS: typeof window.addEventListener should be object and is. > PASS: typeof window.removeEventListener should be object and is. >-FAIL: typeof window.showModalDialog should be object but instead is undefined > PASS: typeof window.captureEvents should be object and is. > PASS: typeof window.releaseEvents should be object and is. > FAIL: typeof window.eval should be object but instead is function >Index: LayoutTests/fast/dom/Window/window-properties.html >=================================================================== >--- LayoutTests/fast/dom/Window/window-properties.html (revision 60368) >+++ LayoutTests/fast/dom/Window/window-properties.html (working copy) >@@ -83,7 +83,10 @@ > "window.Blob.prototype.slice" : 1, > "window.FileError" : 1, > "window.FileReader" : 1, >- "window.ondeviceorientation" : 1 >+ "window.ondeviceorientation" : 1, >+ >+ // showModalDialog is not implemented on all platforms in DumpRenderTree. >+ "window.showModalDialog" : 1 > }; > > function logValue(valueName) >Index: LayoutTests/fast/dom/Window/window-function-frame-getter-precedence.html >=================================================================== >--- LayoutTests/fast/dom/Window/window-function-frame-getter-precedence.html (revision 60368) >+++ LayoutTests/fast/dom/Window/window-function-frame-getter-precedence.html (working copy) >@@ -16,7 +16,7 @@ > document.getElementById("console").appendChild(paragraph); > } > >- function shouldBe(a, b) >+ function shouldBe(a, b, printOnlyOnFailure) > { > var evalA; > try { >@@ -24,8 +24,10 @@ > } catch(e) { > evalA = e; > } >- if (evalA == b) >- log("PASS: " + a + " should be " + b + " and is.", "green"); >+ if (evalA == b) { >+ if (!printOnlyOnFailure) >+ log("PASS: " + a + " should be " + b + " and is.", "green"); >+ } > else > log("FAIL: " + a + " should be " + b + " but instead is " + evalA, "red"); > } >@@ -37,7 +39,12 @@ > iframe.name = functionName; > document.body.appendChild(iframe); > >- shouldBe("typeof window." + functionName, "object"); >+ // showModalDialog only works on mac in the DRT. So run this test only if its defined and print output only on failure. >+ // This'll keep the output consistent on all platforms. >+ if (functionName == "showModalDialog" && window.showModalDialog != undefined) >+ shouldBe("typeof window." + functionName, "object", true); >+ else >+ shouldBe("typeof window." + functionName, "object"); > > document.body.removeChild(iframe); > } >Index: LayoutTests/fast/dom/Window/window-function-name-getter-precedence-expected.txt >=================================================================== >--- LayoutTests/fast/dom/Window/window-function-name-getter-precedence-expected.txt (revision 60368) >+++ LayoutTests/fast/dom/Window/window-function-name-getter-precedence-expected.txt (working copy) >@@ -30,7 +30,6 @@ > PASS: typeof window.clearInterval should be function and is. > PASS: typeof window.addEventListener should be function and is. > PASS: typeof window.removeEventListener should be function and is. >-FAIL: typeof window.showModalDialog should be function but instead is undefined > PASS: typeof window.captureEvents should be function and is. > PASS: typeof window.releaseEvents should be function and is. > PASS: typeof window.eval should be function and is. >Index: LayoutTests/fast/harness/show-modal-dialog-expected.txt >=================================================================== >--- LayoutTests/fast/harness/show-modal-dialog-expected.txt (revision 0) >+++ LayoutTests/fast/harness/show-modal-dialog-expected.txt (revision 0) >@@ -0,0 +1,5 @@ >+This test verifies that showModalDialog implementation in DRT works. >+ >+You need to disable pop-up blocker for this test to run successfully. >+ >+Modal dialog closing. >Index: LayoutTests/fast/harness/resources/modal-dialog.html >=================================================================== >--- LayoutTests/fast/harness/resources/modal-dialog.html (revision 0) >+++ LayoutTests/fast/harness/resources/modal-dialog.html (revision 0) >@@ -0,0 +1,17 @@ >+<head> >+<script> >+ function closeWindow() >+ { >+ if (window.layoutTestController) { >+ layoutTestController.notifyDone(); >+ } >+ opener.log("Modal dialog closing."); >+ close(); >+ } >+</script> >+</head> >+ >+<body onload="closeWindow()"> >+ This is a modal dialog. >+</body> >+</html> >Index: LayoutTests/fast/harness/show-modal-dialog.html >=================================================================== >--- LayoutTests/fast/harness/show-modal-dialog.html (revision 0) >+++ LayoutTests/fast/harness/show-modal-dialog.html (revision 0) >@@ -0,0 +1,31 @@ >+<html> >+<head> >+<script> >+ function runTests() >+ { >+ if (window.layoutTestController) { >+ layoutTestController.dumpAsText(); >+ layoutTestController.setCanOpenWindows(); >+ layoutTestController.waitUntilDone(); >+ } >+ showModalDialog("resources/modal-dialog.html"); >+ } >+ >+ function log(message) >+ { >+ var console = document.getElementById("console"); >+ var li = document.createElement("li"); >+ var text = document.createTextNode(message); >+ >+ console.appendChild(li); >+ li.appendChild(text); >+ } >+</script> >+</head> >+ >+<body onload="runTests()"> >+ <p>This test verifies that showModalDialog implementation in DRT works. >+ <p>You need to disable pop-up blocker for this test to run successfully.</p> >+ <ul id="console"></ul> >+</body> >+</html> >Index: LayoutTests/ChangeLog >=================================================================== >--- LayoutTests/ChangeLog (revision 60374) >+++ LayoutTests/ChangeLog (working copy) >@@ -1,3 +1,81 @@ >+2010-05-28 Prasad Tammana <prasadt@chromium.org> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ DumpRenderTree should allow tests with modal dialogs >+ https://bugs.webkit.org/show_bug.cgi?id=35350 >+ >+ Added a new test show-modal-dialog.html to harness tests to verify that showModalDialog works. >+ >+ Added a new test, show-modal-dialog-onblur-onfocus.html, that takes advantage of the showModalDialog >+ functionality added to UIDelegate.mm. The test is only enabled on mac for now. This test will catch >+ regressions on the bug fix for https://bugs.webkit.org/show_bug.cgi?id=33962. >+ >+ Support for showModalDialog affected the expected output for many tests that operate under the assumption >+ that the method is undefined. Modified the tests accordingly, in some cases disabled showModalDialog (not >+ currently tested anyway. Opened a bug to add showModalDialog specific tests where appropriate - Bug# 39897. >+ >+ * fast/dom/Window/window-function-frame-getter-precedence-expected.txt: >+ * fast/dom/Window/window-function-frame-getter-precedence.html: >+ * fast/dom/Window/window-function-name-getter-precedence-expected.txt: >+ * fast/dom/Window/window-function-name-getter-precedence.html: >+ * fast/dom/Window/window-lookup-precedence-expected.txt: >+ * fast/dom/Window/window-lookup-precedence.html: >+ * fast/dom/Window/window-properties-expected.txt: >+ * fast/dom/Window/window-properties.html: >+ * fast/dom/script-tests/prototype-inheritance.js: >+ Tweak tests so that showModalDialog part gets exercised only if its defined to keep output consistent across platforms. >+ Where its not possible, skip the test for showModalDialog, which is not currently exercised anyway. >+ >+ * fast/events/resources/modal-dialog.html: Added. >+ * fast/events/show-modal-dialog-onblur-onfocus-expected.txt: Added. >+ * fast/events/show-modal-dialog-onblur-onfocus.html: Added. >+ * fast/harness/resources/modal-dialog.html: Added. >+ * fast/harness/show-modal-dialog-expected.txt: Added. >+ * fast/harness/show-modal-dialog.html: Added. >+ New tests that take advantage of showModalDialog in DRT. >+ >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T1-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T10-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T11-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T2-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T3-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T4-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T5-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T6-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T7-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T8-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.1_T9-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T1-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T10-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T11-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T2-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T3-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T4-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T5-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T6-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T7-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T8-expected.txt: >+ * fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code/S10.2.2_A1.2_T9-expected.txt: >+ Skip the above sputnik tests on all platforms except mac. They were all expected to fail anyway. So no coverage lost. >+ >+ * http/tests/security/cross-frame-access-call-expected.txt: >+ * http/tests/security/cross-frame-access-call.html: >+ * http/tests/security/cross-frame-access-get-expected.txt: >+ * http/tests/security/cross-frame-access-get.html: >+ * http/tests/security/cross-frame-access-put-expected.txt: >+ Skip showModalDialog to make test pass for all platforms. Added a FIXME with bug # to add a test specifically for showModalDialog. >+ >+ * http/tests/security/resources/cross-frame-iframe-for-put-test.html: >+ Tweak test to make output identical for all platforms even if they don't implement showModalDialog in DRT. >+ >+ * platform/chromium/test_expectations.txt: >+ * platform/gtk/Skipped: >+ * platform/qt/Skipped: >+ * platform/win/Skipped: >+ Skip failing tests. Note that there is no test functionality lost. These are either new tests or tests that were dysfunctional anyway >+ in the absence of showModalDialog in DRT. >+ > 2010-05-28 Chang Shu <Chang.Shu@nokia.com> > > Reviewed by Kenneth Rohde Christiansen. >Index: WebKitTools/DumpRenderTree/mac/UIDelegate.mm >=================================================================== >--- WebKitTools/DumpRenderTree/mac/UIDelegate.mm (revision 60368) >+++ WebKitTools/DumpRenderTree/mac/UIDelegate.mm (working copy) >@@ -67,6 +67,20 @@ > printf ("CONSOLE MESSAGE: line %d: %s\n", [lineNumber intValue], [message UTF8String]); > } > >+- (void)modalWindowWillClose:(NSNotification *)notification >+{ >+ [[NSNotificationCenter defaultCenter] removeObserver:self name:NSWindowWillCloseNotification object:nil]; >+ [NSApp abortModal]; >+} >+ >+- (void)webViewRunModal:(WebView *)sender >+{ >+ gLayoutTestController->setWindowIsKey(false); >+ [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(modalWindowWillClose:) name:NSWindowWillCloseNotification object:nil]; >+ [NSApp runModalForWindow:[sender window]]; >+ gLayoutTestController->setWindowIsKey(true); >+} >+ > - (void)webView:(WebView *)sender runJavaScriptAlertPanelWithMessage:(NSString *)message initiatedByFrame:(WebFrame *)frame > { > if (!done) >Index: WebKitTools/ChangeLog >=================================================================== >--- WebKitTools/ChangeLog (revision 60374) >+++ WebKitTools/ChangeLog (working copy) >@@ -1,3 +1,15 @@ >+2010-05-28 Prasad Tammana <prasadt@chromium.org> >+ >+ Reviewed by NOBODY (OOPS!). >+ >+ DumpRenderTree should allow tests with modal dialogs >+ https://bugs.webkit.org/show_bug.cgi?id=35350 >+ >+ * DumpRenderTree/mac/UIDelegate.mm: Add support for showModalDialog. >+ (-[UIDelegate modalWindowWillClose:]): Observer for NSWindowWillCloseNotifications to call >+ abortModal from when modal window closes. >+ (-[UIDelegate webViewRunModal:]): Delegate method for showModalDialog to run the modal loop. >+ > 2010-05-28 Chris Fleizach <cfleizach@apple.com> > > Reviewed by Beth Dakin.
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=57603">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Flags:
darin
:
review-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 35350
:
57183
|
57372
| 57603 |
58829
|
59319