Attachment 466598 Details for Bug 257738 – REVERT of 264503@main

[patch] REVERT of 264503@main

bug-257738-20230606022310.patch (text/plain), 1.97 KB, created by WebKit Commit Bot on 2023-06-05 19:23:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: WebKit Commit Bot

Created: 2023-06-05 19:23:11 PDT

Size: 1.97 KB

patch

obsolete

>From ec400ad739b37d13baf5380c6c20e4385fe3e06f Mon Sep 17 00:00:00 2001
>From: Commit Queue <commit-queue@webkit.org>
>Date: Tue, 6 Jun 2023 02:23:08 +0000
>Subject: [PATCH] Unreviewed, reverting 264503@main.
> https://bugs.webkit.org/show_bug.cgi?id=257738
>
>Caused page load time regression
>
>Reverted changeset:
>
>"RemoteScrollingCoordinator::scheduleTreeStateCommit() can result in extra rendering updates"
>https://bugs.webkit.org/show_bug.cgi?id=244276
>https://commits.webkit.org/264503@main
>---
> Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h       | 2 +-
> .../WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm       | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h b/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
>index e25ddced09b2..e51558d56df7 100644
>--- a/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
>+++ b/Source/WebCore/page/scrolling/AsyncScrollingCoordinator.h
>@@ -92,7 +92,7 @@ protected:
> 
>     WEBCORE_EXPORT void willCommitTree() override;
>     void synchronizeStateFromScrollingTree();
>-    WEBCORE_EXPORT void scheduleRenderingUpdate();
>+    void scheduleRenderingUpdate();
> 
>     bool eventTrackingRegionsDirty() const { return m_eventTrackingRegionsDirty; }
> 
>diff --git a/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm b/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm
>index 0eac89dce98f..4fb8279a0943 100644
>--- a/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm
>+++ b/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteScrollingCoordinator.mm
>@@ -66,7 +66,7 @@ RemoteScrollingCoordinator::~RemoteScrollingCoordinator()
> 
> void RemoteScrollingCoordinator::scheduleTreeStateCommit()
> {
>-    scheduleRenderingUpdate();
>+    m_webPage->drawingArea()->triggerRenderingUpdate();
> }
> 
> bool RemoteScrollingCoordinator::coordinatesScrollingForFrameView(const LocalFrameView& frameView) const

Actions: View | Formatted Diff | Diff

Attachments on bug 257738: 466598