Attachment 465438 Details for Bug 249368 – Suspicious, ugly patch

[patch] Suspicious, ugly patch

0004-missing-SpeechRecognition-vtable.patch (text/plain), 1.63 KB, created by Adrian Perez on 2023-03-14 14:45:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Perez

Created: 2023-03-14 14:45:07 PDT

Size: 1.63 KB

patch

obsolete

>diff --git a/Source/WebCore/Modules/speech/SpeechRecognition.cpp b/Source/WebCore/Modules/speech/SpeechRecognition.cpp
>index 5ddc6595b10b..798942b914bf 100644
>--- a/Source/WebCore/Modules/speech/SpeechRecognition.cpp
>+++ b/Source/WebCore/Modules/speech/SpeechRecognition.cpp
>@@ -206,4 +206,13 @@ void SpeechRecognition::didEnd()
>     queueTaskToDispatchEvent(*this, TaskSource::Speech, Event::create(eventNames().endEvent, Event::CanBubble::No, Event::IsCancelable::No));
> }
> 
>+SpeechRecognition::~SpeechRecognition()
>+{
>+}
>+
>+// XXX: Disgusting hack.
>+SpeechRecognitionConnectionClient::~SpeechRecognitionConnectionClient()
>+{
>+}
>+
> } // namespace WebCore
>diff --git a/Source/WebCore/Modules/speech/SpeechRecognition.h b/Source/WebCore/Modules/speech/SpeechRecognition.h
>index 1f482696d8d2..fb817fb71330 100644
>--- a/Source/WebCore/Modules/speech/SpeechRecognition.h
>+++ b/Source/WebCore/Modules/speech/SpeechRecognition.h
>@@ -64,6 +64,8 @@ public:
>     using RefCounted::ref;
>     using RefCounted::deref;
> 
>+    virtual ~SpeechRecognition();
>+
> private:
>     enum class State {
>         Inactive,
>diff --git a/Source/WebCore/Modules/speech/SpeechRecognitionConnectionClient.h b/Source/WebCore/Modules/speech/SpeechRecognitionConnectionClient.h
>index 1c33dfe2efc4..f63f986d5bb2 100644
>--- a/Source/WebCore/Modules/speech/SpeechRecognitionConnectionClient.h
>+++ b/Source/WebCore/Modules/speech/SpeechRecognitionConnectionClient.h
>@@ -40,7 +40,7 @@ public:
>     {
>     }
> 
>-    virtual ~SpeechRecognitionConnectionClient() = default;
>+    virtual ~SpeechRecognitionConnectionClient();
> 
>     virtual void didStart() = 0;
>     virtual void didStartCapturingAudio() = 0;

Actions: View | Formatted Diff | Diff

Attachments on bug 249368: 465438