Attachment 465257 Details for Bug 253085 – Locking patch

[patch] Locking patch

gst-gbm_bo-lock.patch (text/plain), 1.37 KB, created by Zan Dobersek on 2023-03-02 01:40:40 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Zan Dobersek

Created: 2023-03-02 01:40:40 PST

Size: 1.37 KB

patch

obsolete

>diff --git a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>index 355836b81416..a615149c8e10 100644
>--- a/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>+++ b/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
>@@ -3300,6 +3300,12 @@ void MediaPlayerPrivateGStreamer::pushDMABufToCompositor()
> 
>     // Destination helper struct, maps the gbm_bo object into CPU-memory space and copies from the accompanying Source in fill().
>     struct Destination {
>+        static Lock& mappingLock()
>+        {
>+            static Lock s_mappingLock;
>+            return s_mappingLock;
>+        }
>+
>         Destination(struct gbm_bo* bo, uint32_t width, uint32_t height)
>             : bo(bo)
>         {
>@@ -3347,9 +3353,10 @@ void MediaPlayerPrivateGStreamer::pushDMABufToCompositor()
>         if (gst_buffer_find_memory(buffer, offset, 1, &memid, &length, &skip)) {
>             auto* mem = gst_buffer_peek_memory(buffer, memid);
> 
>+            Locker locker { Destination::mappingLock() };
>+
>             Source source(mem, offset, stride, planeData.height);
>             Destination destination(planeData.bo, planeData.width, planeData.height);
>-
>             if (source.valid && destination.valid)
>                 destination.fill(source);
>         }

Actions: View | Formatted Diff | Diff

Attachments on bug 253085: 465257 | 465260