WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
[patch]
Patch
bug-238356-20220406132900.patch (text/plain), 24.44 KB, created by
Oriol Brufau
on 2022-04-06 04:29:01 PDT
(
hide
)
Description:
Patch
Filename:
MIME Type:
Creator:
Oriol Brufau
Created:
2022-04-06 04:29:01 PDT
Size:
24.44 KB
patch
obsolete
>Subversion Revision: 291745 >diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog >index 72991fa93b741da076e9811fa61011dd637b5f20..e3181952feb479c49b435b6735272794117ad60b 100644 >--- a/Source/WebCore/ChangeLog >+++ b/Source/WebCore/ChangeLog >@@ -1,3 +1,68 @@ >+2022-04-06 Oriol Brufau <obrufau@igalia.com> >+ >+ [css] Turn -webkit-text-orientation into a legacy shorthand >+ https://bugs.webkit.org/show_bug.cgi?id=238356 >+ >+ Reviewed by Antti Koivisto. >+ >+ `-webkit-text-orientation` and `text-orientation` were both implemented >+ as longhands, just with a `related-property` flag so that declaration >+ blocks with both of them would use the one appearing last. >+ >+ However, the logic for `related-property` wasn't always working well. >+ In bug 238350 I plan to merge it with shouldApplyPropertyInParseOrder(), >+ which has the same purpose and works better. But it's not suitable for >+ high priority properties like `text-orientation`. >+ >+ So this patch turns `-webkit-text-orientation` into a shorthand that >+ expands into `text-orientation`. >+ >+ `-webkit-text-orientation` continues accepting the legacy value >+ `sideways-right`, which is now mapped into `sideways` at parse time. >+ Previously this happened at computed-value time, but it implied that >+ serializing `text-decoration` could yield an invalid value. >+ >+ Tests: fast/text/text-orientation-parse-competition.html >+ fast/text/text-orientation-parse-stylesheet.html >+ >+ * css/CSSPrimitiveValueMappings.h: >+ (WebCore::CSSPrimitiveValue::operator TextOrientation const): >+ Remove mapping of `sideways-right` into `sideways`, this is now >+ done at parse time. Also remove mapping of `vertical-right` into `mixed` >+ since `vertical-right` is a remnant of the past which has not been >+ considered valid syntax for years. >+ >+ * css/CSSProperties.json: >+ Turn `-webkit-text-orientation` into a shorthand of `text-orientation`. >+ Remove their `related-property` flags and a remnant of `vertical-right`. >+ >+ * css/StyleProperties.cpp: >+ (WebCore::StyleProperties::getPropertyValue const): >+ Add code for serializing the `-webkit-text-orientation` shorthand. >+ >+ * css/makeprop.pl: >+ Avoid a compile warning in getRelatedPropertyId() when no property has >+ the `related-property` flag. >+ >+ * css/parser/CSSParserFastPaths.cpp: >+ (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): >+ (WebCore::CSSParserFastPaths::isKeywordPropertyID): >+ Remove `-webkit-text-orientation` from code which is only relevant for >+ longhands. >+ >+ * css/parser/CSSPropertyParser.cpp: >+ (WebCore::CSSPropertyParser::consumeLegacyTextOrientation): >+ (WebCore::CSSPropertyParser::parseShorthand): >+ Add parsing logic for `-webkit-text-orientation` as a shorthand. >+ >+ * css/parser/CSSPropertyParser.h: >+ Add parsing logic for `-webkit-text-orientation` as a shorthand. >+ >+ * style/StyleBuilderCustom.h: >+ (WebCore::Style::BuilderCustom::applyValueWebkitTextOrientation): Deleted. >+ Remove `-webkit-text-orientation` from code which is only relevant for >+ longhands. >+ > 2022-03-23 Youenn Fablet <youenn@apple.com> > > VideoFrame does not need to inherit from MediaSample >diff --git a/Source/WebCore/css/CSSPrimitiveValueMappings.h b/Source/WebCore/css/CSSPrimitiveValueMappings.h >index 5073ecab4b9847f8b6eb0ca3847af47054e3a36f..e8578d006223857cf49da762e6195380bf48e115 100644 >--- a/Source/WebCore/css/CSSPrimitiveValueMappings.h >+++ b/Source/WebCore/css/CSSPrimitiveValueMappings.h >@@ -3304,10 +3304,6 @@ template<> inline CSSPrimitiveValue::operator TextOrientation() const > switch (m_value.valueID) { > case CSSValueSideways: > return TextOrientation::Sideways; >- case CSSValueSidewaysRight: >- return TextOrientation::Sideways; >- case CSSValueVerticalRight: >- return TextOrientation::Mixed; > case CSSValueMixed: > return TextOrientation::Mixed; > case CSSValueUpright: >diff --git a/Source/WebCore/css/CSSProperties.json b/Source/WebCore/css/CSSProperties.json >index 7969e2be118d9e5468f636399a1295f0163c67bf..321cd291e65f289f6db21ea8ad59b7ac2f6cfd0e 100644 >--- a/Source/WebCore/css/CSSProperties.json >+++ b/Source/WebCore/css/CSSProperties.json >@@ -142,8 +142,7 @@ > "in CSS cascading order.", > "", > "* related-property:", >- "Indicates the prefixed or unprefixed version of the same property,", >- "e.g. -webkit-text-orientation has a related property text-orientation", >+ "Indicates the prefixed or unprefixed version of the same property.", > "When parsing high priority CSS properties with both prefixed and unprefixed", > "versions, this flig will help the parser to mark all related properties ", > "as seen when one is seen. This could enforce the 'last-one-wins' rule.", >@@ -690,7 +689,6 @@ > ], > "codegen-properties": { > "custom": "Value", >- "related-property": "-webkit-text-orientation", > "high-priority": true > }, > "specification": { >@@ -706,10 +704,6 @@ > "value": "sideways-right", > "status": "deprecated" > }, >- { >- "value": "vertical-right", >- "status": "non-standard" >- }, > "mixed", > "upright" > ], >@@ -717,9 +711,9 @@ > "aliases": [ > "-epub-text-orientation" > ], >- "related-property": "text-orientation", >- "custom": "Value", >- "high-priority": true >+ "longhands": [ >+ "text-orientation" >+ ] > }, > "specification": { > "category": "css-writing-modes", >diff --git a/Source/WebCore/css/StyleProperties.cpp b/Source/WebCore/css/StyleProperties.cpp >index f0413c17fffa283811fe2517fdfd61bcdcf8b259..992ff1e70e9eb83fe2bb8b049c0fc153a08444fe 100644 >--- a/Source/WebCore/css/StyleProperties.cpp >+++ b/Source/WebCore/css/StyleProperties.cpp >@@ -349,6 +349,8 @@ String StyleProperties::getPropertyValue(CSSPropertyID propertyID) const > return get2Values(scrollPaddingBlockShorthand()); > case CSSPropertyScrollPaddingInline: > return get2Values(scrollPaddingInlineShorthand()); >+ case CSSPropertyWebkitTextOrientation: >+ return getPropertyValue(CSSPropertyTextOrientation); > default: > return String(); > } >diff --git a/Source/WebCore/css/makeprop.pl b/Source/WebCore/css/makeprop.pl >index 08fe09f4db14fb3ad78b9d78e3dfe2aa2a2994ac..930b73895541784bc2acc3e606626e88606ef586 100755 >--- a/Source/WebCore/css/makeprop.pl >+++ b/Source/WebCore/css/makeprop.pl >@@ -587,23 +587,36 @@ bool CSSProperty::isInheritedProperty(CSSPropertyID id) > ASSERT(id != CSSPropertyInvalid); > return isInheritedPropertyTable[id]; > } >- >-CSSPropertyID getRelatedPropertyId(CSSPropertyID id) >+ >+EOF >+ >+if (%relatedProperty) { >+ print GPERF << "EOF"; >+CSSPropertyID getRelatedPropertyId(const CSSPropertyID id) > { > switch (id) { > EOF >-for my $name (@names) { >- if (!$relatedProperty{$name}) { >- next; >+ for my $name (@names) { >+ if (!$relatedProperty{$name}) { >+ next; >+ } >+ print GPERF " case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n"; >+ print GPERF " return CSSPropertyID::CSSProperty" . $nameToId{$relatedProperty{$name}} . ";\n"; > } >- print GPERF " case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n"; >- print GPERF " return CSSPropertyID::CSSProperty" . $nameToId{$relatedProperty{$name}} . ";\n"; >-} >- >-print GPERF << "EOF"; >+ print GPERF << "EOF"; > default: > return CSSPropertyID::CSSPropertyInvalid; > } >+EOF >+} else { >+ print GPERF << "EOF"; >+CSSPropertyID getRelatedPropertyId(const CSSPropertyID) >+{ >+ return CSSPropertyID::CSSPropertyInvalid; >+EOF >+} >+ >+print GPERF << "EOF"; > } > > Vector<String> CSSProperty::aliasesForProperty(CSSPropertyID id) >diff --git a/Source/WebCore/css/parser/CSSParserFastPaths.cpp b/Source/WebCore/css/parser/CSSParserFastPaths.cpp >index aa3c2871c1df784ceb97797d4da026abb37cc668..386d81c6e06c0568f08bc62332bcc5b9fe64f339 100644 >--- a/Source/WebCore/css/parser/CSSParserFastPaths.cpp >+++ b/Source/WebCore/css/parser/CSSParserFastPaths.cpp >@@ -735,9 +735,8 @@ bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID propertyId > // auto | none | inter-word | distribute > return valueID == CSSValueInterWord || valueID == CSSValueDistribute || valueID == CSSValueAuto || valueID == CSSValueNone; > #endif >- case CSSPropertyWebkitTextOrientation: // mixed | upright | sideways | sideways-right >- return valueID == CSSValueMixed || valueID == CSSValueUpright || valueID == CSSValueSideways || valueID == CSSValueSidewaysRight; > case CSSPropertyTextOrientation: >+ // mixed | upright | sideways > return valueID == CSSValueMixed || valueID == CSSValueUpright || valueID == CSSValueSideways; > case CSSPropertyTextOverflow: // clip | ellipsis > return valueID == CSSValueClip || valueID == CSSValueEllipsis; >@@ -989,7 +988,6 @@ bool CSSParserFastPaths::isKeywordPropertyID(CSSPropertyID propertyId) > case CSSPropertyWebkitTextCombine: > case CSSPropertyTextCombineUpright: > case CSSPropertyTextDecorationStyle: >- case CSSPropertyWebkitTextOrientation: > case CSSPropertyWebkitTextSecurity: > case CSSPropertyWebkitTextZoom: > case CSSPropertyWebkitTransformStyle: >diff --git a/Source/WebCore/css/parser/CSSPropertyParser.cpp b/Source/WebCore/css/parser/CSSPropertyParser.cpp >index c5f344165f46162ff8ed1103a80b88ae1906237f..99831a6fcbd5b895535b0756ab8a251172a99171 100644 >--- a/Source/WebCore/css/parser/CSSPropertyParser.cpp >+++ b/Source/WebCore/css/parser/CSSPropertyParser.cpp >@@ -5642,6 +5642,23 @@ bool CSSPropertyParser::consumeLegacyBreakProperty(CSSPropertyID property, bool > return true; > } > >+bool CSSPropertyParser::consumeLegacyTextOrientation(bool important) >+{ >+ // -webkit-text-orientation is a legacy shorthand for text-orientation. >+ // The only difference is that it accepts 'sideways-right', which is mapped into 'sideways'. >+ RefPtr<CSSPrimitiveValue> keyword; >+ auto valueID = m_range.peek().id(); >+ if (valueID == CSSValueSidewaysRight) { >+ keyword = CSSValuePool::singleton().createIdentifierValue(CSSValueSideways); >+ consumeIdentRaw(m_range); >+ } else if (CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyTextOrientation, valueID, m_context)) >+ keyword = consumeIdent(m_range); >+ if (!keyword || !m_range.atEnd()) >+ return false; >+ addProperty(CSSPropertyTextOrientation, CSSPropertyWebkitTextOrientation, keyword.releaseNonNull(), important); >+ return true; >+} >+ > static bool consumeBackgroundPosition(CSSParserTokenRange& range, const CSSParserContext& context, CSSPropertyID property, RefPtr<CSSValue>& resultX, RefPtr<CSSValue>& resultY) > { > do { >@@ -6450,6 +6467,8 @@ bool CSSPropertyParser::parseShorthand(CSSPropertyID property, bool important) > case CSSPropertyWebkitColumnBreakBefore: > case CSSPropertyWebkitColumnBreakInside: > return consumeLegacyBreakProperty(property, important); >+ case CSSPropertyWebkitTextOrientation: >+ return consumeLegacyTextOrientation(important); > case CSSPropertyMaskPosition: > case CSSPropertyWebkitMaskPosition: > case CSSPropertyBackgroundPosition: { >diff --git a/Source/WebCore/css/parser/CSSPropertyParser.h b/Source/WebCore/css/parser/CSSPropertyParser.h >index 043f2111dd854fb68883d6f924143b548b25f68f..ee6c487eabdc65fc8444c39d972c71dbc9797723 100644 >--- a/Source/WebCore/css/parser/CSSPropertyParser.h >+++ b/Source/WebCore/css/parser/CSSPropertyParser.h >@@ -117,6 +117,7 @@ private: > bool consumeFlex(bool important); > > bool consumeLegacyBreakProperty(CSSPropertyID, bool important); >+ bool consumeLegacyTextOrientation(bool important); > > bool consumeTransformOrigin(bool important); > bool consumePerspectiveOrigin(bool important); >diff --git a/Source/WebCore/style/StyleBuilderCustom.h b/Source/WebCore/style/StyleBuilderCustom.h >index e7aaddd04bd21cb66073b31f291adb77b82c0125..639e0aaedc624d7cec9f66b9f5e9f88ee2b2141a 100644 >--- a/Source/WebCore/style/StyleBuilderCustom.h >+++ b/Source/WebCore/style/StyleBuilderCustom.h >@@ -148,7 +148,6 @@ public: > static void applyInitialTextAlign(BuilderState&); > static void applyValueTextAlign(BuilderState&, CSSValue&); > static void applyValueWebkitLocale(BuilderState&, CSSValue&); >- static void applyValueWebkitTextOrientation(BuilderState&, CSSValue&); > static void applyValueTextOrientation(BuilderState&, CSSValue&); > #if ENABLE(TEXT_AUTOSIZING) > static void applyValueWebkitTextSizeAdjust(BuilderState&, CSSValue&); >@@ -890,11 +889,6 @@ inline void BuilderCustom::applyValueWritingMode(BuilderState& builderState, CSS > builderState.style().setHasExplicitlySetWritingMode(true); > } > >-inline void BuilderCustom::applyValueWebkitTextOrientation(BuilderState& builderState, CSSValue& value) >-{ >- builderState.setTextOrientation(downcast<CSSPrimitiveValue>(value)); >-} >- > inline void BuilderCustom::applyValueTextOrientation(BuilderState& builderState, CSSValue& value) > { > builderState.setTextOrientation(downcast<CSSPrimitiveValue>(value)); >diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog >index a4877d69443198ca804ed91ff395a1694f2a2636..21637ae9e03b9fd5b1335d431e7e4c0c97255e53 100644 >--- a/LayoutTests/ChangeLog >+++ b/LayoutTests/ChangeLog >@@ -1,3 +1,20 @@ >+2022-04-06 Oriol Brufau <obrufau@igalia.com> >+ >+ [css] Turn -webkit-text-orientation into a legacy shorthand >+ https://bugs.webkit.org/show_bug.cgi?id=238356 >+ >+ Reviewed by Antti Koivisto. >+ >+ * fast/text/text-orientation-parse-competition-expected.txt: >+ * fast/text/text-orientation-parse-competition.html: >+ Check that if a stylesheet specifies both -webkit-text-orientation and >+ text-orientation for the same element, the last specified one wins. >+ >+ * fast/text/text-orientation-parse-stylesheet-expected.txt: >+ * fast/text/text-orientation-parse-stylesheet.html: >+ Check that only -webkit-text-orientation accepts `sideways-right`, and >+ that it's mapped to `sideways` at parse time. >+ > 2022-03-23 Ziran Sun <zsun@igalia.com> > > [InputElement] Add HTMLInputElement::showPicker() method >diff --git a/LayoutTests/fast/text/text-orientation-parse-competition-expected.txt b/LayoutTests/fast/text/text-orientation-parse-competition-expected.txt >index 6a6ab1d542f66bab77df92122ae4905b37643965..6ae0d66fd0e00b987517532d5f07c260223dc636 100644 >--- a/LayoutTests/fast/text/text-orientation-parse-competition-expected.txt >+++ b/LayoutTests/fast/text/text-orientation-parse-competition-expected.txt >@@ -1,9 +1,21 @@ > PASS window.getComputedStyle(document.getElementById('test1')).webkitTextOrientation is "upright" > PASS window.getComputedStyle(document.getElementById('test2')).webkitTextOrientation is "upright" >+PASS window.getComputedStyle(document.getElementById('test3')).webkitTextOrientation is "upright" >+PASS window.getComputedStyle(document.getElementById('test4')).webkitTextOrientation is "upright" >+PASS window.getComputedStyle(document.getElementById('test5')).webkitTextOrientation is "upright" >+PASS window.getComputedStyle(document.getElementById('test6')).webkitTextOrientation is "upright" > PASS window.getComputedStyle(document.getElementById('test1')).textOrientation is "upright" > PASS window.getComputedStyle(document.getElementById('test2')).textOrientation is "upright" >+PASS window.getComputedStyle(document.getElementById('test3')).textOrientation is "upright" >+PASS window.getComputedStyle(document.getElementById('test4')).textOrientation is "upright" >+PASS window.getComputedStyle(document.getElementById('test5')).textOrientation is "upright" >+PASS window.getComputedStyle(document.getElementById('test6')).textOrientation is "upright" > PASS successfullyParsed is true > > TEST COMPLETE > ä½ å¥½ABC > ä½ å¥½ABC >+ä½ å¥½ABC >+ä½ å¥½ABC >+ä½ å¥½ABC >+ä½ å¥½ABC >diff --git a/LayoutTests/fast/text/text-orientation-parse-competition.html b/LayoutTests/fast/text/text-orientation-parse-competition.html >index 1080b723204b6b9466145d39be337c085be72bc1..971c1b13300b931bdb99ffc4b6adba8f78dc9909 100644 >--- a/LayoutTests/fast/text/text-orientation-parse-competition.html >+++ b/LayoutTests/fast/text/text-orientation-parse-competition.html >@@ -2,16 +2,39 @@ > <html> > <head> > <meta charset="utf-8"> >+ <style> >+ #test3 { -webkit-text-orientation: sideways; text-orientation: upright; } >+ >+ #test4 { text-orientation: sideways; -webkit-text-orientation: upright; } >+ >+ #test5 { -webkit-text-orientation: sideways; } >+ #test5 { text-orientation: upright; } >+ >+ #test6 { text-orientation: sideways; } >+ #test6 { -webkit-text-orientation: upright; } >+ </style> > <script src="../../resources/js-test-pre.js"></script> > </head> > <body> > <div id="test1" style="-webkit-writing-mode: vertical-rl; -webkit-text-orientation: sideways; text-orientation: upright">ä½ å¥½ABC</div> > <div id="test2" style="-webkit-writing-mode: vertical-rl; text-orientation: sideways; -webkit-text-orientation: upright">ä½ å¥½ABC</div> >+ <div id="test3" style="-webkit-writing-mode: vertical-rl">ä½ å¥½ABC</div> >+ <div id="test4" style="-webkit-writing-mode: vertical-rl">ä½ å¥½ABC</div> >+ <div id="test5" style="-webkit-writing-mode: vertical-rl">ä½ å¥½ABC</div> >+ <div id="test6" style="-webkit-writing-mode: vertical-rl">ä½ å¥½ABC</div> > <script> > shouldBeEqualToString("window.getComputedStyle(document.getElementById('test1')).webkitTextOrientation", "upright"); > shouldBeEqualToString("window.getComputedStyle(document.getElementById('test2')).webkitTextOrientation", "upright"); >+ shouldBeEqualToString("window.getComputedStyle(document.getElementById('test3')).webkitTextOrientation", "upright"); >+ shouldBeEqualToString("window.getComputedStyle(document.getElementById('test4')).webkitTextOrientation", "upright"); >+ shouldBeEqualToString("window.getComputedStyle(document.getElementById('test5')).webkitTextOrientation", "upright"); >+ shouldBeEqualToString("window.getComputedStyle(document.getElementById('test6')).webkitTextOrientation", "upright"); > shouldBeEqualToString("window.getComputedStyle(document.getElementById('test1')).textOrientation", "upright"); > shouldBeEqualToString("window.getComputedStyle(document.getElementById('test2')).textOrientation", "upright"); >+ shouldBeEqualToString("window.getComputedStyle(document.getElementById('test3')).textOrientation", "upright"); >+ shouldBeEqualToString("window.getComputedStyle(document.getElementById('test4')).textOrientation", "upright"); >+ shouldBeEqualToString("window.getComputedStyle(document.getElementById('test5')).textOrientation", "upright"); >+ shouldBeEqualToString("window.getComputedStyle(document.getElementById('test6')).textOrientation", "upright"); > </script> > <script src="../../resources/js-test-post.js"></script> > </body> >diff --git a/LayoutTests/fast/text/text-orientation-parse-stylesheet-expected.txt b/LayoutTests/fast/text/text-orientation-parse-stylesheet-expected.txt >index a5252410f68b31cb447b52e2033bcc5c624c55ec..6fcbd5dadc6ce5fa45088fdc8516100d6b627e1d 100644 >--- a/LayoutTests/fast/text/text-orientation-parse-stylesheet-expected.txt >+++ b/LayoutTests/fast/text/text-orientation-parse-stylesheet-expected.txt >@@ -3,13 +3,17 @@ PASS document.getElementById('test2').sheet.cssRules[0].style.getPropertyValue(' > PASS document.getElementById('test3').sheet.cssRules[0].style.getPropertyValue('text-orientation') is "upright" > PASS document.getElementById('test4').sheet.cssRules[0].style.getPropertyValue('text-orientation') is "mixed" > PASS document.getElementById('test5').sheet.cssRules[0].style.getPropertyValue('text-orientation') is "mixed" >+PASS document.getElementById('test6').sheet.cssRules[0].style.getPropertyValue('text-orientation') is "sideways" >+PASS document.getElementById('test7').sheet.cssRules[0].style.getPropertyValue('text-orientation') is "sideways" >+PASS document.getElementById('test8').sheet.cssRules[0].style.getPropertyValue('text-orientation') is "" > PASS document.getElementById('test1').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation') is "upright" > PASS document.getElementById('test2').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation') is "upright" > PASS document.getElementById('test3').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation') is "upright" > PASS document.getElementById('test4').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation') is "mixed" > PASS document.getElementById('test5').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation') is "mixed" > PASS document.getElementById('test6').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation') is "sideways" >-PASS document.getElementById('test6').sheet.cssRules[0].style.getPropertyValue('text-orientation') is "sideways" >+PASS document.getElementById('test7').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation') is "sideways" >+PASS document.getElementById('test8').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation') is "" > PASS successfullyParsed is true > > TEST COMPLETE >diff --git a/LayoutTests/fast/text/text-orientation-parse-stylesheet.html b/LayoutTests/fast/text/text-orientation-parse-stylesheet.html >index 5c52423a80c5fab86a901bede4ce8ff899ef9545..384d7290b3e03462c0a772d556311a6e48d53445 100644 >--- a/LayoutTests/fast/text/text-orientation-parse-stylesheet.html >+++ b/LayoutTests/fast/text/text-orientation-parse-stylesheet.html >@@ -11,6 +11,9 @@ > <style id="test4"> dummy { text-orientation: upright; -webkit-text-orientation: mixed;} </style> > <style id="test5"> dummy { -webkit-text-orientation: upright; text-orientation: mixed;} </style> > <style id="test6"> dummy { -webkit-text-orientation: upright; text-orientation: mixed; -webkit-text-orientation: sideways;} </style> >+ <style id="test7"> dummy { -webkit-text-orientation: sideways-right;} </style> >+ <style id="test8"> dummy { text-orientation: sideways-right;} </style> >+ > > <script> > shouldBeEqualToString("document.getElementById('test1').sheet.cssRules[0].style.getPropertyValue('text-orientation')", "upright"); >@@ -18,17 +21,18 @@ > shouldBeEqualToString("document.getElementById('test3').sheet.cssRules[0].style.getPropertyValue('text-orientation')", "upright"); > shouldBeEqualToString("document.getElementById('test4').sheet.cssRules[0].style.getPropertyValue('text-orientation')", "mixed"); > shouldBeEqualToString("document.getElementById('test5').sheet.cssRules[0].style.getPropertyValue('text-orientation')", "mixed"); >+ shouldBeEqualToString("document.getElementById('test6').sheet.cssRules[0].style.getPropertyValue('text-orientation')", "sideways"); >+ shouldBeEqualToString("document.getElementById('test7').sheet.cssRules[0].style.getPropertyValue('text-orientation')", "sideways"); >+ shouldBeEqualToString("document.getElementById('test8').sheet.cssRules[0].style.getPropertyValue('text-orientation')", ""); > > shouldBeEqualToString("document.getElementById('test1').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation')", "upright"); > shouldBeEqualToString("document.getElementById('test2').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation')", "upright"); > shouldBeEqualToString("document.getElementById('test3').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation')", "upright"); > shouldBeEqualToString("document.getElementById('test4').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation')", "mixed"); > shouldBeEqualToString("document.getElementById('test5').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation')", "mixed"); >- > shouldBeEqualToString("document.getElementById('test6').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation')", "sideways"); >- shouldBeEqualToString("document.getElementById('test6').sheet.cssRules[0].style.getPropertyValue('text-orientation')", "sideways"); >- >- >+ shouldBeEqualToString("document.getElementById('test7').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation')", "sideways"); >+ shouldBeEqualToString("document.getElementById('test8').sheet.cssRules[0].style.getPropertyValue('-webkit-text-orientation')", ""); > </script> > > <script src="../../resources/js-test-post.js"></script>
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=456807">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Flags:
ews-feeder
:
commit-queue-
Actions:
View
|
Formatted Diff
|
Diff
Attachments on
bug 238356
:
455703
|
455718
|
455750
|
455751
|
455754
| 456807