Attachment 456564 Details for Bug 238734 – Patch

[patch] Patch

bug-238734-20220404161510.patch (text/plain), 6.82 KB, created by Adrian Perez on 2022-04-04 06:15:11 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Adrian Perez

Created: 2022-04-04 06:15:11 PDT

Size: 6.82 KB

patch

obsolete

>Subversion Revision: 292287
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index d417b1e2295571c547ef5caa59f5006065eb80c4..9f72a3d4f0348568aeab097f307f4577270bc6d2 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,16 @@
>+2022-04-04  Adrian Perez de Castro  <aperez@igalia.com>
>+
>+        [WPE] Mark "backend" parameters of web view constructors not nullable
>+        https://bugs.webkit.org/show_bug.cgi?id=238734
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests needed.
>+
>+        * UIProcess/API/wpe/WebKitWebViewWPE.cpp: Annotate web view constructors with (not nullable)
>+        and while at it, fix documentation links, and improve the wording to better follow gi-docgen
>+        copywriting style. Remove the mentions to the single process model, which is deprecated anyway.
>+
> 2022-04-04  Kimmo Kinnunen  <kkinnunen@apple.com>
> 
>         StreamClientConnection should have waitForAndDispatchImmediately
>diff --git a/Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp b/Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp
>index e1c27813fa8af499a4f95ecfad317e546ee1f500..8b6cdd320e68128f88f1ec6587bc836e74fc8b01 100644
>--- a/Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp
>+++ b/Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp
>@@ -62,15 +62,18 @@ void webkitWebViewRestoreWindow(WebKitWebView*, CompletionHandler<void()>&& comp
> 
> /**
>  * webkit_web_view_new:
>- * @backend: (transfer full): a #WebKitWebViewBackend
>+ * @backend: (transfer full) (not nullable): the WPE view backend to use.
>  *
>- * Creates a new #WebKitWebView with the default #WebKitWebContext and
>- * no #WebKitUserContentManager associated with it.
>- * See also webkit_web_view_new_with_context(),
>- * webkit_web_view_new_with_user_content_manager(), and
>- * webkit_web_view_new_with_settings().
>+ * Creates a new web view with a default configuration.
>  *
>- * Returns: The newly created #WebKitWebView
>+ * The new view will use the the default [class@WebKitWebContext] and
>+ * will not have an associated [class@WebKitUserContentManager].
>+ *
>+ * See also [id@webkit_web_view_new_with_context],
>+ * [id@webkit_web_view_new_with_user_content_manager]), and
>+ * [id@webkit_web_view_new_with_settings].
>+ *
>+ * Returns: The newly created web view.
>  */
> WebKitWebView* webkit_web_view_new(WebKitWebViewBackend* backend)
> {
>@@ -84,15 +87,18 @@ WebKitWebView* webkit_web_view_new(WebKitWebViewBackend* backend)
> 
> /**
>  * webkit_web_view_new_with_context:
>- * @backend: (transfer full): a #WebKitWebViewBackend
>- * @context: the #WebKitWebContext to be used by the #WebKitWebView
>+ * @backend: (transfer full) (not nullable): the WPE view backend to use.
>+ * @context: the web context the view will use.
>  *
>- * Creates a new #WebKitWebView with the given #WebKitWebContext and
>- * no #WebKitUserContentManager associated with it.
>- * See also webkit_web_view_new_with_user_content_manager() and
>- * webkit_web_view_new_with_settings().
>+ * Creates a new web view with a web context.
>  *
>- * Returns: The newly created #WebKitWebView
>+ * The new web view will use the given [class@WebKitWebContext] and will
>+ * not have an associated [class@WebKitUserContentManager].
>+ *
>+ * See also [id@webkit_web_view_new_with_user_content_manager] and
>+ * [id@webkit_web_view_new_with_settings].
>+ *
>+ * Returns: The newly created web view.
>  */
> WebKitWebView* webkit_web_view_new_with_context(WebKitWebViewBackend* backend, WebKitWebContext* context)
> {
>@@ -108,21 +114,18 @@ WebKitWebView* webkit_web_view_new_with_context(WebKitWebViewBackend* backend, W
> 
> /**
>  * webkit_web_view_new_with_related_view: (constructor)
>- * @backend: (transfer full): a #WebKitWebViewBackend
>- * @web_view: the related #WebKitWebView
>+ * @backend: (transfer full) (not nullable): the WPE view backend to use.
>+ * @web_view: the related web view.
>  *
>- * Creates a new #WebKitWebView sharing the same web process with @web_view.
>- * This method doesn't have any effect when %WEBKIT_PROCESS_MODEL_SHARED_SECONDARY_PROCESS
>- * process model is used, because a single web process is shared for all the web views in the
>- * same #WebKitWebContext. When using %WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES process model,
>- * this method should always be used when creating the #WebKitWebView in the #WebKitWebView::create signal.
>- * You can also use this method to implement other process models based on %WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES,
>- * like for example, sharing the same web process for all the views in the same security domain.
>+ * Creates a new web view sharing the same configuration and web process as another.
>  *
>- * The newly created #WebKitWebView will also have the same #WebKitUserContentManager
>- * and #WebKitSettings as @web_view.
>+ * A related view should always be set when creating a new web view in a handler
>+ * for the [signal@WebKitWebView::create] signal.
>  *
>- * Returns: (transfer full): The newly created #WebKitWebView
>+ * The newly created web view will also have the same [class@WebKitUserContentManager]
>+ * and [class@WebKitSettings] as the related @web_view.
>+ *
>+ * Returns: (transfer full): The newly created web view.
>  *
>  * Since: 2.4
>  */
>@@ -141,14 +144,15 @@ WebKitWebView* webkit_web_view_new_with_related_view(WebKitWebViewBackend* backe
> 
> /**
>  * webkit_web_view_new_with_settings:
>- * @backend: (nullable) (transfer full): a #WebKitWebViewBackend, or %NULL to use the default
>- * @settings: a #WebKitSettings
>+ * @backend: (transfer full) (not nullable): the WPE view backend to use.
>+ * @settings: settings for the new view.
>  *
>- * Creates a new #WebKitWebView with the given #WebKitSettings.
>- * See also webkit_web_view_new_with_context(), and
>- * webkit_web_view_new_with_user_content_manager().
>+ * Creates a new web view with the given settings.
>  *
>- * Returns: The newly created #WebKitWebView
>+ * See also [id@webkit_web_view_new_with_context], and
>+ * [id@webkit_web_view_new_with_user_content_manager].
>+ *
>+ * Returns: (transfer full): The newly created web view.
>  *
>  * Since: 2.6
>  */
>@@ -165,14 +169,14 @@ WebKitWebView* webkit_web_view_new_with_settings(WebKitWebViewBackend* backend,
> 
> /**
>  * webkit_web_view_new_with_user_content_manager:
>- * @backend: (transfer full): a #WebKitWebViewBackend
>- * @user_content_manager: a #WebKitUserContentManager.
>+ * @backend: (transfer full) (not nullable): the WPE view backend to use.
>+ * @user_content_manager: the user content manager for the new view.
>  *
>- * Creates a new #WebKitWebView with the given #WebKitUserContentManager.
>- * The content loaded in the view may be affected by the content injected
>- * in the view by the user content manager.
>+ * Creates a new web view with the given user content manager.
>  *
>- * Returns: The newly created #WebKitWebView
>+ * The content loaded in the view may be affected by the user content manager.
>+ *
>+ * Returns: (transfer full): The newly created web view.
>  *
>  * Since: 2.6
>  */

Actions: View | Formatted Diff | Diff

Attachments on bug 238734: 456564 | 456565 | 456622