Attachment 455098 Details for Bug 238078 – Patch

[patch] Patch

bug-238078-20220318180603.patch (text/plain), 9.91 KB, created by Antti Koivisto on 2022-03-18 09:06:04 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antti Koivisto

Created: 2022-03-18 09:06:04 PDT

Size: 9.91 KB

patch

obsolete

>Subversion Revision: 291474
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 8835671e9d3cb9289287dc4a446bce0b305ec4e9..a7017e2ea7a42034b8f0868896cc82d90c20d8b0 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2022-03-18  Antti Koivisto  <antti@apple.com>
>+
>+        [CSS Container Queries] Add Typed OM support for container units
>+        https://bugs.webkit.org/show_bug.cgi?id=238078
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        For completeness, Typed OM is not enabled or fully implemented yet.
>+
>+        * css/DOMCSSNamespace+CSSNumericFactory.idl:
>+        * css/typedom/CSSNumericFactory.h:
>+        * css/typedom/CSSStyleValueFactory.cpp:
>+        (WebCore::CSSStyleValueFactory::reifyValue):
>+
> 2022-03-18  Antti Koivisto  <antti@apple.com>
> 
>         [CSS Container Queries] Basic support for container units
>diff --git a/Source/WebCore/css/DOMCSSNamespace+CSSNumericFactory.idl b/Source/WebCore/css/DOMCSSNamespace+CSSNumericFactory.idl
>index 3784e006c190178107394c60e59d6ad761992bcd..8a78b7d0363ab3e9c0de2e92cbde8a00a4232312 100644
>--- a/Source/WebCore/css/DOMCSSNamespace+CSSNumericFactory.idl
>+++ b/Source/WebCore/css/DOMCSSNamespace+CSSNumericFactory.idl
>@@ -54,6 +54,12 @@
>     CSSUnitValue pt(double value);
>     CSSUnitValue pc(double value);
>     CSSUnitValue px(double value);
>+    CSSUnitValue cqw(double value);
>+    CSSUnitValue cqh(double value);
>+    CSSUnitValue cqi(double value);
>+    CSSUnitValue cqb(double value);
>+    CSSUnitValue cqmin(double value);
>+    CSSUnitValue cqmax(double value);
> 
>     // <angle>
>     CSSUnitValue deg(double value);
>diff --git a/Source/WebCore/css/typedom/CSSNumericFactory.h b/Source/WebCore/css/typedom/CSSNumericFactory.h
>index 04e29895433ba5f798ca127daea4a991f7d42722..82350b99d874b0fa9065f64ddd5993dd6d830b39 100644
>--- a/Source/WebCore/css/typedom/CSSNumericFactory.h
>+++ b/Source/WebCore/css/typedom/CSSNumericFactory.h
>@@ -68,6 +68,12 @@ public:
>     static Ref<CSSUnitValue> pt(double value) { return CSSUnitValue::create(value, "pt"); }
>     static Ref<CSSUnitValue> pc(double value) { return CSSUnitValue::create(value, "pc"); }
>     static Ref<CSSUnitValue> px(double value) { return CSSUnitValue::create(value, "px"); }
>+    static Ref<CSSUnitValue> cqw(double value) { return CSSUnitValue::create(value, "cqw"); }
>+    static Ref<CSSUnitValue> cqh(double value) { return CSSUnitValue::create(value, "cqh"); }
>+    static Ref<CSSUnitValue> cqi(double value) { return CSSUnitValue::create(value, "cqi"); }
>+    static Ref<CSSUnitValue> cqb(double value) { return CSSUnitValue::create(value, "cqb"); }
>+    static Ref<CSSUnitValue> cqmin(double value) { return CSSUnitValue::create(value, "cqmin"); }
>+    static Ref<CSSUnitValue> cqmax(double value) { return CSSUnitValue::create(value, "cqmax"); }
> 
> 
>     // <angle>
>diff --git a/Source/WebCore/css/typedom/CSSStyleValueFactory.cpp b/Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
>index eeb8ed19b1e336aff937146abc5a56d3845f5298..9fc70fb102716871474536652d4cc13104df3424 100644
>--- a/Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
>+++ b/Source/WebCore/css/typedom/CSSStyleValueFactory.cpp
>@@ -219,6 +219,18 @@ ExceptionOr<Ref<CSSStyleValue>> CSSStyleValueFactory::reifyValue(Ref<CSSValue>&&
>             return Ref<CSSStyleValue> { CSSNumericFactory::dppx(primitiveValue->doubleValue()) };
>         case CSSUnitType::CSS_FR:
>             return Ref<CSSStyleValue> { CSSNumericFactory::fr(primitiveValue->doubleValue()) };
>+        case CSSUnitType::CSS_CQW:
>+            return Ref<CSSStyleValue> { CSSNumericFactory::cqw(primitiveValue->doubleValue()) };
>+        case CSSUnitType::CSS_CQH:
>+            return Ref<CSSStyleValue> { CSSNumericFactory::cqh(primitiveValue->doubleValue()) };
>+        case CSSUnitType::CSS_CQI:
>+            return Ref<CSSStyleValue> { CSSNumericFactory::cqi(primitiveValue->doubleValue()) };
>+        case CSSUnitType::CSS_CQB:
>+            return Ref<CSSStyleValue> { CSSNumericFactory::cqb(primitiveValue->doubleValue()) };
>+        case CSSUnitType::CSS_CQMIN:
>+            return Ref<CSSStyleValue> { CSSNumericFactory::cqmin(primitiveValue->doubleValue()) };
>+        case CSSUnitType::CSS_CQMAX:
>+            return Ref<CSSStyleValue> { CSSNumericFactory::cqmax(primitiveValue->doubleValue()) };
>         
>         case CSSUnitType::CSS_STRING: {
>             auto value = CSSKeywordValue::create(primitiveValue->stringValue());
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 4c2abcce6a7951d426b4ffcf1b53a45c11a37519..50356af122b845e694c8fe4d2a32b16236a04d0e 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,12 @@
>+2022-03-18  Antti Koivisto  <antti@apple.com>
>+
>+        [CSS Container Queries] Add Typed OM support for container units
>+        https://bugs.webkit.org/show_bug.cgi?id=238078
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * web-platform-tests/css/css-contain/container-queries/container-units-typed-om-expected.txt:
>+
> 2022-03-18  Antti Koivisto  <antti@apple.com>
> 
>         [CSS Container Queries] Basic support for container units
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-typed-om-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-typed-om-expected.txt
>index 9562790afdf1e007a7271338e13b4068605ceb9f..9f1db53f2f2d81ca5e900cfa1f47ee4f5b07fb82 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-typed-om-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-units-typed-om-expected.txt
>@@ -1,26 +1,26 @@
> 
>-FAIL CSS.cqw function func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL Reify value with cqw unit assert_equals: expected (number) 10 but got (undefined) undefined
>+PASS CSS.cqw function
>+PASS Reify value with cqw unit
> FAIL Set value with cqw unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
>-FAIL Set value with cqw unit (CSS.cqw) func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL CSS.cqh function func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL Reify value with cqh unit assert_equals: expected (number) 10 but got (undefined) undefined
>+FAIL Set value with cqw unit (CSS.cqw) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
>+PASS CSS.cqh function
>+PASS Reify value with cqh unit
> FAIL Set value with cqh unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
>-FAIL Set value with cqh unit (CSS.cqh) func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL CSS.cqi function func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL Reify value with cqi unit assert_equals: expected (number) 10 but got (undefined) undefined
>+FAIL Set value with cqh unit (CSS.cqh) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
>+PASS CSS.cqi function
>+PASS Reify value with cqi unit
> FAIL Set value with cqi unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
>-FAIL Set value with cqi unit (CSS.cqi) func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL CSS.cqb function func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL Reify value with cqb unit assert_equals: expected (number) 10 but got (undefined) undefined
>+FAIL Set value with cqi unit (CSS.cqi) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
>+PASS CSS.cqb function
>+PASS Reify value with cqb unit
> FAIL Set value with cqb unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
>-FAIL Set value with cqb unit (CSS.cqb) func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL CSS.cqmin function func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL Reify value with cqmin unit assert_equals: expected (number) 10 but got (undefined) undefined
>+FAIL Set value with cqb unit (CSS.cqb) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
>+PASS CSS.cqmin function
>+PASS Reify value with cqmin unit
> FAIL Set value with cqmin unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
>-FAIL Set value with cqmin unit (CSS.cqmin) func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL CSS.cqmax function func is not a function. (In 'func(10)', 'func' is undefined)
>-FAIL Reify value with cqmax unit assert_equals: expected (number) 10 but got (undefined) undefined
>+FAIL Set value with cqmin unit (CSS.cqmin) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
>+PASS CSS.cqmax function
>+PASS Reify value with cqmax unit
> FAIL Set value with cqmax unit (string) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', `10${unit}`)', 'element.attributeStyleMap.set' is undefined)
>-FAIL Set value with cqmax unit (CSS.cqmax) func is not a function. (In 'func(10)', 'func' is undefined)
>+FAIL Set value with cqmax unit (CSS.cqmax) element.attributeStyleMap.set is not a function. (In 'element.attributeStyleMap.set('top', func(10))', 'element.attributeStyleMap.set' is undefined)
>

Flags:

ews-feeder: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 238078: 455098