Attachment 454390 Details for Bug 237716 – Patch

[patch] Patch

bug-237716-20220310195320.patch (text/plain), 11.09 KB, created by Rob Buis on 2022-03-10 11:53:21 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2022-03-10 11:53:21 PST

Size: 11.09 KB

patch

obsolete

>Subversion Revision: 291123
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index cf7bc1421f070bbd71897c1aca7443beae9c4fd0..94bcab53dc186a76f2a2c527a2d71ab43af42054 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,42 @@
>+2022-03-10  Rob Buis  <rbuis@igalia.com>
>+
>+        Rename invalidation methods in SVGElement
>+        https://bugs.webkit.org/show_bug.cgi?id=237716
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Rename invalidation methods in SVGElement to be more specific. This in fact
>+        uses the naming in the underlying ElementData.
>+
>+        * svg/SVGCircleElement.cpp:
>+        (WebCore::SVGCircleElement::svgAttributeChanged):
>+        * svg/SVGElement.cpp:
>+        (WebCore::SVGElement::commitPropertyChange):
>+        * svg/SVGElement.h:
>+        * svg/SVGElementInlines.h:
>+        (WebCore::SVGElement::setAnimatedSVGAttributesAreDirty):
>+        (WebCore::SVGElement::setPresentationalHintStyleIsDirty):
>+        (WebCore::SVGElement::invalidateSVGAttributes): Deleted.
>+        (WebCore::SVGElement::invalidateSVGPresentationalHintStyle): Deleted.
>+        * svg/SVGEllipseElement.cpp:
>+        (WebCore::SVGEllipseElement::svgAttributeChanged):
>+        * svg/SVGFilterElement.cpp:
>+        (WebCore::SVGFilterElement::svgAttributeChanged):
>+        * svg/SVGForeignObjectElement.cpp:
>+        (WebCore::SVGForeignObjectElement::svgAttributeChanged):
>+        * svg/SVGImageElement.cpp:
>+        (WebCore::SVGImageElement::svgAttributeChanged):
>+        * svg/SVGMaskElement.cpp:
>+        (WebCore::SVGMaskElement::svgAttributeChanged):
>+        * svg/SVGPatternElement.cpp:
>+        (WebCore::SVGPatternElement::svgAttributeChanged):
>+        * svg/SVGRectElement.cpp:
>+        (WebCore::SVGRectElement::svgAttributeChanged):
>+        * svg/SVGSVGElement.cpp:
>+        (WebCore::SVGSVGElement::svgAttributeChanged):
>+        * svg/properties/SVGAttributeAnimator.cpp:
>+        (WebCore::SVGAttributeAnimator::invalidateStyle):
>+
> 2022-03-10  Chris Dumez  <cdumez@apple.com>
> 
>         Optimize further the passing of data across threads
>diff --git a/Source/WebCore/svg/SVGCircleElement.cpp b/Source/WebCore/svg/SVGCircleElement.cpp
>index 6d6af2505c4cef2296c9032112d87aff4674947c..4099e377bdd240bced324880bd4344f566bb78f4 100644
>--- a/Source/WebCore/svg/SVGCircleElement.cpp
>+++ b/Source/WebCore/svg/SVGCircleElement.cpp
>@@ -69,7 +69,7 @@ void SVGCircleElement::svgAttributeChanged(const QualifiedName& attrName)
> {
>     if (PropertyRegistry::isKnownAttribute(attrName)) {
>         InstanceInvalidationGuard guard(*this);
>-        invalidateSVGPresentationalHintStyle();
>+        setPresentationalHintStyleIsDirty();
>         return;
>     }
> 
>diff --git a/Source/WebCore/svg/SVGElement.cpp b/Source/WebCore/svg/SVGElement.cpp
>index f2ef7757b59026e86e2fd5fe53b7af8a0ce9b69e..424fb0832913c8d9e682e7dc3feadf192cc0c420 100644
>--- a/Source/WebCore/svg/SVGElement.cpp
>+++ b/Source/WebCore/svg/SVGElement.cpp
>@@ -610,7 +610,7 @@ void SVGElement::commitPropertyChange(SVGProperty* property)
>     // SVGLengthList and not the SVGLength.
>     property->setDirty();
> 
>-    invalidateSVGAttributes();
>+    setAnimatedSVGAttributesAreDirty();
>     svgAttributeChanged(propertyRegistry().propertyAttributeName(*property));
> }
> 
>@@ -626,7 +626,7 @@ void SVGElement::commitPropertyChange(SVGAnimatedProperty& animatedProperty)
>     else
>         setSynchronizedLazyAttribute(attributeName, animatedProperty.baseValAsString());
> 
>-    invalidateSVGAttributes();
>+    setAnimatedSVGAttributesAreDirty();
>     svgAttributeChanged(attributeName);
> }
> 
>diff --git a/Source/WebCore/svg/SVGElement.h b/Source/WebCore/svg/SVGElement.h
>index 2d3a331e8e8254e67f0c6762cd205323fa960ccb..fc6614bd469329a9c464df9e9346f879d977bfd5 100644
>--- a/Source/WebCore/svg/SVGElement.h
>+++ b/Source/WebCore/svg/SVGElement.h
>@@ -82,8 +82,8 @@ public:
> 
>     virtual AffineTransform* supplementalTransform() { return nullptr; }
> 
>-    inline void invalidateSVGAttributes();
>-    inline void invalidateSVGPresentationalHintStyle();
>+    inline void setAnimatedSVGAttributesAreDirty();
>+    inline void setPresentationalHintStyleIsDirty();
> 
>     // The instances of an element are clones made in shadow trees to implement <use>.
>     const WeakHashSet<SVGElement>& instances() const;
>diff --git a/Source/WebCore/svg/SVGElementInlines.h b/Source/WebCore/svg/SVGElementInlines.h
>index 597aa0ee1576c21e75e27d41ab163238bb208ab2..b4c177f89f1bdf1e17361fd1d6ed9263b0efa2a8 100644
>--- a/Source/WebCore/svg/SVGElementInlines.h
>+++ b/Source/WebCore/svg/SVGElementInlines.h
>@@ -30,12 +30,12 @@
> 
> namespace WebCore {
> 
>-inline void SVGElement::invalidateSVGAttributes()
>+inline void SVGElement::setAnimatedSVGAttributesAreDirty()
> {
>     ensureUniqueElementData().setAnimatedSVGAttributesAreDirty(true);
> }
> 
>-inline void SVGElement::invalidateSVGPresentationalHintStyle()
>+inline void SVGElement::setPresentationalHintStyleIsDirty()
> {
>     ensureUniqueElementData().setPresentationalHintStyleIsDirty(true);
>     // Trigger style recalculation for "elements as resource" (e.g. referenced by feImage).
>diff --git a/Source/WebCore/svg/SVGEllipseElement.cpp b/Source/WebCore/svg/SVGEllipseElement.cpp
>index 59599711f4ba99412d9872b80214884072752d19..16a06f94558f9d576d0bf47fa3776899572463a8 100644
>--- a/Source/WebCore/svg/SVGEllipseElement.cpp
>+++ b/Source/WebCore/svg/SVGEllipseElement.cpp
>@@ -72,7 +72,7 @@ void SVGEllipseElement::svgAttributeChanged(const QualifiedName& attrName)
> {
>     if (PropertyRegistry::isKnownAttribute(attrName)) {
>         InstanceInvalidationGuard guard(*this);
>-        invalidateSVGPresentationalHintStyle();
>+        setPresentationalHintStyleIsDirty();
>         return;
>     }
> 
>diff --git a/Source/WebCore/svg/SVGFilterElement.cpp b/Source/WebCore/svg/SVGFilterElement.cpp
>index 5578b519a3622bd706ad27bfe4c6003914858ca0..80d366d1d49e0418cb3a0cd6381f5955165e35c4 100644
>--- a/Source/WebCore/svg/SVGFilterElement.cpp
>+++ b/Source/WebCore/svg/SVGFilterElement.cpp
>@@ -94,7 +94,7 @@ void SVGFilterElement::svgAttributeChanged(const QualifiedName& attrName)
> {
>     if (PropertyRegistry::isAnimatedLengthAttribute(attrName)) {
>         InstanceInvalidationGuard guard(*this);
>-        invalidateSVGPresentationalHintStyle();
>+        setPresentationalHintStyleIsDirty();
>         return;
>     }
> 
>diff --git a/Source/WebCore/svg/SVGForeignObjectElement.cpp b/Source/WebCore/svg/SVGForeignObjectElement.cpp
>index 42f36e7b6db979f1a6110cf80c8f13c882ea57bd..e349bc7196c04cc1f2ebec2975141db6c4ffb050 100644
>--- a/Source/WebCore/svg/SVGForeignObjectElement.cpp
>+++ b/Source/WebCore/svg/SVGForeignObjectElement.cpp
>@@ -77,7 +77,7 @@ void SVGForeignObjectElement::svgAttributeChanged(const QualifiedName& attrName)
>     if (PropertyRegistry::isKnownAttribute(attrName)) {
>         InstanceInvalidationGuard guard(*this);
>         if (attrName == SVGNames::widthAttr || attrName == SVGNames::heightAttr)
>-            invalidateSVGPresentationalHintStyle();
>+            setPresentationalHintStyleIsDirty();
>         else {
>             ASSERT(attrName == SVGNames::xAttr || attrName == SVGNames::yAttr);
>             updateRelativeLengthsInformation();
>diff --git a/Source/WebCore/svg/SVGImageElement.cpp b/Source/WebCore/svg/SVGImageElement.cpp
>index e18548749857aa84be2b3b87930ff9aa5be981b3..1623e739cc03afa482deea655ac6e9e5f03a52b0 100644
>--- a/Source/WebCore/svg/SVGImageElement.cpp
>+++ b/Source/WebCore/svg/SVGImageElement.cpp
>@@ -103,7 +103,7 @@ void SVGImageElement::svgAttributeChanged(const QualifiedName& attrName)
>                     RenderSVGResource::markForLayoutAndParentResourceInvalidation(*renderer);
>             }
>         } else if (attrName == SVGNames::widthAttr || attrName == SVGNames::heightAttr)
>-            invalidateSVGPresentationalHintStyle();
>+            setPresentationalHintStyleIsDirty();
>         else {
>             ASSERT(attrName == SVGNames::preserveAspectRatioAttr);
>             if (auto* renderer = this->renderer())
>diff --git a/Source/WebCore/svg/SVGMaskElement.cpp b/Source/WebCore/svg/SVGMaskElement.cpp
>index 1bfb41d370fc3363cb00ab648484df9d5a03ecdd..63ba72b05382ff58bea052dcbfef5471ba949104 100644
>--- a/Source/WebCore/svg/SVGMaskElement.cpp
>+++ b/Source/WebCore/svg/SVGMaskElement.cpp
>@@ -100,7 +100,7 @@ void SVGMaskElement::svgAttributeChanged(const QualifiedName& attrName)
> {
>     if (PropertyRegistry::isAnimatedLengthAttribute(attrName)) {
>         InstanceInvalidationGuard guard(*this);
>-        invalidateSVGPresentationalHintStyle();
>+        setPresentationalHintStyleIsDirty();
>         return;
>     }
> 
>diff --git a/Source/WebCore/svg/SVGPatternElement.cpp b/Source/WebCore/svg/SVGPatternElement.cpp
>index c4743406222b55da051cfaeaf3eac2c951eb6515..6b54e7efcd83344c38735a71a1dc20c5d48bd865 100644
>--- a/Source/WebCore/svg/SVGPatternElement.cpp
>+++ b/Source/WebCore/svg/SVGPatternElement.cpp
>@@ -112,7 +112,7 @@ void SVGPatternElement::svgAttributeChanged(const QualifiedName& attrName)
> {
>     if (PropertyRegistry::isAnimatedLengthAttribute(attrName)) {
>         InstanceInvalidationGuard guard(*this);
>-        invalidateSVGPresentationalHintStyle();
>+        setPresentationalHintStyleIsDirty();
>         return;
>     }
> 
>diff --git a/Source/WebCore/svg/SVGRectElement.cpp b/Source/WebCore/svg/SVGRectElement.cpp
>index fd40a8ecd8bb99fb4ca5baf55ec3c3257b8b819c..9703154698f8d2e9ca3dbe91d49445f7572574c9 100644
>--- a/Source/WebCore/svg/SVGRectElement.cpp
>+++ b/Source/WebCore/svg/SVGRectElement.cpp
>@@ -80,7 +80,7 @@ void SVGRectElement::svgAttributeChanged(const QualifiedName& attrName)
> {
>     if (PropertyRegistry::isKnownAttribute(attrName)) {
>         InstanceInvalidationGuard guard(*this);
>-        invalidateSVGPresentationalHintStyle();
>+        setPresentationalHintStyleIsDirty();
>         return;
>     }
> 
>diff --git a/Source/WebCore/svg/SVGSVGElement.cpp b/Source/WebCore/svg/SVGSVGElement.cpp
>index 945dbc0c93cdcff576adb51603e7c46c36664b7b..9c6a7e83be7921617e259ca7d3fc8e9a55e358d8 100644
>--- a/Source/WebCore/svg/SVGSVGElement.cpp
>+++ b/Source/WebCore/svg/SVGSVGElement.cpp
>@@ -209,7 +209,7 @@ void SVGSVGElement::svgAttributeChanged(const QualifiedName& attrName)
> {
>     if (PropertyRegistry::isKnownAttribute(attrName)) {
>         InstanceInvalidationGuard guard(*this);
>-        invalidateSVGPresentationalHintStyle();
>+        setPresentationalHintStyleIsDirty();
> 
>         if (auto* renderer = this->renderer())
>             RenderSVGResource::markForLayoutAndParentResourceInvalidation(*renderer);
>diff --git a/Source/WebCore/svg/properties/SVGAttributeAnimator.cpp b/Source/WebCore/svg/properties/SVGAttributeAnimator.cpp
>index 5f23b30126f41fa42d1f68080ce8b944953aeeb3..a6de78ea4844353a5cb39db2b70ed855b9d63c1d 100644
>--- a/Source/WebCore/svg/properties/SVGAttributeAnimator.cpp
>+++ b/Source/WebCore/svg/properties/SVGAttributeAnimator.cpp
>@@ -40,7 +40,7 @@ bool SVGAttributeAnimator::isAnimatedStylePropertyAniamtor(const SVGElement& tar
> void SVGAttributeAnimator::invalidateStyle(SVGElement& targetElement)
> {
>     SVGElement::InstanceInvalidationGuard guard(targetElement);
>-    targetElement.invalidateSVGPresentationalHintStyle();
>+    targetElement.setPresentationalHintStyleIsDirty();
> }
> 
> void SVGAttributeAnimator::applyAnimatedStylePropertyChange(SVGElement& element, CSSPropertyID id, const String& value)

Actions: View | Formatted Diff | Diff

Attachments on bug 237716: 454365 | 454390