Attachment 450115 Details for Bug 235698 – Patch

[patch] Patch

wcore-atspi-root-null-parent.diff (text/plain), 1.35 KB, created by Carlos Garcia Campos on 2022-01-27 01:48:05 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2022-01-27 01:48:05 PST

Size: 1.35 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 7e504f3adbd6..8492b2a53d4d 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2022-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GTK][a11y] Return null reference for root parent reference if queried before being embedded
>+        https://bugs.webkit.org/show_bug.cgi?id=235698
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Once embedded parent-changed will be emitted.
>+
>+        * accessibility/atspi/AccessibilityRootAtspi.cpp:
>+        (WebCore::AccessibilityRootAtspi::parentReference const):
>+
> 2022-01-25  Ziran Sun  <zsun@igalia.com>
> 
>         [css-grid] Fix grid shorthand expansion of initial values
>diff --git a/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp b/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp
>index 7571b7158c9d..f9ba62731f11 100644
>--- a/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp
>+++ b/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.cpp
>@@ -194,6 +194,8 @@ GVariant* AccessibilityRootAtspi::reference() const
> 
> GVariant* AccessibilityRootAtspi::parentReference() const
> {
>+    if (m_parentUniqueName.isNull())
>+	return AccessibilityAtspi::singleton().nullReference();
>     return g_variant_new("(so)", m_parentUniqueName.utf8().data(), m_parentPath.utf8().data());
> }
>

Flags:

aperez: review+
aperez: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 235698: 450115