Attachment 448497 Details for Bug 234315 – Patch

[patch] Patch

bug-234315-20220106224547.patch (text/plain), 3.25 KB, created by cathiechen on 2022-01-06 06:45:49 PST

(hide)

Description:

Filename:

MIME Type:

Creator: cathiechen

Created: 2022-01-06 06:45:49 PST

Size: 3.25 KB

patch

obsolete

>Subversion Revision: 287682
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f8bad983179d652fff2d1a90e70baa871f7540df..00d4cbc8057deb3260551c9d91a064d03f439eba 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2022-01-06  Cathie Chen  <cathiechen@igalia.com>
>+
>+        ASSERTION FAILED in RenderLayer::updateClipRects
>+        https://bugs.webkit.org/show_bug.cgi?id=234315
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In clippingRootForPainting(), the dialog element uses the top layer as its clipping root layer.
>+        When it caculates the clip rects, it caculates all its ancestors' clip rects and caches them
>+        including the clipping root layer. However, if the ancestor is a transformed layer, it should be
>+        treated as a root layer. When the tranformed layer updates its clip rects, the root layer won't
>+        match the one in cache. This patch stops the dialog descendant propagating its clipping root layer
>+        to the ancestors' in cache.
>+
>+        * rendering/RenderLayer.cpp:
>+        (WebCore::RenderLayer::clipCrossesPaintingBoundary const):
>+
> 2022-01-06  Jean-Yves Avenard  <jya@apple.com>
> 
>         length argument passed to didReceiveData can never be negative.
>diff --git a/Source/WebCore/rendering/RenderLayer.cpp b/Source/WebCore/rendering/RenderLayer.cpp
>index 9ba0399ceeabf57caa07297470590836f2d0eaf8..aef42b8edf58634ba2da3b7483ff589a677e7bce 100644
>--- a/Source/WebCore/rendering/RenderLayer.cpp
>+++ b/Source/WebCore/rendering/RenderLayer.cpp
>@@ -4454,6 +4454,9 @@ ClipRects* RenderLayer::clipRects(const ClipRectsContext& context) const
> 
> bool RenderLayer::clipCrossesPaintingBoundary() const
> {
>+    if (establishesTopLayer() && !parent()->establishesTopLayer())
>+        return true;
>+
>     return parent()->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) != enclosingPaginationLayer(IncludeCompositedPaginatedLayers)
>         || parent()->enclosingCompositingLayerForRepaint() != enclosingCompositingLayerForRepaint();
> }
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 5c9635dea277a9763ae85a5f87b8647504eb26fe..d76eeb09da51daba85c157a80d9cab205ebe2553 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2022-01-06  Cathie Chen  <cathiechen@igalia.com>
>+
>+        ASSERTION FAILED in RenderLayer::updateClipRects
>+        https://bugs.webkit.org/show_bug.cgi?id=234315
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestExpectations:
>+
> 2022-01-05  Antoine Quint  <graouts@webkit.org>
> 
>         computed style for transition longhand properties is wrong
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index fcff6bba5093547991864e7f7a7acb37f4149438..0d755a0ff5f3d3337afc3ea2ad83ffb33e9cea3b 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -5073,8 +5073,6 @@ webkit.org/b/233344 imported/w3c/web-platform-tests/css/motion/offset-rotate-002
> 
> imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html [ ImageOnlyFailure ]
> 
>-webkit.org/b/234315 [ Debug ] fast/layers/top-layer-ancestor-opacity-and-transform-crash.html [ Skip ]
>-
> webkit.org/b/183994 imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block.html [ Failure ]
> 
> # Plugins

Actions: View | Formatted Diff | Diff

Attachments on bug 234315: 447933 | 448494 | 448497 | 448563 | 448725 | 448776