Attachment 448494 Details for Bug 234315 – Patch

[patch] Patch

bug-234315-20220106222835.patch (text/plain), 3.24 KB, created by cathiechen on 2022-01-06 06:28:36 PST

(hide)

Description:

Filename:

MIME Type:

Creator: cathiechen

Created: 2022-01-06 06:28:36 PST

Size: 3.24 KB

patch

obsolete

>Subversion Revision: 287234
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index b6106bba24d14a7ce54cea4a359eb2cfde6bb190..ed2f0a4ccadf0eb38e75e4024f3fa551089c3bd6 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2022-01-06  Cathie Chen  <cathiechen@igalia.com>
>+
>+        ASSERTION FAILED in RenderLayer::updateClipRects
>+        https://bugs.webkit.org/show_bug.cgi?id=234315
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        In clippingRootForPainting(), the dialog element uses the top layer as its clipping root layer.
>+        When it caculates the clip rects, it caculates all its ancestors' clip rects and caches them
>+        including the clipping root layer. However, if the ancestor is a transformed layer, it should be
>+        treated as a root layer. When the tranformed layer updates its clip rects, the root layer won't
>+        match the one in cache. This patch stops the dialog descendant propagating its clipping root layer
>+        to the ancestors' in cache.
>+
>+        * rendering/RenderLayer.cpp:
>+        (WebCore::RenderLayer::clipCrossesPaintingBoundary const):
>+
> 2021-12-18  Darin Adler  <darin@apple.com>
> 
>         Hash tables, read/write, and heap memory are used unnecessarily, which may hurt performance
>diff --git a/Source/WebCore/rendering/RenderLayer.cpp b/Source/WebCore/rendering/RenderLayer.cpp
>index 6509f5bfe532ec09b8f3d8c452e8b69af41ce8bb..0e6d567c0dab0d182719034ec50b19722a33fc7d 100644
>--- a/Source/WebCore/rendering/RenderLayer.cpp
>+++ b/Source/WebCore/rendering/RenderLayer.cpp
>@@ -4456,6 +4456,9 @@ ClipRects* RenderLayer::clipRects(const ClipRectsContext& context) const
> 
> bool RenderLayer::clipCrossesPaintingBoundary() const
> {
>+    if (establishesTopLayer() && !parent()->establishesTopLayer())
>+        return true;
>+
>     return parent()->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) != enclosingPaginationLayer(IncludeCompositedPaginatedLayers)
>         || parent()->enclosingCompositingLayerForRepaint() != enclosingCompositingLayerForRepaint();
> }
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index cf5b0741b89543f80d089282db53b603b46c3bfa..b759d4d911c176be6ef4e1cbe8dfa5e664a40029 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,12 @@
>+2022-01-06  Cathie Chen  <cathiechen@igalia.com>
>+
>+        ASSERTION FAILED in RenderLayer::updateClipRects
>+        https://bugs.webkit.org/show_bug.cgi?id=234315
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * TestExpectations:
>+
> 2021-12-17  Simon Fraser  <simon.fraser@apple.com>
> 
>         Read the default value of the ScrollAnimatorEnabled setting from NSUserDefaults
>diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
>index f10d6bda0114b61c147161453051f47b3ec32e92..91f2870a25148781d405c1724de39511fe4312de 100644
>--- a/LayoutTests/TestExpectations
>+++ b/LayoutTests/TestExpectations
>@@ -5075,8 +5075,6 @@ webkit.org/b/233344 imported/w3c/web-platform-tests/css/motion/offset-rotate-002
> 
> imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html [ ImageOnlyFailure ]
> 
>-webkit.org/b/234315 [ Debug ] fast/layers/top-layer-ancestor-opacity-and-transform-crash.html [ Skip ]
>-
> # Plugins
> # FIXME: Remove these tests.
> plugins/ [ Skip ]

Actions: View | Formatted Diff | Diff

Attachments on bug 234315: 447933 | 448494 | 448497 | 448563 | 448725 | 448776