Attachment 448226 Details for Bug 234808 – Patch

[patch] Patch

wcore-atspi-destroy-wrappers-main-thread.diff (text/plain), 2.23 KB, created by Carlos Garcia Campos on 2022-01-03 04:30:29 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Carlos Garcia Campos

Created: 2022-01-03 04:30:29 PST

Size: 2.23 KB

patch

obsolete

>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index cb8c876763b2..1028f01471b2 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2022-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
>+
>+        [GTK][a11y] Ensure ATSPI wrappers are destroyed in the main thread
>+        https://bugs.webkit.org/show_bug.cgi?id=234808
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Sometimes they can be destroyed in the a11y thread, since we keep a reference when unregistering the objects.
>+
>+        * accessibility/atspi/AccessibilityObjectAtspi.h:
>+        * accessibility/atspi/AccessibilityRootAtspi.h:
>+
> 2022-01-01  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [GTK][a11y] Unregister objects and clear cache when last client disconnect with ATSPI
>diff --git a/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h b/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h
>index 55b993d05451..f9f7a5c0ee2a 100644
>--- a/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h
>+++ b/Source/WebCore/accessibility/atspi/AccessibilityObjectAtspi.h
>@@ -36,7 +36,7 @@ namespace WebCore {
> class AXCoreObject;
> class AccessibilityRootAtspi;
> 
>-class AccessibilityObjectAtspi final : public ThreadSafeRefCounted<AccessibilityObjectAtspi> {
>+class AccessibilityObjectAtspi final : public ThreadSafeRefCounted<AccessibilityObjectAtspi, WTF::DestructionThread::Main> {
> public:
>     static Ref<AccessibilityObjectAtspi> create(AXCoreObject*, AccessibilityRootAtspi*);
>     ~AccessibilityObjectAtspi() = default;
>diff --git a/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h b/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h
>index 407e714d42b3..c648bb94d50c 100644
>--- a/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h
>+++ b/Source/WebCore/accessibility/atspi/AccessibilityRootAtspi.h
>@@ -33,7 +33,7 @@ namespace WebCore {
> class AccessibilityObjectAtspi;
> class Page;
> 
>-class AccessibilityRootAtspi final : public ThreadSafeRefCounted<AccessibilityRootAtspi> {
>+class AccessibilityRootAtspi final : public ThreadSafeRefCounted<AccessibilityRootAtspi, WTF::DestructionThread::Main> {
>     WTF_MAKE_FAST_ALLOCATED;
> public:
>     static Ref<AccessibilityRootAtspi> create(Page&);

Flags:

jdiggs: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 234808: 448216 | 448220 | 448226