Attachment 442248 Details for Bug 231959 – Patch

[patch] Patch

bug-231959-20211023150949.patch (text/plain), 10.76 KB, created by Cameron McCormack (:heycam) on 2021-10-22 21:09:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Cameron McCormack (:heycam)

Created: 2021-10-22 21:09:50 PDT

Size: 10.76 KB

patch

obsolete

>Subversion Revision: 284730
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 9a693832de14d363cbb51c5e6e2edc8ab16beb60..fdcb5d6a9d2f59021fa7de8ab755ee2d05a72735 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,17 @@
>+2021-10-22  Cameron McCormack  <heycam@apple.com>
>+
>+        Update WPT test tolerance and mark some failures as simulator-only
>+        https://bugs.webkit.org/show_bug.cgi?id=231959
>+        <rdar://problem/84417651>
>+
>+        Unreviewed test gardening.
>+
>+        The ipad failures are really iPad simulator failures.
>+
>+        * platform/ios-simulator/TestExpectations:
>+        * platform/ipad/TestExpectations:
>+        * platform/mac/TestExpectations:
>+
> 2021-10-12  Cameron McCormack  <heycam@apple.com>
> 
>         Test that colors in a canvas.captureStream() video track are preserved when sent over a peer connection
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index 1b8bf00001904df701759da5990aa2c895c04174..b8575bf18876831819259ec26b1925bbbfeffd7d 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,14 @@
>+2021-10-22  Cameron McCormack  <heycam@apple.com>
>+
>+        Tweak test tolerance
>+        https://bugs.webkit.org/show_bug.cgi?id=231959
>+        <rdar://problem/84417651>
>+
>+        Unreviewed.
>+
>+        * web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html:
>+        * web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html:
>+
> 2021-10-22  Joonghun Park  <pjh0718@gmail.com>
> 
>         Integer interpolation in animations should be rounded towards positive infinity, not away from zero.
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html b/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html
>index 6f15a10eccec0bf0d36d68951d971493343c4474..e734820d116b772d03c9f5579f768ab1be99bcd1 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html
>@@ -11,7 +11,7 @@
> <script>
> function testCanvasDisplayingPattern(canvas, width, height, sourceIsVideo)
> {
>-    var tolerance = 1;
>+    var tolerance = 3;
>     let topLeft = [255, 0, 0, 255];
>     let topRight = [0, 255, 0, 255];
>     let bottomLeft = [0, 0, 255, 255];
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html b/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html
>index f1fea5971fe5cda18f0a532aa96bb663e1f9bfd4..99d08d830075d86fb00ca57ea3e96ead7a50c236 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html
>@@ -11,7 +11,7 @@
> <script>
> function testCanvasDisplayingPattern(canvas, width, height, sourceIsVideo, flipped)
> {
>-    var tolerance = 1;
>+    var tolerance = 3;
>     let topLeft = [255, 0, 0, 255];
>     let topRight = [0, 255, 0, 255];
>     let bottomLeft = [0, 0, 255, 255];
>diff --git a/LayoutTests/platform/ios-simulator/TestExpectations b/LayoutTests/platform/ios-simulator/TestExpectations
>index e0a3406cd16a40ef9b026abe95f8a9be31129fcc..bd26e921f53b9f78402c493a75079496ecdb3f8e 100644
>--- a/LayoutTests/platform/ios-simulator/TestExpectations
>+++ b/LayoutTests/platform/ios-simulator/TestExpectations
>@@ -64,6 +64,8 @@ imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/can
> imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-canvas.html [ Failure ]
> imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-cloned.html [ Failure ]
> imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-image.html [ Failure ]
>+imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-video.html [ Failure ]
>+imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html [ Failure ]
> imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-pattern-canvas.html [ Failure ]
> imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-pattern-image.html [ Failure ]
> imported/w3c/web-platform-tests/html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-settings.html [ Failure ]
>@@ -80,6 +82,14 @@ imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.s
> imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas/2d.color.space.p3.toDataURL.with.putImageData.html [ Failure ]
> storage/indexeddb/structured-clone-image-data-display-p3.html [ Failure ]
> 
>+# These fail due to color space issues in the specific iPad simulator used <rdar://84527732>
>+webkit.org/b/232090 fast/canvas/canvas-createPattern-video-loading.html [ Failure ]
>+webkit.org/b/232090 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/canvas-createImageBitmap-video-resize.html [ Failure ]
>+webkit.org/b/292090 fast/canvas/canvas-createPattern-video-modify.html [ Failure ]
>+webkit.org/b/292090 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html [ Failure ]
>+webkit.org/b/292090 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html [ Failure ]
>+webkit.org/b/292090 media/video-canvas-createPattern.html [ Failure ]
>+
> # Imported css-text test suite from WPT
> webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-001.html [ ImageOnlyFailure ]
> webkit.org/b/183258 imported/w3c/web-platform-tests/css/css-text/white-space/textarea-pre-wrap-002.html [ ImageOnlyFailure ]
>diff --git a/LayoutTests/platform/ipad/TestExpectations b/LayoutTests/platform/ipad/TestExpectations
>index 74f451f6cfcfdbc3b0d0ffca78bbc71cff46f418..ff998535f1075e779a3935725a4bad366cd2cf4e 100644
>--- a/LayoutTests/platform/ipad/TestExpectations
>+++ b/LayoutTests/platform/ipad/TestExpectations
>@@ -104,9 +104,6 @@ webkit.org/b/229566 imported/w3c/web-platform-tests/html/semantics/interactive-e
> 
> webkit.org/b/228663 fast/canvas/canvas-color-space-display-p3.html [ ImageOnlyFailure ]
> 
>-webkit.org/b/232090 fast/canvas/canvas-createPattern-video-loading.html [ Failure ]
>-webkit.org/b/232090 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/canvas-createImageBitmap-video-resize.html [ Failure ]
>-
> webkit.org/b/230419 platform/ipad/media/modern-media-controls/media-documents/media-document-video-ios-sizing.html [ Pass Timeout Crash ]
> 
> webkit.org/b/231611 [ Debug ] imported/w3c/web-platform-tests/webrtc-encoded-transform/sframe-transform-in-worker.https.html [ Pass Failure ]
>@@ -114,8 +111,3 @@ webkit.org/b/231611 [ Debug ] imported/w3c/web-platform-tests/webrtc-encoded-tra
> webkit.org/b/231616 [ Debug ] compositing/layer-creation/scale-rotation-transition-overlap.html [ Pass Failure Timeout ]
> 
> webkit.org/b/231640 [ Debug ] webrtc/video-mute.html [ Pass Timeout ]
>-
>-webkit.org/b/231959 media/video-canvas-createPattern.html [ Failure ]
>-webkit.org/b/231959 fast/canvas/canvas-createPattern-video-modify.html [ Failure ]
>-webkit.org/b/231959 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html [ Failure ]
>-webkit.org/b/231959 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html [ Failure ]
>diff --git a/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY-expected.txt b/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY-expected.txt
>index ec1a49b4be75233e44c1d3d4c668aaee2954042e..fec231006683341177834df67ea3a7531f44fb15 100644
>--- a/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY-expected.txt
>+++ b/LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY-expected.txt
>@@ -8,7 +8,7 @@ PASS createImageBitmap from an HTMLVideoElement from a data URL imageOrientation
> PASS createImageBitmap from a bitmap HTMLImageElement imageOrientation: "none", and drawImage on the created ImageBitmap
> PASS createImageBitmap from a bitmap HTMLImageElement imageOrientation: "flipY", and drawImage on the created ImageBitmap
> PASS createImageBitmap from a vector HTMLImageElement imageOrientation: "none", and drawImage on the created ImageBitmap
>-FAIL createImageBitmap from a vector HTMLImageElement imageOrientation: "flipY", and drawImage on the created ImageBitmap assert_approx_equals: Red channel of the pixel at (5, 5) expected 0 +/- 1 but got 255
>+FAIL createImageBitmap from a vector HTMLImageElement imageOrientation: "flipY", and drawImage on the created ImageBitmap assert_approx_equals: Red channel of the pixel at (5, 5) expected 0 +/- 3 but got 255
> FAIL createImageBitmap from a bitmap SVGImageElement imageOrientation: "none", and drawImage on the created ImageBitmap promise_test: Unhandled rejection with value: object "TypeError: Type error"
> FAIL createImageBitmap from a bitmap SVGImageElement imageOrientation: "flipY", and drawImage on the created ImageBitmap promise_test: Unhandled rejection with value: object "TypeError: Type error"
> FAIL createImageBitmap from a vector SVGImageElement imageOrientation: "none", and drawImage on the created ImageBitmap promise_test: Unhandled rejection with value: object "TypeError: Type error"
>diff --git a/LayoutTests/platform/mac/TestExpectations b/LayoutTests/platform/mac/TestExpectations
>index 5e3101f07c3e18389d6b62443cbac11ea5f76a03..2bd75ace37ab5d6d72af4eb70162676c1bfc92fe 100644
>--- a/LayoutTests/platform/mac/TestExpectations
>+++ b/LayoutTests/platform/mac/TestExpectations
>@@ -2437,6 +2437,3 @@ webkit.org/b/230984 [ BigSur Debug arm64 ] streams/readableStream-then.html [ Pa
> webkit.org/b/231757 [ BigSur ] inspector/canvas/updateShader-webgl.html [ Pass Failure ]
> 
> webkit.org/b/231924 inspector/css/modify-css-property.html [ Pass Failure ]
>-
>-webkit.org/b/231959 [ Catalina ] imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html [ Failure ]
>-webkit.org/b/231959 imported/w3c/web-platform-tests/html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html [ Failure ]

Actions: View | Formatted Diff | Diff

Attachments on bug 231959: 442231 | 442236 | 442237 | 442248