Attachment 441470 Details for Bug 231854 – Patch

[patch] Patch

bug-231854-20211016005831.patch (text/plain), 1.87 KB, created by Lauro Moura on 2021-10-15 20:58:33 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Lauro Moura

Created: 2021-10-15 20:58:33 PDT

Size: 1.87 KB

patch

obsolete

>Subversion Revision: 284199
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 4d97a95fef727796be16502dec5e75c530abffcb..d33571f2847665bfbf16c1a0cae410137b5b5ed9 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,21 @@
>+2021-10-15  Lauro Moura  <lmoura@igalia.com>
>+
>+        [GTK4] Update signal name to monitor window resize
>+        https://bugs.webkit.org/show_bug.cgi?id=231854
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Using size-changed (previous signal name) makes the MiniBrowser crash
>+        running the WebDriver tests.
>+
>+        The signal name was changed in
>+        https://gitlab.gnome.org/GNOME/gtk/-/commit/b7380543449ea679a2c912b66aab4855b2bb41f2,
>+        as part of GTK 3.99.5.
>+
>+        Covered by existing tests.
>+
>+        * UIProcess/API/glib/WebKitUIClient.cpp:
>+
> 2021-10-14  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         [JS IPC] Make it possible to establish a stream connection using the JS IPC testing API
>diff --git a/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp b/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
>index 6c1cf45443633e4c548c146657bd52a574362ab3..64c90f9f25fc44911e819ab94fa973bf0b82a0e4 100644
>--- a/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
>+++ b/Source/WebKit/UIProcess/API/glib/WebKitUIClient.cpp
>@@ -208,7 +208,7 @@ private:
> 
> #if USE(GTK4)
>             auto* surface = gtk_native_get_surface(GTK_NATIVE(window));
>-            auto signalID = g_signal_connect(surface, "size-changed", G_CALLBACK(+[](GdkSurface*, int width, int height, GdkRectangle* targetGeometry) {
>+            auto signalID = g_signal_connect(surface, "layout", G_CALLBACK(+[](GdkSurface*, int width, int height, GdkRectangle* targetGeometry) {
>                 if (width == targetGeometry->width && height == targetGeometry->height)
>                     RunLoop::current().stop();
>             }), &geometry);

Actions: View | Formatted Diff | Diff

Attachments on bug 231854: 441470