Attachment 436910 Details for Bug 229720 – WIP patch

[patch] WIP patch

229720_wip.patch (text/plain), 3.26 KB, created by Chris Dumez on 2021-08-31 10:48:20 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Dumez

Created: 2021-08-31 10:48:20 PDT

Size: 3.26 KB

patch

obsolete

>diff --git a/LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/popup-coop-by-sw.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/popup-coop-by-sw.https-expected.txt
>index 2dcc617c4960..7aee086dfc6a 100644
>--- a/LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/popup-coop-by-sw.https-expected.txt
>+++ b/LayoutTests/imported/w3c/web-platform-tests/html/cross-origin-opener-policy/popup-coop-by-sw.https-expected.txt
>@@ -1,12 +1,11 @@
>+CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Load failed
> 
>-Harness Error (TIMEOUT), message = null
>-
>-TIMEOUT opener:basic, openee:basic, sw:basic Test timed out
>-NOTRUN opener:basic, openee:basic, sw:coi
>-NOTRUN opener:basic, openee:coi, sw:basic
>-NOTRUN opener:basic, openee:coi, sw:coi
>-NOTRUN opener:coi, openee:basic, sw:basic
>-NOTRUN opener:coi, openee:basic, sw:coi
>-NOTRUN opener:coi, openee:coi, sw:basic
>-NOTRUN opener:coi, openee:coi, sw:coi
>+PASS opener:basic, openee:basic, sw:basic
>+PASS opener:basic, openee:basic, sw:coi
>+PASS opener:basic, openee:coi, sw:basic
>+PASS opener:basic, openee:coi, sw:coi
>+PASS opener:coi, openee:basic, sw:basic
>+PASS opener:coi, openee:basic, sw:coi
>+PASS opener:coi, openee:coi, sw:basic
>+PASS opener:coi, openee:coi, sw:coi
> 
>diff --git a/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp b/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
>index 33014a3e7367..c6baa29b3142 100644
>--- a/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
>+++ b/Source/WebCore/workers/service/ServiceWorkerGlobalScope.cpp
>@@ -61,6 +61,11 @@ ServiceWorkerGlobalScope::ServiceWorkerGlobalScope(ServiceWorkerContextData&& da
> 
> ServiceWorkerGlobalScope::~ServiceWorkerGlobalScope() = default;
> 
>+ServiceWorker* ServiceWorkerGlobalScope::serviceWorker()
>+{
>+    return this->serviceWorker(m_contextData.serviceWorkerIdentifier);
>+}
>+
> void ServiceWorkerGlobalScope::skipWaiting(Ref<DeferredPromise>&& promise)
> {
>     uint64_t requestIdentifier = ++m_lastRequestIdentifier;
>diff --git a/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h b/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h
>index c43d86545fcb..74542bcc5db2 100644
>--- a/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h
>+++ b/Source/WebCore/workers/service/ServiceWorkerGlobalScope.h
>@@ -53,6 +53,9 @@ public:
> 
>     ServiceWorkerClients& clients() { return m_clients.get(); }
>     ServiceWorkerRegistration& registration() { return m_registration.get(); }
>+
>+    using WorkerGlobalScope::serviceWorker;
>+    ServiceWorker* serviceWorker();
>     
>     void skipWaiting(Ref<DeferredPromise>&&);
> 
>diff --git a/Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl b/Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl
>index b4b9105fc430..4f917c777c1e 100644
>--- a/Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl
>+++ b/Source/WebCore/workers/service/ServiceWorkerGlobalScope.idl
>@@ -34,6 +34,7 @@
> ] interface ServiceWorkerGlobalScope : WorkerGlobalScope {
>     [SameObject] readonly attribute ServiceWorkerClients clients;
>     [SameObject] readonly attribute ServiceWorkerRegistration registration;
>+    [SameObject] readonly attribute ServiceWorker serviceWorker;
> 
>     [NewObject] Promise<undefined> skipWaiting();
>

Actions: View | Formatted Diff | Diff

Attachments on bug 229720: 436900 | 436910 | 436913 | 436924 | 436929 | 436965 | 437027