Attachment 432935 Details for Bug 227679 – Patch

[patch] Patch

bug-227679-20210706163006.patch (text/plain), 3.45 KB, created by Chris Lord on 2021-07-06 08:30:07 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Lord

Created: 2021-07-06 08:30:07 PDT

Size: 3.45 KB

patch

obsolete

>Subversion Revision: 278926
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 51d53ef1f9a43529ddeaf66bfc1f54e3f5430f66..8903b97a7e8a620380b33a719cf30cbb179d58fc 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,18 @@
>+2021-07-06  Chris Lord  <clord@igalia.com>
>+
>+        [WPE] Fieldset elements can incorrectly get treated as opaque with async scrolling overflow areas enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=227679
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Don't treat fieldset elements as opaque as their background shape is
>+        determined by its children and can be non-rectangular.
>+
>+        No new tests, covered by existing tests.
>+
>+        * rendering/RenderLayer.cpp:
>+        (WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect const):
>+
> 2021-06-30  Chris Lord  <clord@igalia.com>
> 
>         Pixel snapping is incorrect for async scrolled overflow layers
>diff --git a/Source/WebCore/rendering/RenderLayer.cpp b/Source/WebCore/rendering/RenderLayer.cpp
>index b93aaa6b80e42d2a3d39ce255b16fae3054b4191..02a67c5ad9327ac066af7abc052d1fd470610cb4 100644
>--- a/Source/WebCore/rendering/RenderLayer.cpp
>+++ b/Source/WebCore/rendering/RenderLayer.cpp
>@@ -5035,6 +5035,10 @@ bool RenderLayer::backgroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect)
>     if (renderer().isTablePart())
>         return false;
> 
>+    // A fieldset with a legend will have an irregular shape, so can't be treated as opaque.
>+    if (renderer().isFieldset())
>+        return false;
>+
>     // FIXME: We currently only check the immediate renderer,
>     // which will miss many cases.
>     if (renderer().backgroundIsKnownToBeOpaqueInRect(localRect))
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index fe57ffe5814e4454d7eb0bc395d2f13365f5f417..411f673ea3947261f37d6e431c0c02b49a8996af 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,15 @@
>+2021-07-06  Chris Lord  <clord@igalia.com>
>+
>+        [WPE] Fieldset elements can incorrectly get treated as opaque with async scrolling overflow areas enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=227679
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WPT fieldset-overflow test now passes with async overflow scrolling
>+        enabled.
>+
>+        * platform/wpe/TestExpectations:
>+
> 2021-06-30  Chris Lord  <clord@igalia.com>
> 
>         Pixel snapping is incorrect for async scrolled overflow layers
>diff --git a/LayoutTests/platform/wpe/TestExpectations b/LayoutTests/platform/wpe/TestExpectations
>index 5710513d4486fe5517f71685b91b5aa565576bdc..160f0fe192cde05f79b1b00a9b0f90a81f1513cb 100644
>--- a/LayoutTests/platform/wpe/TestExpectations
>+++ b/LayoutTests/platform/wpe/TestExpectations
>@@ -718,7 +718,6 @@ webkit.org/b/224596 css3/filters/clipping-overflow-scroll-with-pixel-moving-effe
> webkit.org/b/224596 fast/scrolling/rtl-scrollbars-overflow-dir-rtl.html [ ImageOnlyFailure ]
> webkit.org/b/224596 fast/scrolling/rtl-scrollbars-overflow-padding.html [ ImageOnlyFailure ]
> webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-position/hypothetical-box-scroll-parent.html [ ImageOnlyFailure ]
>-webkit.org/b/224596 imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-overflow.html [ ImageOnlyFailure ]
> webkit.org/b/227061 imported/w3c/web-platform-tests/css/css-ui/outline-negative-offset-composited-scroll.html [ ImageOnlyFailure ]
> 
> # These tests are passing most of the times since r275515.

Actions: View | Formatted Diff | Diff

Attachments on bug 227679: 432935 | 432936 | 432937