Attachment 430452 Details for Bug 226327 – Patch

[patch] Patch

bug-226327-20210603100653.patch (text/plain), 3.13 KB, created by Chris Lord on 2021-06-03 02:06:55 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Lord

Created: 2021-06-03 02:06:55 PDT

Size: 3.13 KB

patch

obsolete

>Subversion Revision: 278154
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 0093b66d72c3eaeeae77b67e49a309e622c2f3a7..ac71033afd2ae8976b7115f1cfc1d39b4e0a5ec8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,20 @@
>+2021-06-03  Chris Lord  <clord@igalia.com>
>+
>+        [WPE] position:sticky content is not correctly offset on async scrolled overflow layers with an RTL vertical scrollbar
>+        https://bugs.webkit.org/show_bug.cgi?id=226327
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Make sure to respect the origin of sticky positioning nodes'
>+        constraining rect.
>+
>+        No new tests, covered by existing tests.
>+
>+        * page/scrolling/cocoa/ScrollingTreeStickyNode.mm:
>+        (WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
>+        * page/scrolling/nicosia/ScrollingTreeStickyNode.cpp:
>+        (WebCore::ScrollingTreeStickyNode::computeLayerPosition const):
>+
> 2021-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
> 
>         [SOUP] Do not disable the idle connection timeout
>diff --git a/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm b/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm
>index ad03b809d4550eb6c0af41d2016fc2f47fc983ba..5b28b840c697a58c1ff392315e8b29ac94fb6289 100644
>--- a/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm
>+++ b/Source/WebCore/page/scrolling/cocoa/ScrollingTreeStickyNode.mm
>@@ -76,7 +76,8 @@ FloatPoint ScrollingTreeStickyNode::computeLayerPosition() const
>             constrainingRect = frameScrollingNode.layoutViewport();
>         } else {
>             auto& overflowScrollingNode = downcast<ScrollingTreeOverflowScrollingNode>(scrollingNode);
>-            constrainingRect = FloatRect(overflowScrollingNode.currentScrollOffset(), m_constraints.constrainingRectAtLastLayout().size());
>+            constrainingRect = m_constraints.constrainingRectAtLastLayout();
>+            constrainingRect.move(overflowScrollingNode.scrollDeltaSinceLastCommit());
>         }
>         return m_constraints.layerPositionForConstrainingRect(constrainingRect);
>     };
>diff --git a/Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNode.cpp b/Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNode.cpp
>index d71e357f828fda593f219f0508ce7b4c9484025f..25197aaf37bec27b7e6a019c08e55c27bf9babd5 100644
>--- a/Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNode.cpp
>+++ b/Source/WebCore/page/scrolling/nicosia/ScrollingTreeStickyNode.cpp
>@@ -118,7 +118,8 @@ FloatPoint ScrollingTreeStickyNode::computeLayerPosition() const
>             constrainingRect = frameScrollingNode.layoutViewport();
>         } else {
>             auto& overflowScrollingNode = downcast<ScrollingTreeOverflowScrollingNode>(scrollingNode);
>-            constrainingRect = FloatRect(overflowScrollingNode.currentScrollOffset(), m_constraints.constrainingRectAtLastLayout().size());
>+            constrainingRect = m_constraints.constrainingRectAtLastLayout();
>+            constrainingRect.move(overflowScrollingNode.scrollDeltaSinceLastCommit());
>         }
>         return m_constraints.layerPositionForConstrainingRect(constrainingRect);
>     };

Actions: View | Formatted Diff | Diff

Attachments on bug 226327: 430452 | 430453