Attachment 429801 Details for Bug 226259 – Patch

[patch] Patch

bug-226259-20210526230949.patch (text/plain), 5.57 KB, created by Chris Lord on 2021-05-26 15:09:50 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Lord

Created: 2021-05-26 15:09:50 PDT

Size: 5.57 KB

patch

obsolete

>Subversion Revision: 277945
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 08d8ae5c0ccfbe76c84b8ef88df81e2d4aeae229..ff462910d0ece400ba84827768415f0cba725749 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,17 @@
>+2021-05-26  Chris Lord  <clord@igalia.com>
>+
>+        Scrollbars/indicators are sometimes incorrectly drawn when async overflow scrolling is enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=226259
>+
>+        Reviewed by Simon Fraser.
>+
>+        Respect scrolled contents visibility when rendering scrollbar layers.
>+
>+        No new tests, covered by existing tests.
>+
>+        * rendering/RenderLayerBacking.cpp:
>+        (WebCore::RenderLayerBacking::paintContents):
>+
> 2021-05-23  Chris Dumez  <cdumez@apple.com>
> 
>         Make CheckedLock the default Lock
>diff --git a/Source/WebCore/rendering/RenderLayerBacking.cpp b/Source/WebCore/rendering/RenderLayerBacking.cpp
>index 49b72d14c3bd662621e76d67cc66ee5a25c74dfe..d364d96e3218252866d603abd1e0e9dd55e1a80c 100644
>--- a/Source/WebCore/rendering/RenderLayerBacking.cpp
>+++ b/Source/WebCore/rendering/RenderLayerBacking.cpp
>@@ -3470,15 +3470,19 @@ void RenderLayerBacking::paintContents(const GraphicsLayer* graphicsLayer, Graph
>             paintDebugOverlays(graphicsLayer, context);
> 
>     } else if (graphicsLayer == layerForHorizontalScrollbar()) {
>-        auto* scrollableArea = m_owningLayer.scrollableArea();
>-        ASSERT(scrollableArea);
>+        if (m_owningLayer.hasVisibleContent()) {
>+            auto* scrollableArea = m_owningLayer.scrollableArea();
>+            ASSERT(scrollableArea);
> 
>-        paintScrollbar(scrollableArea->horizontalScrollbar(), context, dirtyRect);
>+            paintScrollbar(scrollableArea->horizontalScrollbar(), context, dirtyRect);
>+        }
>     } else if (graphicsLayer == layerForVerticalScrollbar()) {
>-        auto* scrollableArea = m_owningLayer.scrollableArea();
>-        ASSERT(scrollableArea);
>+        if (m_owningLayer.hasVisibleContent()) {
>+            auto* scrollableArea = m_owningLayer.scrollableArea();
>+            ASSERT(scrollableArea);
> 
>-        paintScrollbar(scrollableArea->verticalScrollbar(), context, dirtyRect);
>+            paintScrollbar(scrollableArea->verticalScrollbar(), context, dirtyRect);
>+        }
>     } else if (graphicsLayer == layerForScrollCorner()) {
>         auto* scrollableArea = m_owningLayer.scrollableArea();
>         ASSERT(scrollableArea);
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 82989ec0768a8aeea5cf7d88e229bf1c65da118e..2428b86d990fb91125584402f5ec2dde783c8bb4 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2021-05-26  Chris Lord  <clord@igalia.com>
>+
>+        Scrollbars/indicators are sometimes incorrectly drawn when async overflow scrolling is enabled
>+        https://bugs.webkit.org/show_bug.cgi?id=226259
>+
>+        Reviewed by Simon Fraser.
>+
>+        Some tests involving overflow scrolling now pass.
>+
>+        * platform/wpe/TestExpectations:
>+
> 2021-05-24  Fujii Hironori  <Hironori.Fujii@sony.com>
> 
>         [WinCairo] Unreviewed test gardening
>diff --git a/LayoutTests/platform/wpe/TestExpectations b/LayoutTests/platform/wpe/TestExpectations
>index 2760ec86ea93725a34686e4de5e5af77049ef393..fdc04eaa559a188bc973c7805b7e078a06ca16ab 100644
>--- a/LayoutTests/platform/wpe/TestExpectations
>+++ b/LayoutTests/platform/wpe/TestExpectations
>@@ -707,20 +707,16 @@ webkit.org/b/225379 [ Debug ] imported/w3c/web-platform-tests/webxr/xrBoundedRef
> webkit.org/b/225379 [ Debug ] imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_immersive.https.html [ Crash ]
> webkit.org/b/225379 [ Debug ] imported/w3c/web-platform-tests/webxr/xrDevice_requestSession_non_immersive_no_gesture.https.html [ Crash ]
> 
>-# Test failing since async scrolling was activated in WPE.
>+# Test failing since async overflow scrolling was activated in WPE.
> webkit.org/b/224596 css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent.html [ ImageOnlyFailure ]
> webkit.org/b/224596 css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html [ ImageOnlyFailure ]
> webkit.org/b/224596 fast/scrolling/rtl-scrollbars-overflow-dir-rtl.html [ ImageOnlyFailure ]
> webkit.org/b/224596 fast/scrolling/rtl-scrollbars-overflow-padding.html [ ImageOnlyFailure ]
> webkit.org/b/224596 fast/scrolling/rtl-scrollbars-sticky-overflow-scroll-2.html [ ImageOnlyFailure ]
> webkit.org/b/224596 fast/scrolling/rtl-scrollbars-sticky-overflow-scroll.html [ ImageOnlyFailure ]
>-webkit.org/b/224596 imported/blink/compositing/animation/hidden-animated-layer-should-not-have-scrollbars.html [ ImageOnlyFailure ]
>-webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-flexbox/overflow-auto-001.html [ ImageOnlyFailure ]
> webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-lr-001.html [ ImageOnlyFailure ]
> webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-container-scrollbar-vertical-rl-001.html [ ImageOnlyFailure ]
>-webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-overflow/scrollbar-empty-002.html [ ImageOnlyFailure ]
> webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-position/hypothetical-box-scroll-parent.html [ ImageOnlyFailure ]
>-webkit.org/b/224596 imported/w3c/web-platform-tests/css/css-ui/outline-negative-offset-composited-scroll.html [ ImageOnlyFailure ]
> webkit.org/b/224596 imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-overflow.html [ ImageOnlyFailure ]
> 
> # These tests are passing most of the times since r275515.

Actions: View | Formatted Diff | Diff

Attachments on bug 226259: 429736 | 429754 | 429801