Attachment 427568 Details for Bug 225311 – Patch

[patch] Patch

bug-225311-20210503092134.patch (text/plain), 2.49 KB, created by Jonathan Bedard on 2021-05-03 09:21:35 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Bedard

Created: 2021-05-03 09:21:35 PDT

Size: 2.49 KB

patch

obsolete

>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 276902)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,15 @@
>+2021-05-03  Jonathan Bedard  <jbedard@apple.com>
>+
>+        [webkitcorepy] Pass logging level to child processes
>+        https://bugs.webkit.org/show_bug.cgi?id=225311
>+        <rdar://problem/77457646>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:
>+        (Process.main): Set root logging level.
>+        (TaskPool.__init__): Pass logging level to child process.
>+
> 2021-05-03  Sam Weinig  <weinig@apple.com>
> 
>         Remove default parameter values for color space and pixel format from ImageBuffer::create to make it clear everwhere we are explicitly requesting SRGB/BGRA8 buffers
>Index: Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py
>===================================================================
>--- Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py	(revision 276902)
>+++ Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py	(working copy)
>@@ -231,7 +231,7 @@ class Process(object):
>             cls.working = False
> 
>     @classmethod
>-    def main(cls, name, setup, setupargs, setupkwargs, queue, teardown, teardownargs, teardownkwargs):
>+    def main(cls, name, loglevel, setup, setupargs, setupkwargs, queue, teardown, teardownargs, teardownkwargs):
>         from tblib import pickling_support
> 
>         cls.name = name
>@@ -250,6 +250,7 @@ class Process(object):
>         for handler in logger.handlers:
>             logger.removeHandler(handler)
>         logger.addHandler(cls.LogHandler(queue))
>+        logger.setLevel(loglevel)
> 
>         queue.send(State(State.STARTING))
> 
>@@ -286,6 +287,7 @@ class TaskPool(object):
> 
>     def __init__(
>         self, workers=1, name=None, setup=None, teardown=None, grace_period=5, block_size=1000,
>+        loggers=None,
>         setupargs=None, setupkwargs=None,
>         teardownargs=None, teardownkwargs=None,
>     ):
>@@ -304,7 +306,7 @@ class TaskPool(object):
>         self.workers = [multiprocessing.Process(
>             target=Process.main,
>             args=(
>-                '{}/{}'.format(name, count),
>+                '{}/{}'.format(name, count), logging.getLogger().getEffectiveLevel(),
>                 setup, setupargs, setupkwargs,
>                 BiDirectionalQueue(outgoing=self.queue.incoming, incoming=self.queue.outgoing),
>                 teardown, teardownargs, teardownkwargs,

Actions: View | Formatted Diff | Diff

Attachments on bug 225311: 427568 | 427573 | 427575