Attachment 427195 Details for Bug 225089 – Patch

[patch] Patch

bug-225089-20210428061228.patch (text/plain), 1.56 KB, created by Fujii Hironori on 2021-04-27 14:12:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Fujii Hironori

Created: 2021-04-27 14:12:29 PDT

Size: 1.56 KB

patch

obsolete

>Subversion Revision: 276655
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 955c8c71cf7b1d41db12f71ca8fbd0e5f284c51e..51e20dc014bce69339663128b62469338211181b 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2021-04-27  Fujii Hironori  <Hironori.Fujii@sony.com>
>+
>+        HashTableConstIterator's consistency assertion fails while closing m_webIDBServers in NetworkProcess::didClose since r275846
>+        https://bugs.webkit.org/show_bug.cgi?id=225089
>+
>+        Reviewed by Chris Dumez.
>+
>+        The items of m_webIDBServers were removed while iterating
>+        m_webIDBServers.
>+
>+        Move m_webIDBServers to a temporary HashMap before iterating.
>+
>+        * NetworkProcess/NetworkProcess.cpp:
>+        (WebKit::NetworkProcess::didClose):
>+
> 2021-04-27  Chris Dumez  <cdumez@apple.com>
> 
>         Don't keep local storage data in memory in the NetworkProcess
>diff --git a/Source/WebKit/NetworkProcess/NetworkProcess.cpp b/Source/WebKit/NetworkProcess/NetworkProcess.cpp
>index 3ea0aab449f62dfe87dfecc1f151b807aba4af71..61b962330e44ed3726805ce4609b191f24a5ed8e 100644
>--- a/Source/WebKit/NetworkProcess/NetworkProcess.cpp
>+++ b/Source/WebKit/NetworkProcess/NetworkProcess.cpp
>@@ -274,7 +274,8 @@ void NetworkProcess::didClose(IPC::Connection&)
>     });
> 
>     // Make sure references to NetworkProcess in spaceRequester and closeHandler is removed.
>-    for (auto& server : m_webIDBServers.values())
>+    auto servers = std::exchange(m_webIDBServers, { });
>+    for (auto& server : servers.values())
>         server->close();
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 225089: 427124 | 427191 | 427195