Attachment 424363 Details for Bug 223635 – Patch for landing

[patch] Patch for landing

bug-223635-20210326171336.patch (text/plain), 20.06 KB, created by Imanol Fernandez on 2021-03-26 09:13:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Imanol Fernandez

Created: 2021-03-26 09:13:38 PDT

Size: 20.06 KB

patch

obsolete

>Subversion Revision: 275093
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index f151f6789f0a0834a1dbcb2749c75110d1f8806a..6dc2409882787a60bcfdaa38c1767159d68e7862 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,31 @@
>+2021-03-23  Imanol Fernandez  <ifernandez@igalia.com>
>+
>+        Implement cachedPropertyValue for WebXR [SameObject] attributes
>+        https://bugs.webkit.org/show_bug.cgi?id=223635
>+
>+        Reviewed by Chris Dumez.
>+
>+        [SameObject] is not currently implemented in WebKit. We need to implement custom getters.
>+
>+        Tested by WebXR WPT.
>+
>+        * Modules/webxr/WebXRRigidTransform.h:
>+        (WebCore::WebXRRigidTransform::cachedMatrix):
>+        * Modules/webxr/WebXRRigidTransform.idl:
>+        * Modules/webxr/WebXRView.h:
>+        (WebCore::WebXRView::cachedProjectionMatrix):
>+        * Modules/webxr/WebXRView.idl:
>+        * Modules/webxr/WebXRViewerPose.h:
>+        (WebCore::WebXRViewerPose::cachedViews):
>+        * Modules/webxr/WebXRViewerPose.idl:
>+        * Sources.txt:
>+        * bindings/js/JSWebXRRigidTransformCustom.cpp: Added.
>+        (WebCore::JSWebXRRigidTransform::matrix const):
>+        * bindings/js/JSWebXRViewCustom.cpp: Added.
>+        (WebCore::JSWebXRView::projectionMatrix const):
>+        * bindings/js/JSWebXRViewerPoseCustom.cpp: Added.
>+        (WebCore::JSWebXRViewerPose::views const):
>+
> 2021-03-25  Antoine Quint  <graouts@webkit.org>
> 
>         Fix interpolation of the caret-color CSS property
>diff --git a/Source/WebCore/Modules/webxr/WebXRRigidTransform.h b/Source/WebCore/Modules/webxr/WebXRRigidTransform.h
>index 78cb27e7762a992f03d46eae55098bc125db2867..04bbfac40b80cfaf904fd11c876c4283d58bcc88 100644
>--- a/Source/WebCore/Modules/webxr/WebXRRigidTransform.h
>+++ b/Source/WebCore/Modules/webxr/WebXRRigidTransform.h
>@@ -28,6 +28,7 @@
> #if ENABLE(WEBXR)
> 
> #include "ExceptionOr.h"
>+#include "JSValueInWrappedObject.h"
> #include "TransformationMatrix.h"
> #include <JavaScriptCore/Float32Array.h>
> #include <wtf/IsoMalloc.h>
>@@ -53,6 +54,8 @@ public:
>     const WebXRRigidTransform& inverse();
>     const TransformationMatrix& rawTransform() const;
> 
>+    JSValueInWrappedObject& cachedMatrix() { return m_cachedMatrix; }
>+
> private:
>     WebXRRigidTransform(const DOMPointInit&, const DOMPointInit&);
>     WebXRRigidTransform(const TransformationMatrix&);
>@@ -63,6 +66,7 @@ private:
>     RefPtr<Float32Array> m_matrix;
>     RefPtr<WebXRRigidTransform> m_inverse;
>     WeakPtr<WebXRRigidTransform> m_parentInverse;
>+    JSValueInWrappedObject m_cachedMatrix;
> };
> 
> } // namespace WebCore
>diff --git a/Source/WebCore/Modules/webxr/WebXRRigidTransform.idl b/Source/WebCore/Modules/webxr/WebXRRigidTransform.idl
>index 33441484af84ea8015e7203e129b4ea92b70948b..a63701f9858e5d5c6c4c07abc9f3511c09ae5d12 100644
>--- a/Source/WebCore/Modules/webxr/WebXRRigidTransform.idl
>+++ b/Source/WebCore/Modules/webxr/WebXRRigidTransform.idl
>@@ -28,6 +28,7 @@
>     Conditional=WEBXR,
>     SecureContext,
>     Exposed=Window,
>+    JSCustomMarkFunction,
>     ImplementationLacksVTable,
>     InterfaceName=XRRigidTransform
> ] interface WebXRRigidTransform {
>@@ -35,6 +36,6 @@
> 
>     [SameObject] readonly attribute DOMPointReadOnly position;
>     [SameObject] readonly attribute DOMPointReadOnly orientation;
>-    readonly attribute Float32Array matrix;
>+    [CustomGetter] readonly attribute Float32Array matrix;
>     [SameObject] readonly attribute WebXRRigidTransform inverse;
> };
>diff --git a/Source/WebCore/Modules/webxr/WebXRView.h b/Source/WebCore/Modules/webxr/WebXRView.h
>index ef341f16effe27bc85b704ed911b545f4f152559..1964e8853c08109da50340c19a7a6793c92be118 100644
>--- a/Source/WebCore/Modules/webxr/WebXRView.h
>+++ b/Source/WebCore/Modules/webxr/WebXRView.h
>@@ -27,6 +27,7 @@
> 
> #if ENABLE(WEBXR)
> 
>+#include "JSValueInWrappedObject.h"
> #include "WebXRRigidTransform.h"
> #include "XREye.h"
> #include <JavaScriptCore/Float32Array.h>
>@@ -59,6 +60,8 @@ public:
>     bool isViewportModifiable() const { return m_viewportModifiable; }
>     void setViewportModifiable(bool modifiable) { m_viewportModifiable = modifiable; }
> 
>+    JSValueInWrappedObject& cachedProjectionMatrix() { return m_cachedProjectionMatrix; }
>+
> private:
>     WebXRView(Ref<WebXRFrame>&&, XREye, Ref<WebXRRigidTransform>&&, Ref<Float32Array>&&);
> 
>@@ -68,7 +71,7 @@ private:
>     Ref<Float32Array> m_projection;
>     bool m_viewportModifiable { false };
>     double m_requestedViewportScale { 1.0 };
>-
>+    JSValueInWrappedObject m_cachedProjectionMatrix;
> };
> 
> } // namespace WebCore
>diff --git a/Source/WebCore/Modules/webxr/WebXRView.idl b/Source/WebCore/Modules/webxr/WebXRView.idl
>index a86950480ac143f7347c73c6ff19120525dea9bd..4ec0660f55039e30122f52b7273b93315f98c48e 100644
>--- a/Source/WebCore/Modules/webxr/WebXRView.idl
>+++ b/Source/WebCore/Modules/webxr/WebXRView.idl
>@@ -28,11 +28,12 @@
>     Conditional=WEBXR,
>     SecureContext,
>     Exposed=Window,
>+    JSCustomMarkFunction,
>     ImplementationLacksVTable,
>     InterfaceName=XRView
> ] interface WebXRView {
>     readonly attribute XREye eye;
>-    readonly attribute Float32Array projectionMatrix;
>+    [CustomGetter] readonly attribute Float32Array projectionMatrix;
>     [SameObject] readonly attribute WebXRRigidTransform transform;
>     readonly attribute double? recommendedViewportScale;
>     undefined requestViewportScale(double? scale);
>diff --git a/Source/WebCore/Modules/webxr/WebXRViewerPose.h b/Source/WebCore/Modules/webxr/WebXRViewerPose.h
>index e9f0a39d85b7eace7013ca18429d2b3cbb80dcae..9bd81ee2fb3db87114b5c3a52acbfff8e2884603 100644
>--- a/Source/WebCore/Modules/webxr/WebXRViewerPose.h
>+++ b/Source/WebCore/Modules/webxr/WebXRViewerPose.h
>@@ -45,12 +45,15 @@ public:
>     const Vector<Ref<WebXRView>>& views() const;
>     void setViews(Vector<Ref<WebXRView>>&&);
> 
>+    JSValueInWrappedObject& cachedViews() { return m_cachedViews; }
>+
> private:
>     WebXRViewerPose(Ref<WebXRRigidTransform>&&, bool emulatedPosition);
> 
>     bool isViewerPose() const final { return true; }
> 
>     Vector<Ref<WebXRView>> m_views;
>+    JSValueInWrappedObject m_cachedViews;
> };
> 
> } // namespace WebCore
>diff --git a/Source/WebCore/Modules/webxr/WebXRViewerPose.idl b/Source/WebCore/Modules/webxr/WebXRViewerPose.idl
>index 6a76de843549fbf063d0ba5d4113a0152950b2e4..a62d5f1d234d7cd70e436bf092b289d0a5f9a467 100644
>--- a/Source/WebCore/Modules/webxr/WebXRViewerPose.idl
>+++ b/Source/WebCore/Modules/webxr/WebXRViewerPose.idl
>@@ -32,5 +32,5 @@
>     JSGenerateToNativeObject,
>     InterfaceName=XRViewerPose
> ] interface WebXRViewerPose : WebXRPose {
>-    [SameObject] readonly attribute FrozenArray<WebXRView> views;
>+    [CachedAttribute, SameObject] readonly attribute FrozenArray<WebXRView> views;
> };
>diff --git a/Source/WebCore/Sources.txt b/Source/WebCore/Sources.txt
>index a75a2f335dda55732843dab00a6318984b844a6c..f6844902ddc5f3627908eee2284ab1f59eba9884 100644
>--- a/Source/WebCore/Sources.txt
>+++ b/Source/WebCore/Sources.txt
>@@ -624,7 +624,9 @@ bindings/js/JSWebAnimationCustom.cpp
> bindings/js/JSWebGL2RenderingContextCustom.cpp
> bindings/js/JSWebGLRenderingContextCustom.cpp
> bindings/js/JSWebXRReferenceSpaceCustom.cpp
>+bindings/js/JSWebXRRigidTransformCustom.cpp
> bindings/js/JSWebXRSpaceCustom.cpp
>+bindings/js/JSWebXRViewCustom.cpp
> bindings/js/JSWindowProxy.cpp
> bindings/js/JSWorkerGlobalScopeBase.cpp
> bindings/js/JSWorkerGlobalScopeCustom.cpp
>diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>index f3685f956b6eb0261f49d522451bcd698873f0d5..80fedc37f78f03a7b7cb1ebc623da002d7260dc0 100644
>--- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>+++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
>@@ -6349,6 +6349,8 @@
> 		115CFA96208B952B001E6991 /* LayoutBox.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = LayoutBox.cpp; sourceTree = "<group>"; };
> 		1163F82124E5D59B000AB960 /* RenderTreeMutationDisallowedScope.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RenderTreeMutationDisallowedScope.h; sourceTree = "<group>"; };
> 		1163F82324E5D59B000AB960 /* RenderTreeMutationDisallowedScope.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = RenderTreeMutationDisallowedScope.cpp; sourceTree = "<group>"; };
>+		11648B41260A3F6C004AF1F2 /* JSWebXRRigidTransformCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSWebXRRigidTransformCustom.cpp; sourceTree = "<group>"; };
>+		11648B43260A3F6C004AF1F2 /* JSWebXRViewCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSWebXRViewCustom.cpp; sourceTree = "<group>"; };
> 		118B068625E41E510070BE4B /* OpenXRExtensions.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = OpenXRExtensions.cpp; sourceTree = "<group>"; };
> 		118B068825E41E520070BE4B /* OpenXRExtensions.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = OpenXRExtensions.h; sourceTree = "<group>"; };
> 		118B068925E41E520070BE4B /* OpenXRInstance.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = OpenXRInstance.cpp; sourceTree = "<group>"; };
>@@ -23065,6 +23067,8 @@
> 				A1677E242144532800A08C34 /* JSPaymentMethodChangeEventCustom.cpp */,
> 				A10D6E942144C99800FDD14D /* JSPaymentResponseCustom.cpp */,
> 				A85F22081430377D007CC884 /* JSPopStateEventCustom.cpp */,
>+				11648B41260A3F6C004AF1F2 /* JSWebXRRigidTransformCustom.cpp */,
>+				11648B43260A3F6C004AF1F2 /* JSWebXRViewCustom.cpp */,
> 				BC348BBD0DB7F531004ABAB9 /* JSXMLHttpRequestCustom.cpp */,
> 			);
> 			name = "Cached Attributes w/ Invalidation";
>diff --git a/Source/WebCore/bindings/js/JSWebXRRigidTransformCustom.cpp b/Source/WebCore/bindings/js/JSWebXRRigidTransformCustom.cpp
>new file mode 100644
>index 0000000000000000000000000000000000000000..0143a99969cf876304fd6e73bff80781f35b09db
>--- /dev/null
>+++ b/Source/WebCore/bindings/js/JSWebXRRigidTransformCustom.cpp
>@@ -0,0 +1,55 @@
>+/*
>+ * Copyright (C) 2021 Igalia S.L. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
>+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
>+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
>+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
>+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
>+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#include "config.h"
>+
>+#if ENABLE(WEBXR)
>+#include "JSWebXRRigidTransform.h"
>+
>+#include "WebXRRigidTransform.h"
>+
>+namespace WebCore {
>+using namespace JSC;
>+
>+JSC::JSValue JSWebXRRigidTransform::matrix(JSC::JSGlobalObject& lexicalGlobalObject) const
>+{
>+    auto throwScope = DECLARE_THROW_SCOPE(lexicalGlobalObject.vm());
>+    return cachedPropertyValue(lexicalGlobalObject, *this, wrapped().cachedMatrix(), [&] {
>+        JSC::JSValue matrix = toJS<IDLFloat32Array>(lexicalGlobalObject, *globalObject(), throwScope, wrapped().matrix());
>+        return matrix;
>+    });
>+}
>+
>+template<typename Visitor>
>+void JSWebXRRigidTransform::visitAdditionalChildren(Visitor& visitor)
>+{
>+    wrapped().cachedMatrix().visit(visitor);
>+}
>+
>+DEFINE_VISIT_ADDITIONAL_CHILDREN(JSWebXRRigidTransform);
>+
>+} // namespace WebCore
>+
>+#endif // ENABLE(WEBXR)
>diff --git a/Source/WebCore/bindings/js/JSWebXRViewCustom.cpp b/Source/WebCore/bindings/js/JSWebXRViewCustom.cpp
>new file mode 100644
>index 0000000000000000000000000000000000000000..1af4f8d6433991cdfea201ed10c9b78a5dbdcc00
>--- /dev/null
>+++ b/Source/WebCore/bindings/js/JSWebXRViewCustom.cpp
>@@ -0,0 +1,55 @@
>+/*
>+ * Copyright (C) 2021 Igalia S.L. All rights reserved.
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
>+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
>+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
>+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE INC. OR
>+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
>+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
>+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
>+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
>+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+#include "config.h"
>+
>+#if ENABLE(WEBXR)
>+#include "JSWebXRView.h"
>+
>+#include "WebXRView.h"
>+
>+namespace WebCore {
>+using namespace JSC;
>+
>+JSC::JSValue JSWebXRView::projectionMatrix(JSC::JSGlobalObject& lexicalGlobalObject) const
>+{
>+    auto throwScope = DECLARE_THROW_SCOPE(lexicalGlobalObject.vm());
>+    return cachedPropertyValue(lexicalGlobalObject, *this, wrapped().cachedProjectionMatrix(), [&] {
>+        JSC::JSValue matrix = toJS<IDLFloat32Array>(lexicalGlobalObject, *globalObject(), throwScope, wrapped().projectionMatrix());
>+        return matrix;
>+    });
>+}
>+
>+template<typename Visitor>
>+void JSWebXRView::visitAdditionalChildren(Visitor& visitor)
>+{
>+    wrapped().cachedProjectionMatrix().visit(visitor);
>+}
>+
>+DEFINE_VISIT_ADDITIONAL_CHILDREN(JSWebXRView);
>+
>+} // namespace WebCore
>+
>+#endif // ENABLE(WEBXR)
>diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
>index 656de1203bffc45218b43a472096553ed70f8362..261199f145f549fd595769c314169733e653be63 100644
>--- a/LayoutTests/ChangeLog
>+++ b/LayoutTests/ChangeLog
>@@ -1,3 +1,14 @@
>+2021-03-23  Imanol Fernandez  <ifernandez@igalia.com>
>+
>+        Implement cachedPropertyValue for WebXR [SameObject] attributes
>+        https://bugs.webkit.org/show_bug.cgi?id=223635
>+
>+        Reviewed by Chris Dumez.
>+
>+        Update WebXR [SameObject] related test expectations.
>+
>+        * platform/wpe/TestExpectations:
>+
> 2021-03-26  Dean Jackson  <dino@apple.com>
> 
>         Enable Metal ANGLE backend for WebGL
>diff --git a/LayoutTests/imported/w3c/ChangeLog b/LayoutTests/imported/w3c/ChangeLog
>index e7a81381e23633f3478136c11d25188b4a923097..b185bdfc003abafed6a2e18727e2e9d38a9bd021 100644
>--- a/LayoutTests/imported/w3c/ChangeLog
>+++ b/LayoutTests/imported/w3c/ChangeLog
>@@ -1,3 +1,17 @@
>+2021-03-23  Imanol Fernandez  <ifernandez@igalia.com>
>+
>+        Implement cachedPropertyValue for WebXR [SameObject] attributes
>+        https://bugs.webkit.org/show_bug.cgi?id=223635
>+
>+        Reviewed by Chris Dumez.
>+
>+        Update WebXR [SameObject] related test expectations.
>+
>+        * web-platform-tests/webxr/xrRigidTransform_sameObject.https-expected.txt: Added.
>+        * web-platform-tests/webxr/xrSession_sameObject.https-expected.txt: Added.
>+        * web-platform-tests/webxr/xrView_sameObject.https-expected.txt: Added.
>+        * web-platform-tests/webxr/xrViewerPose_views_sameObject.https-expected.txt: Added.
>+
> 2021-03-25  Antoine Quint  <graouts@webkit.org>
> 
>         Fix interpolation of the caret-color CSS property
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/webxr/xrRigidTransform_sameObject.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/webxr/xrRigidTransform_sameObject.https-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..9a5e71893d19b07ba712a17951f0eb83be0df9b9
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/webxr/xrRigidTransform_sameObject.https-expected.txt
>@@ -0,0 +1,3 @@
>+
>+PASS XRRigidTransform position and orientation meet [SameObject] requirements
>+
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_sameObject.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_sameObject.https-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..de4df93dc0ee6d40de657922cd9de2192602938e
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/webxr/xrSession_sameObject.https-expected.txt
>@@ -0,0 +1,3 @@
>+
>+PASS XRSession attributes meet [SameObject] requirement
>+
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_sameObject.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_sameObject.https-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..e9f50cb8a6c878ee81d66da943a24a0e3f198e66
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/webxr/xrView_sameObject.https-expected.txt
>@@ -0,0 +1,3 @@
>+
>+PASS XRView attributes meet [SameObject] requirement
>+
>diff --git a/LayoutTests/imported/w3c/web-platform-tests/webxr/xrViewerPose_views_sameObject.https-expected.txt b/LayoutTests/imported/w3c/web-platform-tests/webxr/xrViewerPose_views_sameObject.https-expected.txt
>new file mode 100644
>index 0000000000000000000000000000000000000000..f154e8d1dcec54815cd38b0e0c8d0520565a6c4c
>--- /dev/null
>+++ b/LayoutTests/imported/w3c/web-platform-tests/webxr/xrViewerPose_views_sameObject.https-expected.txt
>@@ -0,0 +1,3 @@
>+
>+PASS XRViewerPose.views meets [SameObject] requirement
>+
>diff --git a/LayoutTests/platform/wpe/TestExpectations b/LayoutTests/platform/wpe/TestExpectations
>index 0d3dc9efdc34e8490a61a2ff8571b81a744960d3..3d2a91ba5c83f52d0f0e2f2f4cc381a2980f4461 100644
>--- a/LayoutTests/platform/wpe/TestExpectations
>+++ b/LayoutTests/platform/wpe/TestExpectations
>@@ -665,6 +665,7 @@ imported/w3c/web-platform-tests/webxr/xrReferenceSpace_relationships.https.html
> imported/w3c/web-platform-tests/webxr/xrRigidTransform_constructor.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrRigidTransform_inverse.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrRigidTransform_matrix.https.html [ Pass ]
>+imported/w3c/web-platform-tests/webxr/xrRigidTransform_sameObject.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrSession_cancelAnimationFrame_invalidhandle.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrSession_end.https.html [ Pass ]
>@@ -676,7 +677,10 @@ imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_getViewerP
> imported/w3c/web-platform-tests/webxr/xrSession_requestAnimationFrame_timestamp.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrSession_requestReferenceSpace.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrSession_requestReferenceSpace_features.https.html [ Pass ]
>+imported/w3c/web-platform-tests/webxr/xrSession_sameObject.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrSession_viewer_referenceSpace.https.html [ Pass ]
>+imported/w3c/web-platform-tests/webxr/xrView_sameObject.https.html [ Pass ]
>+imported/w3c/web-platform-tests/webxr/xrViewerPose_views_sameObject.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrViewport_valid.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrWebGLLayer_constructor.https.html [ Pass ]
> imported/w3c/web-platform-tests/webxr/xrWebGLLayer_framebuffer_draw.https.html [ Pass ]

Actions: View | Formatted Diff | Diff

Attachments on bug 223635: 424019 | 424025 | 424363