Attachment 422484 Details for Bug 222357 – Patch

[patch] Patch

bug-222357-20210306124133.patch (text/plain), 2.22 KB, created by Rob Buis on 2021-03-06 03:41:35 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2021-03-06 03:41:35 PST

Size: 2.22 KB

patch

obsolete

>Subversion Revision: 273983
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 1aa8ec6a7fc5f2ce78e84effcc30e4cff48b0726..9d9cab6aae1d36d53e4b1b536a3766a6e7d128f8 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,16 @@
>+2021-03-06  Rob Buis  <rbuis@igalia.com>
>+
>+        Fix flex-aspect-ratio-025+26.html
>+        https://bugs.webkit.org/show_bug.cgi?id=222357
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        WIP.
>+
>+        * rendering/RenderFlexibleBox.cpp:
>+        (WebCore::RenderFlexibleBox::computeMainSizeFromAspectRatioUsing const):
>+        (WebCore::RenderFlexibleBox::computeInnerFlexBaseSizeForChild):
>+
> 2021-03-05  Simon Fraser  <simon.fraser@apple.com>
> 
>         sticky position incorrect behavior in table with dir=RTL
>diff --git a/Source/WebCore/rendering/RenderFlexibleBox.cpp b/Source/WebCore/rendering/RenderFlexibleBox.cpp
>index 9bc6362639fe12d5f4920ed87c26a59ea54ec0f1..b4fc16886fbf74a6ccc52d2de7ca336c47d08fc2 100644
>--- a/Source/WebCore/rendering/RenderFlexibleBox.cpp
>+++ b/Source/WebCore/rendering/RenderFlexibleBox.cpp
>@@ -801,16 +801,13 @@ LayoutUnit RenderFlexibleBox::computeMainSizeFromAspectRatioUsing(const RenderBo
>         return value;
>     };
> 
>+    if (crossSizeLength.isAuto() && childCrossSizeShouldUseContainerCrossSize(child))
>+        crossSizeLength = Length(LengthType::FillAvailable);
>+
>     Optional<LayoutUnit> crossSize;
>     if (crossSizeLength.isFixed())
>         crossSize = adjustForBoxSizing(child, crossSizeLength);
>-    else if (crossSizeLength.isAuto()) {
>-        ASSERT(childCrossSizeShouldUseContainerCrossSize(child));
>-        auto containerCrossSizeLength = isHorizontalFlow() ? style().height() : style().width();
>-        // Keep this sync'ed with childCrossSizeShouldUseContainerCrossSize().
>-        ASSERT(containerCrossSizeLength.isFixed());
>-        crossSize = valueForLength(containerCrossSizeLength, -1_lu);
>-    } else {
>+    else {
>         ASSERT(crossSizeLength.isPercentOrCalculated());
>         crossSize = mainAxisIsChildInlineAxis(child) ? child.computePercentageLogicalHeight(crossSizeLength) : adjustBorderBoxLogicalWidthForBoxSizing(valueForLength(crossSizeLength, contentWidth()), crossSizeLength.type());
>         if (!crossSize)

Actions: View | Formatted Diff | Diff

Attachments on bug 222357: 421407 | 421649 | 421775 | 421776 | 421915 | 422056 | 422071 | 422085 | 422206 | 422374 | 422484 | 422485 | 422492 | 422494 | 422500 | 422522 | 422523 | 422525 | 422560 | 422809 | 422811 | 429277 | 429282 | 429309 | 429875 | 430467 | 431546 | 432280 | 432480 | 432574 | 432596 | 433785 | 437454 | 437625