Attachment 421093 Details for Bug 221989 – Patch

[patch] Patch

bug-221989-20210220111013.patch (text/plain), 1.77 KB, created by Peng Liu on 2021-02-20 11:10:13 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Peng Liu

Created: 2021-02-20 11:10:13 PST

Size: 1.77 KB

patch

obsolete

>Subversion Revision: 273202
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index abbd244e004c228f174bde00ef824e3744749bfc..e0dae331daf83baff1439382c673602cb9dc8837 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,18 @@
>+2021-02-20  Peng Liu  <peng.liu6@apple.com>
>+
>+        [ BigSur Debug Wk 2 ] ASSERT NOT REACHED in WebCore::DisplayList::PaintFrameForMedia::apply
>+        https://bugs.webkit.org/show_bug.cgi?id=221989
>+        <rdar://problem/74403030>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        No new tests, this will fix a crash on debug bots.
>+
>+        * GPUProcess/graphics/RemoteRenderingBackend.cpp:
>+        (WebKit::RemoteRenderingBackend::applyMediaItem): When we cannot get the player, the player
>+        with the given identifier must have been destroyed. This function can return true to indicate
>+        that the item has been applied.
>+
> 2021-02-20  Wenson Hsieh  <wenson_hsieh@apple.com>
> 
>         Unreviewed, reverting r273115.
>diff --git a/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp b/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
>index b3eb6b696a93499377223d7928f9a0d299617f2a..0e63655d0521ab53f45ed40ace4eee17c9291a59 100644
>--- a/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
>+++ b/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
>@@ -123,7 +123,7 @@ bool RemoteRenderingBackend::applyMediaItem(DisplayList::ItemHandle item, Graphi
>     auto& mediaItem = item.get<DisplayList::PaintFrameForMedia>();
>     auto player = m_gpuConnectionToWebProcess->remoteMediaPlayerManagerProxy().mediaPlayer(mediaItem.identifier());
>     if (!player)
>-        return false;
>+        return true;
> 
>     context.paintFrameForMedia(*player, mediaItem.destination());
>     return true;

Actions: View | Formatted Diff | Diff

Attachments on bug 221989: 421093