Attachment 420374 Details for Bug 221920 – Revise the patch based on Eric's comment

[patch] Revise the patch based on Eric's comment

bug-221920-20210215143652.patch (text/plain), 4.17 KB, created by Peng Liu on 2021-02-15 14:36:53 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Peng Liu

Created: 2021-02-15 14:36:53 PST

Size: 4.17 KB

patch

obsolete

>Subversion Revision: 272880
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 3c86313295bb1351a97bcd5725ab030250dc3e32..1ef9f33b39db006b0ebd28750a31f2d73db0731f 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,15 @@
>+2021-02-15  Peng Liu  <peng.liu6@apple.com>
>+
>+        [GPUP] Ignore an IPC message if the message receiver has been destroyed
>+        https://bugs.webkit.org/show_bug.cgi?id=221920
>+
>+        Reviewed by Eric Carlson.
>+
>+        No new tests, fixing test crashes due to assertion failures.
>+
>+        * WebProcess/GPU/GPUProcessConnection.cpp:
>+        (WebKit::GPUProcessConnection::dispatchMessage):
>+
> 2021-02-15  Michael Catanzaro  <mcatanzaro@gnome.org>
> 
>         Fix -Wunused-variable warning
>diff --git a/Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp b/Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp
>index 447a21a4d5819ac8fdceed1e80876984a3837164..4abb6e3db062c581e307882745b34267a6934555 100644
>--- a/Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp
>+++ b/Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp
>@@ -32,14 +32,19 @@
> #include "GPUConnectionToWebProcessMessages.h"
> #include "LibWebRTCCodecs.h"
> #include "LibWebRTCCodecsMessages.h"
>+#include "Logging.h"
> #include "MediaPlayerPrivateRemoteMessages.h"
>+#include "MediaSourcePrivateRemoteMessages.h"
>+#include "RemoteAudioHardwareListenerMessages.h"
> #include "RemoteAudioSourceProviderManager.h"
> #include "RemoteCDMFactory.h"
> #include "RemoteCDMProxy.h"
> #include "RemoteLegacyCDMFactory.h"
> #include "RemoteMediaEngineConfigurationFactory.h"
> #include "RemoteMediaPlayerManager.h"
>+#include "RemoteRemoteCommandListenerMessages.h"
> #include "SampleBufferDisplayLayerMessages.h"
>+#include "SourceBufferPrivateRemoteMessages.h"
> #include "WebCoreArgumentCoders.h"
> #include "WebPage.h"
> #include "WebPageCreationParameters.h"
>@@ -160,12 +165,7 @@ bool GPUProcessConnection::dispatchMessage(IPC::Connection& connection, IPC::Dec
>         return true;
>     }
> #endif // PLATFORM(COCOA) && ENABLE(MEDIA_STREAM)
>-#if USE(AUDIO_SESSION)
>-    if (decoder.messageReceiverName() == Messages::RemoteAudioSession::messageReceiverName()) {
>-        // FIXME
>-        return true;
>-    }
>-#endif
>+
> #if ENABLE(ENCRYPTED_MEDIA)
>     if (decoder.messageReceiverName() == Messages::RemoteCDMInstanceSession::messageReceiverName()) {
>         WebProcess::singleton().supplement<RemoteCDMFactory>()->didReceiveSessionMessage(connection, decoder);
>@@ -177,10 +177,41 @@ bool GPUProcessConnection::dispatchMessage(IPC::Connection& connection, IPC::Dec
> 
>     // Skip messages intended for already removed messageReceiverMap() destinations.
> #if ENABLE(WEBGL)
>-    if (decoder.messageReceiverName() == Messages::RemoteGraphicsContextGLProxy::messageReceiverName())
>+    if (decoder.messageReceiverName() == Messages::RemoteGraphicsContextGLProxy::messageReceiverName()) {
>+        RELEASE_LOG_ERROR(WebGL, "The RemoteGraphicsContextGLProxy object has beed destroyed");
>+        return true;
>+    }
>+#endif
>+
>+#if USE(AUDIO_SESSION)
>+    if (decoder.messageReceiverName() == Messages::RemoteAudioSession::messageReceiverName()) {
>+        RELEASE_LOG_ERROR(Media, "The RemoteAudioSession object has beed destroyed");
>+        return true;
>+    }
>+#endif
>+
>+#if ENABLE(MEDIA_SOURCE)
>+    if (decoder.messageReceiverName() == Messages::MediaSourcePrivateRemote::messageReceiverName()) {
>+        RELEASE_LOG_ERROR(Media, "The MediaSourcePrivateRemote object has beed destroyed");
>         return true;
>+    }
>+
>+    if (decoder.messageReceiverName() == Messages::SourceBufferPrivateRemote::messageReceiverName()) {
>+        RELEASE_LOG_ERROR(Media, "The SourceBufferPrivateRemote object has beed destroyed");
>+        return true;
>+    }
> #endif
> 
>+    if (decoder.messageReceiverName() == Messages::RemoteAudioHardwareListener::messageReceiverName()) {
>+        RELEASE_LOG_ERROR(Media, "The RemoteAudioHardwareListener object has beed destroyed");
>+        return true;
>+    }
>+
>+    if (decoder.messageReceiverName() == Messages::RemoteRemoteCommandListener::messageReceiverName()) {
>+        RELEASE_LOG_ERROR(Media, "The RemoteRemoteCommandListener object has beed destroyed");
>+        return true;
>+    }
>+
>     return false;
> }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 221920: 420358 | 420374