Attachment 418983 Details for Bug 221252 – proposed patch

[patch] proposed patch

0001-rendering-Moved-assertion-that-was-blocking-the-rend.patch (text/plain), 2.01 KB, created by Eleni Maria Stea on 2021-02-02 05:03:54 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Eleni Maria Stea

Created: 2021-02-02 05:03:54 PST

Size: 2.01 KB

patch

obsolete

>From 8474a3b58af81be7c316d150b8524ac1452473ba Mon Sep 17 00:00:00 2001
>From: Eleni Maria Stea <estea@igalia.com>
>Date: Tue, 2 Feb 2021 13:25:36 +0200
>Subject: [PATCH] rendering: Moved assertion that was blocking the rendering in
> Debug mode
>
>willBeComposited can match needsToBeComposited only right after is set.
>If the check is performed later asynchronous events like scrolling
>overflow might have alter needsToBeComposited return value.
>
>Fix: https://bugs.webkit.org/show_bug.cgi?id=221252
>
>Please enter the commit message for your changes. Lines starting
>---
> Source/WebCore/rendering/RenderLayerCompositor.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Source/WebCore/rendering/RenderLayerCompositor.cpp b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>index 9c809478848c..0a43cf14f73e 100644
>--- a/Source/WebCore/rendering/RenderLayerCompositor.cpp
>+++ b/Source/WebCore/rendering/RenderLayerCompositor.cpp
>@@ -954,6 +954,8 @@ void RenderLayerCompositor::computeCompositingRequirements(RenderLayer* ancestor
>         willBeComposited = needsToBeComposited(layer, queryData);
>     }
> 
>+    ASSERT(willBeComposited == needsToBeComposited(layer, queryData));
>+
>     bool layerPaintsIntoProvidedBacking = false;
>     if (!willBeComposited && compositingState.subtreeIsCompositing && backingSharingState.backingProviderCandidate() && canBeComposited(layer) && backingProviderLayerCanIncludeLayer(*backingSharingState.backingProviderCandidate(), layer)) {
>         backingSharingState.appendSharingLayer(layer);
>@@ -1123,8 +1125,6 @@ void RenderLayerCompositor::computeCompositingRequirements(RenderLayer* ancestor
> #endif
>     }
> 
>-    ASSERT(willBeComposited == needsToBeComposited(layer, queryData));
>-
>     // Create or destroy backing here. However, we can't update geometry because layers above us may become composited
>     // during post-order traversal (e.g. for clipping).
>     if (updateBacking(layer, queryData, &backingSharingState, willBeComposited ? BackingRequired::Yes : BackingRequired::No)) {
>-- 
>2.30.0
>

Flags:

simon.fraser: review-

Actions: View | Formatted Diff | Diff

Attachments on bug 221252: 418983