Attachment 417881 Details for Bug 220224 – Patch

[patch] Patch

bug-220224-20210119184544.patch (text/plain), 1.61 KB, created by Rob Buis on 2021-01-19 09:45:45 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Rob Buis

Created: 2021-01-19 09:45:45 PST

Size: 1.61 KB

patch

obsolete

>Subversion Revision: 271595
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 2aaf2c489ad6bc03273a7756cea8498c7045c13d..b561c6ad391f2d39dc8bb49a0da7f6a11e0013a3 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,15 @@
>+2021-01-19  Rob Buis  <rbuis@igalia.com>
>+
>+        https://bugs.webkit.org/show_bug.cgi?id=220224
>+        https://bugs.webkit.org/show_bug.cgi?id=220224
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        USe std::clamp for clarity.
>+
>+        * rendering/RenderBox.cpp:
>+        (WebCore::RenderBox::constrainLogicalWidthInFragmentByMinMax const):
>+
> 2021-01-18  Andres Gonzalez  <andresg_22@apple.com>
> 
>         Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along.
>diff --git a/Source/WebCore/rendering/RenderBox.cpp b/Source/WebCore/rendering/RenderBox.cpp
>index 276c6344664228caca1c19e257bfa39419543411..9f0d670c393de9cbb0c18636a59e3d87bd33f4fb 100644
>--- a/Source/WebCore/rendering/RenderBox.cpp
>+++ b/Source/WebCore/rendering/RenderBox.cpp
>@@ -647,7 +647,7 @@ LayoutUnit RenderBox::constrainLogicalWidthInFragmentByMinMax(LayoutUnit logical
>     if (shouldComputeLogicalHeightFromAspectRatio()) {
>         LayoutUnit logicalMinWidth, logicalMaxWidth;
>         std::tie(logicalMinWidth, logicalMaxWidth) = computeMinMaxLogicalWidthFromAspectRatio();
>-        logicalWidth = std::max(logicalMinWidth, std::min(logicalWidth, logicalMaxWidth));
>+        logicalWidth = std::clamp(logicalWidth, logicalMinWidth, logicalMaxWidth);
>     }
> 
>     if (!styleToUse.logicalMaxWidth().isUndefined())

Actions: View | Formatted Diff | Diff

Attachments on bug 220224: 416893 | 417250 | 417257 | 417339 | 417342 | 417349 | 417615 | 417618 | 417619 | 417693 | 417881 | 417947