Attachment 415836 Details for Bug 219726 – Patch

[patch] Patch

bug-219726-20201210032738.patch (text/plain), 1.80 KB, created by Lauro Moura on 2020-12-09 22:27:39 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Lauro Moura

Created: 2020-12-09 22:27:39 PST

Size: 1.80 KB

patch

obsolete

>Subversion Revision: 270612
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 5cb1efd355dfefef2f23014aea270fe98cda0782..890eb6fbf93f9373ae9fb618d7beb3d40e2458dc 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2020-12-09  Lauro Moura  <lmoura@igalia.com>
>+
>+        [GTK] Fix EventSender wheel phase names
>+        Need the bug URL (OOPS!).
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        It was causing the events to be sent with 0 phase as the momentum
>+        phase switch overwrote it.
>+
>+        * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
>+        (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
>+
> 2020-12-09  John Wilander  <wilander@apple.com>
> 
>         PCM: Make JSON key names use underscores according to the W3C conversation
>diff --git a/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp b/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp
>index 94ef6106651acaa54bf8cdcd33aa4bff17835144..79154abfae51e0f4f7192576aa96f3b8ffde189e 100644
>--- a/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp
>+++ b/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp
>@@ -327,16 +327,16 @@ void EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases(int horizontal, i
>     WheelEventPhase eventMomentumPhase = WheelEventPhase::NoPhase;
>     switch (momentum) {
>     case 0:
>-        eventPhase = WheelEventPhase::NoPhase;
>+        eventMomentumPhase = WheelEventPhase::NoPhase;
>         break;
>     case 1:
>-        eventPhase = WheelEventPhase::Began;
>+        eventMomentumPhase = WheelEventPhase::Began;
>         break;
>     case 2:
>-        eventPhase = WheelEventPhase::Changed;
>+        eventMomentumPhase = WheelEventPhase::Changed;
>         break;
>     case 3:
>-        eventPhase = WheelEventPhase::Ended;
>+        eventMomentumPhase = WheelEventPhase::Ended;
>         break;
>     }
>

Actions: View | Formatted Diff | Diff

Attachments on bug 219726: 415836 | 415869