Attachment 414820 Details for Bug 219268 – Patch

[patch] Patch

bug-219268-20201124001524.patch (text/plain), 1.77 KB, created by Lauro Moura on 2020-11-23 19:15:25 PST

(hide)

Description:

Filename:

MIME Type:

Creator: Lauro Moura

Created: 2020-11-23 19:15:25 PST

Size: 1.77 KB

patch

obsolete

>Subversion Revision: 270165
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index e97769beb40afc5f8dcc47cb141f8c580503314c..71b6f8bf1dad196efcb7e7166c574c885b07dbf1 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2020-11-23  Lauro Moura  <lmoura@igalia.com>
>+
>+        [GTK4] Declare lambda return type to avoid build error deducing it
>+        https://bugs.webkit.org/show_bug.cgi?id=219268
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
>+        (WebKit::WebPopupMenuProxyGtk::createPopupMenu):
>+
> 2020-11-21  Sihui Liu  <sihui_liu@apple.com>
> 
>         Implement audio capture for SpeechRecognition on macOS
>diff --git a/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp b/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp
>index 2387fcdb2298191be7a73eeddca2d229fdde3941..a5238140f7caff9e45a73f669551e1d891fe1951 100644
>--- a/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp
>+++ b/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp
>@@ -255,7 +255,7 @@ void WebPopupMenuProxyGtk::createPopupMenu(const Vector<WebPopupItem>& items, in
>     gtk_widget_set_parent(m_popup, m_webView);
> 
>     auto* controller = gtk_event_controller_key_new();
>-    g_signal_connect_swapped(controller, "key-pressed", G_CALLBACK(+[](WebPopupMenuProxyGtk* popupMenu, unsigned keyval, unsigned, GdkModifierType, GtkEventController* controller) {
>+    g_signal_connect_swapped(controller, "key-pressed", G_CALLBACK(+[](WebPopupMenuProxyGtk* popupMenu, unsigned keyval, unsigned, GdkModifierType, GtkEventController* controller) -> bool {
>         auto* event = gtk_event_controller_get_current_event(controller);
>         if (popupMenu->typeAheadFind(keyval, gdk_event_get_time(event)))
>             return GDK_EVENT_STOP;

Actions: View | Formatted Diff | Diff

Attachments on bug 219268: 414820 | 414878