Attachment 412038 Details for Bug 217627 – Patch

[patch] Patch

bug-217627-20201021155137.patch (text/plain), 5.16 KB, created by Sam Weinig on 2020-10-21 15:51:37 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Weinig

Created: 2020-10-21 15:51:37 PDT

Size: 5.16 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 268842)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2020-10-21  Sam Weinig  <weinig@apple.com>
>+
>+        CSSStyleDeclaration includes descriptors
>+        https://bugs.webkit.org/show_bug.cgi?id=217627
>+        <rdar://problem/70449709>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        [WIP]
>+
>+        * css/CSSProperties.json:
>+        * css/CSSProperty.cpp:
>+        (WebCore::CSSProperty::isDescriptorOnly): Deleted.
>+        * css/makeprop.pl:
>+        (addProperty):
>+
> 2020-10-21  Chris Dumez  <cdumez@apple.com>
> 
>         Address post-landing review feedback from Sam Weinig for r268820.
>Index: Source/WebCore/css/CSSProperties.json
>===================================================================
>--- Source/WebCore/css/CSSProperties.json	(revision 268829)
>+++ Source/WebCore/css/CSSProperties.json	(working copy)
>@@ -116,6 +116,9 @@
>         "Whether the property needs to be applied at the end of its priority bucket",
>         "in CSS cascading order.",
>         "",
>+        "* descriptor-only:",
>+        "This property is only ever used as a descriptor.",
>+        "",
>         "* related-property:",
>         "Indicates the prefixed or unprefixed version of the same property,",
>         "e.g. -webkit-text-orientation has a related property text-orientation",
>@@ -3607,7 +3610,8 @@
>         },
>         "src": {
>             "codegen-properties": {
>-                "skip-builder": true
>+                "skip-builder": true,
>+                "descriptor-only": true
>             },
>             "specification": {
>                 "category": "css-fonts",
>@@ -4209,7 +4213,8 @@
>         },
>         "unicode-range": {
>             "codegen-properties": {
>-                "skip-builder": true
>+                "skip-builder": true,
>+                "descriptor-only": true
>             },
>             "specification": {
>                 "category": "css-fonts",
>@@ -4218,7 +4223,8 @@
>         },
>         "font-display": {
>             "codegen-properties": {
>-                "skip-builder": true
>+                "skip-builder": true,
>+                "descriptor-only": true
>             },
>             "specification": {
>                 "category": "css-fonts-4",
>Index: Source/WebCore/css/CSSProperty.cpp
>===================================================================
>--- Source/WebCore/css/CSSProperty.cpp	(revision 268829)
>+++ Source/WebCore/css/CSSProperty.cpp	(working copy)
>@@ -161,18 +161,6 @@ CSSPropertyID CSSProperty::resolveDirect
>     }
> }
> 
>-bool CSSProperty::isDescriptorOnly(CSSPropertyID propertyID)
>-{
>-    switch (propertyID) {
>-    case CSSPropertySrc:
>-    case CSSPropertyUnicodeRange:
>-    case CSSPropertyFontDisplay:
>-        return true;
>-    default:
>-        return false;
>-    }
>-}
>-
> bool CSSProperty::isDirectionAwareProperty(CSSPropertyID propertyID)
> {
>     switch (propertyID) {
>Index: Source/WebCore/css/makeprop.pl
>===================================================================
>--- Source/WebCore/css/makeprop.pl	(revision 268829)
>+++ Source/WebCore/css/makeprop.pl	(working copy)
>@@ -3,7 +3,7 @@
> #   This file is part of the WebKit project
> #
> #   Copyright (C) 1999 Waldo Bastian (bastian@kde.org)
>-#   Copyright (C) 2007-2018 Apple Inc. All rights reserved.
>+#   Copyright (C) 2007-2020 Apple Inc. All rights reserved.
> #   Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
> #   Copyright (C) 2010 Andras Becsi (abecsi@inf.u-szeged.hu), University of Szeged
> #   Copyright (C) 2013 Google Inc. All rights reserved.
>@@ -62,6 +62,7 @@ my %defines = map { $_ => 1 } split(/ /,
> 
> my @names;
> my @internalProprerties;
>+my @descriptorOnlyProperties;
> my %runtimeFlags;
> my %settingsFlags;
> my $numPredefinedProperties = 2;
>@@ -253,6 +254,8 @@ sub addProperty($$)
>                 } elsif ($codegenOptionName eq "internal-only") {
>                     # internal-only properties exist to make it easier to parse compound properties (e.g. background-repeat) as if they were shorthands.
>                     push @internalProprerties, $name
>+                } elsif ($codegenOptionName eq "descriptor-only") {
>+                    push @descriptorOnlyProperties, $name
>                 } elsif ($codegenOptionName eq "runtime-flag") {
>                     $runtimeFlags{$name} = $codegenProperties->{"runtime-flag"};
>                 } elsif ($codegenOptionName eq "settings-flag") {
>@@ -547,6 +550,22 @@ print GPERF << "EOF";
>     }
> }
> 
>+bool CSSProperty::isDescriptorOnly(CSSPropertyID propertyID)
>+{
>+    switch (propertyID) {
>+EOF
>+
>+foreach my $name (sort @descriptorOnlyProperties) {
>+    print GPERF "    case CSSPropertyID::CSSProperty" . $nameToId{$name} . ":\n";
>+}
>+
>+print GPERF << "EOF";
>+        return true;
>+    default:
>+        return false;
>+    }
>+}
>+
> } // namespace WebCore
> 
> IGNORE_WARNINGS_END
>@@ -1392,7 +1411,7 @@ sub cssPropertyToIDLAttribute($$$)
> 
> my %namesAndAliasesToName;
> foreach my $name (@names) {
>-    if (grep { $_ eq $name } @internalProprerties) {
>+    if (grep { $_ eq $name } (@internalProprerties, @descriptorOnlyProperties)) {
>         next;
>     }
>     $namesAndAliasesToName{$name} = $name;

Flags:

ews-feeder: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 217627: 412038