Attachment 411624 Details for Bug 217849 – Patch

[patch] Patch

bug-217849-20201017002120.patch (text/plain), 4.96 KB, created by Antoine Quint on 2020-10-16 15:21:22 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antoine Quint

Created: 2020-10-16 15:21:22 PDT

Size: 4.96 KB

patch

obsolete

>Subversion Revision: 268547
>diff --git a/Source/WTF/ChangeLog b/Source/WTF/ChangeLog
>index 376f6633eb530b4d684df203ce665bd1ba9178cc..f12148b806e449d98cf4768234fcb78bbb9f28f7 100644
>--- a/Source/WTF/ChangeLog
>+++ b/Source/WTF/ChangeLog
>@@ -1,3 +1,13 @@
>+2020-10-16  Antoine Quint  <graouts@webkit.org>
>+
>+        Enable individual CSS transform properties by default
>+        https://bugs.webkit.org/show_bug.cgi?id=217849
>+        <rdar://problem/70052493>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Scripts/Preferences/WebPreferencesExperimental.yaml:
>+
> 2020-10-15  David Kilzer  <ddkilzer@apple.com>
> 
>         WeakObjCPtr.h is not safe to include in C++ source files
>diff --git a/Source/WebKitLegacy/win/ChangeLog b/Source/WebKitLegacy/win/ChangeLog
>index d8890d7087371f2603febbb27c7dbe5df0b13cfa..1baee5bc0168abd681ef8104107ba6d1b3913d27 100644
>--- a/Source/WebKitLegacy/win/ChangeLog
>+++ b/Source/WebKitLegacy/win/ChangeLog
>@@ -1,3 +1,14 @@
>+2020-10-16  Antoine Quint  <graouts@webkit.org>
>+
>+        Enable individual CSS transform properties by default
>+        https://bugs.webkit.org/show_bug.cgi?id=217849
>+        <rdar://problem/70052493>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebPreferences.cpp:
>+        (WebPreferences::initializeDefaultSettings):
>+
> 2020-10-13  Simon Fraser  <simon.fraser@apple.com>
> 
>         Plumb OptionSet<WheelEventProcessingSteps> through the wheel event handling code
>diff --git a/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml b/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
>index 4731bcf7c7a1a3c6d745b4860c8ca483f4a12eea..07c7d765d02f4916fe68bf513739a4d4db0c5587 100644
>--- a/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
>+++ b/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml
>@@ -132,12 +132,11 @@ CSSIndividualTransformPropertiesEnabled:
>   humanReadableDescription: "Support for the translate, scale and rotate CSS properties"
>   defaultValue:
>     WebKitLegacy:
>-      default: false
>+      default: true
>     WebKit:
>-      "ENABLE(EXPERIMENTAL_FEATURES)" : true
>-      default: false
>+      default: true
>     WebCore:
>-      default: false
>+      default: true
> 
> CSSOMViewSmoothScrollingEnabled:
>   type: bool
>diff --git a/Source/WebKitLegacy/win/WebPreferences.cpp b/Source/WebKitLegacy/win/WebPreferences.cpp
>index e097165cd5550677cc99276d1485155ef557b0a5..05a1cc2f10fdf76fe8fdbbee64a66d3faa01bab1 100644
>--- a/Source/WebKitLegacy/win/WebPreferences.cpp
>+++ b/Source/WebKitLegacy/win/WebPreferences.cpp
>@@ -345,7 +345,7 @@ void WebPreferences::initializeDefaultSettings()
> 
>     CFDictionaryAddValue(defaults, CFSTR(WebKitWebSQLEnabledPreferenceKey), kCFBooleanFalse);
> 
>-    CFDictionaryAddValue(defaults, CFSTR(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey), kCFBooleanFalse);
>+    CFDictionaryAddValue(defaults, CFSTR(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey), kCFBooleanTrue);
> 
>     defaultSettings = defaults;
> #endif
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 00772bbfd4b5694e183829b26e9f40c54d3c5a63..a73cf619406630d75fa858ba8b14f28344798f07 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2020-10-16  Antoine Quint  <graouts@webkit.org>
>+
>+        Enable individual CSS transform properties by default
>+        https://bugs.webkit.org/show_bug.cgi?id=217849
>+        <rdar://problem/70052493>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * DumpRenderTree/mac/DumpRenderTree.mm:
>+        (enableExperimentalFeatures):
>+        * DumpRenderTree/win/DumpRenderTree.cpp:
>+        (enableExperimentalFeatures):
>+
> 2020-10-15  Lauro Moura  <lmoura@igalia.com>
> 
>         [Flatpak SDK] Check for installed packages in setup_buildir
>diff --git a/Tools/DumpRenderTree/mac/DumpRenderTree.mm b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>index 3e530f8164717fa8f9bd876679b0e7120709b781..7ba9083ef13e911026959fdc54f04fe0156bd046 100644
>--- a/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>+++ b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>@@ -840,7 +840,6 @@ static void enableExperimentalFeatures(WebPreferences* preferences)
>     [preferences setLinkPreloadResponsiveImagesEnabled:YES];
>     [preferences setAspectRatioOfImgFromWidthAndHeightEnabled:YES];
>     [preferences setCSSOMViewSmoothScrollingEnabled:YES];
>-    [preferences setCSSIndividualTransformPropertiesEnabled:YES];
>     [preferences setAudioWorkletEnabled:YES];
> }
> 
>diff --git a/Tools/DumpRenderTree/win/DumpRenderTree.cpp b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>index 50240d5964c6ed39942132bd6cadc5cd848e0c2c..97d3512afb6e922c0de245d5dab2cc41a08bead7 100644
>--- a/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>+++ b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>@@ -814,7 +814,6 @@ static void enableExperimentalFeatures(IWebPreferences* preferences)
>     // FIXME: WebGL2
>     // FIXME: WebRTC
>     prefsPrivate->setCSSOMViewSmoothScrollingEnabled(TRUE);
>-    prefsPrivate->setCSSIndividualTransformPropertiesEnabled(TRUE);
> }
> 
> static void resetWebPreferencesToConsistentValues(IWebPreferences* preferences)

Flags:

dino: review+

Actions: View | Formatted Diff | Diff

Attachments on bug 217849: 411624