Attachment 409689 Details for Bug 216271 – Patch

[patch] Patch

bug-216271-20200925161405.patch (text/plain), 14.28 KB, created by Antoine Quint on 2020-09-25 07:14:06 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antoine Quint

Created: 2020-09-25 07:14:06 PDT

Size: 14.28 KB

patch

obsolete

>Subversion Revision: 267559
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 248d2547a92008e688210827b195542c9f91d26a..4d1cdd98459c4b4a4cbbb119b6fa5771a742bc75 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,13 @@
>+2020-09-25  Antoine Quint  <graouts@webkit.org>
>+
>+        Add an experimental feature flag for CSS individual transform properties
>+        https://bugs.webkit.org/show_bug.cgi?id=216271
>+        <rdar://problem/68914539>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * page/Settings.yaml:
>+
> 2020-09-24  Zalan Bujtas  <zalan@apple.com>
> 
>         [LFC][IFC] Add helper functions to create LineBox::InlineBox objects for inline level boxes.
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index c6c3494fe1470376f169fb223ca7b32efaff1c01..ab75865ccee5b1db89eef769e93ad126a91ec089 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,13 @@
>+2020-09-25  Antoine Quint  <graouts@webkit.org>
>+
>+        Add an experimental feature flag for CSS individual transform properties
>+        https://bugs.webkit.org/show_bug.cgi?id=216271
>+        <rdar://problem/68914539>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferencesExperimental.yaml:
>+
> 2020-09-24  Brian Burg  <bburg@apple.com>
> 
>         REGRESSION(iOS WebDriver): action chains with 'Touch' pointerType don't work on Mac
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index 05f0941a906234475e64fe83ea7531dfedb0a55e..053685c59f238fcb3efdf62e151aea9cf6c7cdcf 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,19 @@
>+2020-09-25  Antoine Quint  <graouts@webkit.org>
>+
>+        Add an experimental feature flag for CSS individual transform properties
>+        https://bugs.webkit.org/show_bug.cgi?id=216271
>+        <rdar://problem/68914539>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebView/WebPreferenceKeysPrivate.h:
>+        * WebView/WebPreferences.mm:
>+        (-[WebPreferences setCSSIndividualTransformPropertiesEnabled:]):
>+        (-[WebPreferences cssIndividualTransformPropertiesEnabled]):
>+        * WebView/WebPreferencesPrivate.h:
>+        * WebView/WebView.mm:
>+        (-[WebView _preferencesChanged:]):
>+
> 2020-09-23  Peng Liu  <peng.liu6@apple.com>
> 
>         Add feature flags for GPU Process features
>diff --git a/Source/WebKitLegacy/win/ChangeLog b/Source/WebKitLegacy/win/ChangeLog
>index 8302718b4730e5a471bcdc010acf081ba86f38e6..ff3f6e75f1dcd4baeb4865c1a2482bbaec4327aa 100644
>--- a/Source/WebKitLegacy/win/ChangeLog
>+++ b/Source/WebKitLegacy/win/ChangeLog
>@@ -1,3 +1,21 @@
>+2020-09-25  Antoine Quint  <graouts@webkit.org>
>+
>+        Add an experimental feature flag for CSS individual transform properties
>+        https://bugs.webkit.org/show_bug.cgi?id=216271
>+        <rdar://problem/68914539>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Interfaces/IWebPreferencesPrivate.idl:
>+        * WebPreferenceKeysPrivate.h:
>+        * WebPreferences.cpp:
>+        (WebPreferences::initializeDefaultSettings):
>+        (WebPreferences::CSSIndividualTransformPropertiesEnabled):
>+        (WebPreferences::setCSSIndividualTransformPropertiesEnabled):
>+        * WebPreferences.h:
>+        * WebView.cpp:
>+        (WebView::notifyPreferencesChanged):
>+
> 2020-09-17  Sam Weinig  <weinig@apple.com>
> 
>         Remove runtime setting for enabling/disabling the UserTiming and ResourceTiming APIs
>diff --git a/Source/WebCore/page/Settings.yaml b/Source/WebCore/page/Settings.yaml
>index 7bdb08ace7951241cd890ba1f8726ad484b6e49c..7cd5df10ffd10ff73d493be1c09a819d24526405 100644
>--- a/Source/WebCore/page/Settings.yaml
>+++ b/Source/WebCore/page/Settings.yaml
>@@ -1120,3 +1120,6 @@ shouldUseServiceWorkerShortTimeout:
> # Clients should use per-navigation "allowsContentJavaScript" policies instead
> scriptMarkupEnabled:
>   initial: true
>+
>+cssIndividualTransformPropertiesEnabled:
>+  initial: false
>diff --git a/Source/WebKit/Shared/WebPreferencesExperimental.yaml b/Source/WebKit/Shared/WebPreferencesExperimental.yaml
>index 3313d8975dbf3aaf81eab9f08de872dbacff76e9..fa1b7f143ecda2e53a60b316efdf911045df20af 100644
>--- a/Source/WebKit/Shared/WebPreferencesExperimental.yaml
>+++ b/Source/WebKit/Shared/WebPreferencesExperimental.yaml
>@@ -544,3 +544,9 @@ DisableMediaExperiencePIDInheritance:
>   humanReadableName: "Disable Media Experience PID Inheritance"
>   humanReadableDescription: "Disable Media Experience PID Inheritance"
>   condition: HAVE(CELESTIAL)
>+
>+CSSIndividualTransformPropertiesEnabled:
>+  type: bool
>+  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>+  humanReadableName: "CSS Individual Transform Properties"
>+  humanReadableDescription: "Support for the translate, scale and rotate CSS properties"
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>index c438aea427e9e0a516a05e034579831990f28943..42b592f95774cfdf5f2c3c097a41d1f957a5c588 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>@@ -283,7 +283,7 @@
> #define WebKitLinkPreloadResponsiveImagesEnabledPreferenceKey @"WebKitLinkPreloadResponsiveImagesEnabled"
> #define WebKitDebugInAppBrowserPrivacyEnabledPreferenceKey @"WebKitDebugInAppBrowserPrivacyEnabled"
> #define WebKitAspectRatioOfImgFromWidthAndHeightEnabledPreferenceKey @"WebKitAspectRatioOfImgFromWidthAndHeightEnabled"
>-
>+#define WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey @"WebKitCSSIndividualTransformPropertiesEnabled"
> 
> // The preference keys below this point are deprecated and have no effect. They should
> // be removed when it is considered safe to do so.
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>index 1020ce25d05a0eae12947051e31dd2d28718afba..825047baf7c88f636aefcedd0ce56fc57078670e 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>@@ -3603,6 +3603,16 @@ - (void)setUserGesturePromisePropagationEnabled:(BOOL)flag
>     [self _setBoolValue:flag forKey:WebKitUserGesturePromisePropagationEnabledPreferenceKey];
> }
> 
>+- (void)setCSSIndividualTransformPropertiesEnabled:(BOOL)flag
>+{
>+    [self _setBoolValue:flag forKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
>+}
>+
>+- (BOOL)cssIndividualTransformPropertiesEnabled
>+{
>+    return [self _boolValueForKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
>+}
>+
> @end
> 
> @implementation WebPreferences (WebInternal)
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>index f3539ab7661d33a31418292ea3357a54ec8d461f..5ce84612f95c31e05138bac9ec0acd3de3196d24 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>@@ -627,6 +627,9 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification WEBKIT_DEPR
> - (void)setUserGesturePromisePropagationEnabled:(BOOL)flag;
> - (BOOL)userGesturePromisePropagationEnabled;
> 
>+- (void)setCSSIndividualTransformPropertiesEnabled:(BOOL)flag;
>+- (BOOL)cssIndividualTransformPropertiesEnabled;
>+
> @property (nonatomic) BOOL visualViewportAPIEnabled;
> @property (nonatomic) BOOL CSSOMViewScrollingAPIEnabled;
> @property (nonatomic) BOOL CSSOMViewSmoothScrollingEnabled;
>diff --git a/Source/WebKitLegacy/mac/WebView/WebView.mm b/Source/WebKitLegacy/mac/WebView/WebView.mm
>index eb4aff124e724318317965d255ea74f9fc508c23..47c2a7cfc93220751d4494e4f502c7b1e3ba8ff6 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebView.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebView.mm
>@@ -3454,6 +3454,8 @@ - (void)_preferencesChanged:(WebPreferences *)preferences
>     settings.setResizeObserverEnabled([preferences resizeObserverEnabled]);
> #endif
>     settings.setAspectRatioOfImgFromWidthAndHeightEnabled([preferences aspectRatioOfImgFromWidthAndHeightEnabled]);
>+
>+    settings.setCSSIndividualTransformPropertiesEnabled([preferences cssIndividualTransformPropertiesEnabled]);
> }
> 
> static inline IMP getMethod(id o, SEL s)
>diff --git a/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl b/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl
>index b0bd05f250582e147a6a7fbda3b6dbf4b6ab6087..213a39d09f363f80abbb0f635a35d96dc4ef45e1 100644
>--- a/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl
>+++ b/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl
>@@ -265,4 +265,6 @@ interface IWebPreferencesPrivate8 : IWebPreferencesPrivate7
>     HRESULT setAllowTopNavigationToDataURLs([in] BOOL enabled);
>     HRESULT modernUnprefixedWebAudioEnabled([out, retval] BOOL* enabled);
>     HRESULT setModernUnprefixedWebAudioEnabled([in] BOOL enabled);
>+    HRESULT CSSIndividualTransformPropertiesEnabled([out, retval] BOOL* enabled);
>+    HRESULT setCSSIndividualTransformPropertiesEnabled([in] BOOL enabled);
> }
>diff --git a/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h b/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
>index 9217b85e497da13da7682295b2de762a2de7165d..a917b64ef8c83d5949c5feb829910c5d4bfd6b84 100644
>--- a/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
>+++ b/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
>@@ -227,3 +227,5 @@
> #define WebKitAspectRatioOfImgFromWidthAndHeightEnabledPreferenceKey "WebKitAspectRatioOfImgFromWidthAndHeightEnabled"
> 
> #define WebKitWebSQLEnabledPreferenceKey "WebKitWebSQLEnabled"
>+
>+#define WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey "WebKitCSSIndividualTransformPropertiesEnabled"
>diff --git a/Source/WebKitLegacy/win/WebPreferences.cpp b/Source/WebKitLegacy/win/WebPreferences.cpp
>index 8397c19e07845d4718090908b9bbaf7ecb68bcd8..36b65758f5a2f4cb8467c78c496049244148a8d1 100644
>--- a/Source/WebKitLegacy/win/WebPreferences.cpp
>+++ b/Source/WebKitLegacy/win/WebPreferences.cpp
>@@ -343,6 +343,8 @@ void WebPreferences::initializeDefaultSettings()
> 
>     CFDictionaryAddValue(defaults, CFSTR(WebKitWebSQLEnabledPreferenceKey), kCFBooleanFalse);
> 
>+    CFDictionaryAddValue(defaults, CFSTR(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey), kCFBooleanFalse);
>+
>     defaultSettings = defaults;
> #endif
> }
>@@ -2466,3 +2468,17 @@ HRESULT WebPreferences::setModernUnprefixedWebAudioEnabled(BOOL enabled)
>     setBoolValue(WebKitWebAudioEnabledPreferenceKey, enabled);
>     return S_OK;
> }
>+
>+HRESULT WebPreferences::CSSIndividualTransformPropertiesEnabled(_Out_ BOOL* enabled)
>+{
>+    if (!enabled)
>+        return E_POINTER;
>+    *enabled = boolValueForKey(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey);
>+    return S_OK;
>+}
>+
>+HRESULT WebPreferences::setCSSIndividualTransformPropertiesEnabled(BOOL enabled)
>+{
>+    setBoolValue(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey, enabled);
>+    return S_OK;
>+}
>diff --git a/Source/WebKitLegacy/win/WebPreferences.h b/Source/WebKitLegacy/win/WebPreferences.h
>index 212905cb1ba6009403869539178a3fea703a38e8..3a880b2cdc7eb8a6846d45fe069b83e9df6a2457 100644
>--- a/Source/WebKitLegacy/win/WebPreferences.h
>+++ b/Source/WebKitLegacy/win/WebPreferences.h
>@@ -303,6 +303,8 @@ public:
>     virtual HRESULT STDMETHODCALLTYPE setAllowTopNavigationToDataURLs(BOOL);
>     virtual HRESULT STDMETHODCALLTYPE modernUnprefixedWebAudioEnabled(_Out_ BOOL*);
>     virtual HRESULT STDMETHODCALLTYPE setModernUnprefixedWebAudioEnabled(BOOL);
>+    virtual HRESULT STDMETHODCALLTYPE CSSIndividualTransformPropertiesEnabled(_Out_ BOOL*);
>+    virtual HRESULT STDMETHODCALLTYPE setCSSIndividualTransformPropertiesEnabled(BOOL);
> 
>     // WebPreferences
> 
>diff --git a/Source/WebKitLegacy/win/WebView.cpp b/Source/WebKitLegacy/win/WebView.cpp
>index 99fdb26b3f58b998004ed620a7492a3c12dbb7b1..f0ec1218f8b5f458e4167403a2cb241314c0a690 100644
>--- a/Source/WebKitLegacy/win/WebView.cpp
>+++ b/Source/WebKitLegacy/win/WebView.cpp
>@@ -5304,6 +5304,11 @@ HRESULT WebView::notifyPreferencesChanged(IWebNotification* notification)
>         return hr;
>     settings.setCSSOMViewSmoothScrollingEnabled(!!enabled);
> 
>+    hr = preferences->CSSIndividualTransformPropertiesEnabled(&enabled);
>+    if (FAILED(hr))
>+        return hr;
>+    settings.setCSSIndividualTransformPropertiesEnabled(!!enabled);
>+
>     hr = preferences->privateBrowsingEnabled(&enabled);
>     if (FAILED(hr))
>         return hr;
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index 6bc9cb9e4dc42c511e8bb8b450c9d0c7ef412fe5..746ebeb450d22d3f3954b1a56dc1a9d3a8e82b7c 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,16 @@
>+2020-09-25  Antoine Quint  <graouts@webkit.org>
>+
>+        Add an experimental feature flag for CSS individual transform properties
>+        https://bugs.webkit.org/show_bug.cgi?id=216271
>+        <rdar://problem/68914539>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * DumpRenderTree/mac/DumpRenderTree.mm:
>+        (enableExperimentalFeatures):
>+        * DumpRenderTree/win/DumpRenderTree.cpp:
>+        (enableExperimentalFeatures):
>+
> 2020-09-24  Kate Cheney  <katherine_cheney@apple.com>
> 
>         InAppBrowserPrivacy HTTPCookie tests incorrectly use the IsInAppBrowserPrivacyEnabled NSUserDefaults value
>diff --git a/Tools/DumpRenderTree/mac/DumpRenderTree.mm b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>index 010e2688835b01220ec97264db4bd24132cf6a8a..b7f181277c6995009a17218b4e743572708b336c 100644
>--- a/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>+++ b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>@@ -837,6 +837,7 @@ static void enableExperimentalFeatures(WebPreferences* preferences)
>     [preferences setLinkPreloadResponsiveImagesEnabled:YES];
>     [preferences setAspectRatioOfImgFromWidthAndHeightEnabled:YES];
>     [preferences setCSSOMViewSmoothScrollingEnabled:YES];
>+    [preferences setCSSIndividualTransformPropertiesEnabled:YES];
> }
> 
> // Called before each test.
>diff --git a/Tools/DumpRenderTree/win/DumpRenderTree.cpp b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>index 7aca947892b89d1da5f6236ddaa4653ec40af212..6aefc25e5583750e7e5e3dcebfb53f71f170582a 100644
>--- a/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>+++ b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>@@ -804,6 +804,7 @@ static void enableExperimentalFeatures(IWebPreferences* preferences)
>     // FIXME: WebGL2
>     // FIXME: WebRTC
>     prefsPrivate->setCSSOMViewSmoothScrollingEnabled(TRUE);
>+    prefsPrivate->setCSSIndividualTransformPropertiesEnabled(TRUE);
> }
> 
> static void resetWebPreferencesToConsistentValues(IWebPreferences* preferences)

Flags:

ews-feeder: commit-queue-

Actions: View | Formatted Diff | Diff

Attachments on bug 216271: 408222 | 408231 | 409669 | 409689 | 409696 | 409700 | 409701 | 409712 | 409714 | 409718 | 409731 | 409732