Attachment 408783 Details for Bug 216518 – Patch

[patch] Patch

bug-216518-20200914201325.patch (text/plain), 13.35 KB, created by Sam Weinig on 2020-09-14 20:13:26 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Weinig

Created: 2020-09-14 20:13:26 PDT

Size: 13.35 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 267069)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2020-09-14  Sam Weinig  <weinig@apple.com>
>+
>+        Remove runtime setting for enabling/disabling custom elements
>+        https://bugs.webkit.org/show_bug.cgi?id=216518
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove runtime setting for enabling/disabling custom elements. There is no
>+        reason one need to disable it now, and it has been on by default for
>+        a long enough time.
>+
>+        * dom/CustomElementRegistry.idl:
>+        * dom/Document.cpp:
>+        (WebCore::createUpgradeCandidateElement):
>+        * page/DOMWindow.idl:
>+        * page/Settings.yaml:
>+
> 2020-09-14  Sam Weinig  <weinig@apple.com>
> 
>         Remove runtime setting for enabling/disabling ShadowDOM
>Index: Source/WebCore/dom/CustomElementRegistry.idl
>===================================================================
>--- Source/WebCore/dom/CustomElementRegistry.idl	(revision 267069)
>+++ Source/WebCore/dom/CustomElementRegistry.idl	(working copy)
>@@ -24,7 +24,6 @@
> */
> 
> [
>-    EnabledBySetting=CustomElements,
>     GenerateIsReachable=ImplScriptExecutionContext,
>     JSGenerateToNativeObject,
> ] interface CustomElementRegistry {
>Index: Source/WebCore/dom/Document.cpp
>===================================================================
>--- Source/WebCore/dom/Document.cpp	(revision 267069)
>+++ Source/WebCore/dom/Document.cpp	(working copy)
>@@ -950,8 +950,7 @@ void Document::childrenChanged(const Chi
> 
> static ALWAYS_INLINE Ref<HTMLElement> createUpgradeCandidateElement(Document& document, const QualifiedName& name)
> {
>-    if (!document.settings().customElementsEnabled()
>-        || Document::validateCustomElementName(name.localName()) != CustomElementNameValidationStatus::Valid)
>+    if (Document::validateCustomElementName(name.localName()) != CustomElementNameValidationStatus::Valid)
>         return HTMLUnknownElement::create(name, document);
> 
>     auto element = HTMLElement::create(name, document);
>Index: Source/WebCore/page/DOMWindow.idl
>===================================================================
>--- Source/WebCore/page/DOMWindow.idl	(revision 267069)
>+++ Source/WebCore/page/DOMWindow.idl	(working copy)
>@@ -57,7 +57,7 @@ typedef USVString CSSOMString;
>     attribute DOMString name;
>     [DoNotCheckSecurity, PutForwards=href, LegacyUnforgeable] readonly attribute Location location;
>     readonly attribute History history;
>-    [EnabledBySetting=CustomElements, ImplementedAs=ensureCustomElementRegistry] readonly attribute CustomElementRegistry customElements;
>+    [ImplementedAs=ensureCustomElementRegistry] readonly attribute CustomElementRegistry customElements;
>     [Replaceable] readonly attribute BarProp locationbar;
>     [Replaceable] readonly attribute BarProp menubar;
>     [Replaceable] readonly attribute BarProp personalbar;
>Index: Source/WebCore/page/Settings.yaml
>===================================================================
>--- Source/WebCore/page/Settings.yaml	(revision 267069)
>+++ Source/WebCore/page/Settings.yaml	(working copy)
>@@ -1002,9 +1002,6 @@ lazyImageLoadingEnabled:
> referrerPolicyAttributeEnabled:
>   initial: true
> 
>-customElementsEnabled:
>-  initial: true
>-
> dataTransferItemsEnabled:
>   initial: false
> 
>Index: Source/WebKit/ChangeLog
>===================================================================
>--- Source/WebKit/ChangeLog	(revision 267069)
>+++ Source/WebKit/ChangeLog	(working copy)
>@@ -1,3 +1,16 @@
>+2020-09-14  Sam Weinig  <weinig@apple.com>
>+
>+        Remove runtime setting for enabling/disabling custom elements
>+        https://bugs.webkit.org/show_bug.cgi?id=216518
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove runtime setting for enabling/disabling custom elements. There is no
>+        reason one need to disable it now, and it has been on by default for
>+        a long enough time.
>+
>+        * Shared/WebPreferences.yaml:
>+
> 2020-09-14  Sam Weinig  <weinig@apple.com>
> 
>         Remove runtime setting for enabling/disabling ShadowDOM
>Index: Source/WebKit/Shared/WebPreferences.yaml
>===================================================================
>--- Source/WebKit/Shared/WebPreferences.yaml	(revision 267069)
>+++ Source/WebKit/Shared/WebPreferences.yaml	(working copy)
>@@ -814,10 +814,6 @@ AnimatedImageAsyncDecodingEnabled:
>   type: bool
>   defaultValue: true
> 
>-CustomElementsEnabled:
>-  type: bool
>-  defaultValue: true
>-
> MenuItemElementEnabled:
>   type: bool
>   defaultValue: false
>Index: Source/WebKitLegacy/mac/ChangeLog
>===================================================================
>--- Source/WebKitLegacy/mac/ChangeLog	(revision 267069)
>+++ Source/WebKitLegacy/mac/ChangeLog	(working copy)
>@@ -1,3 +1,21 @@
>+2020-09-14  Sam Weinig  <weinig@apple.com>
>+
>+        Remove runtime setting for enabling/disabling custom elements
>+        https://bugs.webkit.org/show_bug.cgi?id=216518
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove runtime setting for enabling/disabling custom elements. There is no
>+        reason one need to disable it now, and it has been on by default for
>+        a long enough time.
>+
>+        * WebView/WebPreferenceKeysPrivate.h:
>+        * WebView/WebPreferences.mm:
>+        (+[WebPreferences initialize]):
>+        (-[WebPreferences setCustomElementsEnabled:]):
>+        (-[WebPreferences customElementsEnabled]):
>+        * WebView/WebPreferencesPrivate.h:
>+
> 2020-09-14  Sam Weinig  <weinig@apple.com>
> 
>         Remove runtime setting for enabling/disabling ShadowDOM
>Index: Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>===================================================================
>--- Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h	(revision 267069)
>+++ Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h	(working copy)
>@@ -177,7 +177,6 @@
> #define WebKitHighlightAPIEnabledPreferenceKey @"WebKitHighlightAPIEnabled"
> #define WebKitServiceControlsEnabledPreferenceKey @"WebKitServiceControlsEnabled"
> #define WebKitMediaKeysStorageDirectoryKey @"WebKitMediaKeysStorageDirectory"
>-#define WebKitCustomElementsEnabledPreferenceKey @"WebKitCustomElementsEnabled"
> #define WebKitDataTransferItemsEnabledPreferenceKey @"WebKitDataTransferItemsEnabled"
> #define WebKitCustomPasteboardDataEnabledPreferenceKey @"WebKitCustomPasteboardDataEnabled"
> #define WebKitDialogElementEnabledPreferenceKey @"WebKitDialogElementEnabledPreferenceKey"
>@@ -295,3 +294,4 @@
> // be removed when it is considered safe to do so.
> #define WebKitShadowDOMEnabledPreferenceKey @"WebKitShadowDOMEnabled"
> #define WebKitHixie76WebSocketProtocolEnabledKey @"WebKitHixie76WebSocketProtocolEnabled"
>+#define WebKitCustomElementsEnabledPreferenceKey @"WebKitCustomElementsEnabled"
>Index: Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>===================================================================
>--- Source/WebKitLegacy/mac/WebView/WebPreferences.mm	(revision 267069)
>+++ Source/WebKitLegacy/mac/WebView/WebPreferences.mm	(working copy)
>@@ -631,7 +631,6 @@ + (void)initialize
>         @YES, WebKitMockCaptureDevicesPromptEnabledPreferenceKey,
>         @YES, WebKitMediaCaptureRequiresSecureConnectionPreferenceKey,
> #endif
>-        @YES, WebKitCustomElementsEnabledPreferenceKey,
>         @YES, WebKitDataTransferItemsEnabledPreferenceKey,
>         @NO, WebKitCustomPasteboardDataEnabledPreferenceKey,
>         @NO, WebKitDialogElementEnabledPreferenceKey,
>@@ -3048,16 +3047,6 @@ - (void)setMediaCaptureRequiresSecureCon
>     [self _setBoolValue:flag forKey:WebKitMediaCaptureRequiresSecureConnectionPreferenceKey];
> }
> 
>-- (BOOL)customElementsEnabled
>-{
>-    return [self _boolValueForKey:WebKitCustomElementsEnabledPreferenceKey];
>-}
>-
>-- (void)setCustomElementsEnabled:(BOOL)flag
>-{
>-    [self _setBoolValue:flag forKey:WebKitCustomElementsEnabledPreferenceKey];
>-}
>-
> - (BOOL)dataTransferItemsEnabled
> {
>     return [self _boolValueForKey:WebKitDataTransferItemsEnabledPreferenceKey];
>@@ -3723,6 +3712,15 @@ - (BOOL)shadowDOMEnabled
>     return YES;
> }
> 
>+- (void)setCustomElementsEnabled:(BOOL)flag
>+{
>+}
>+
>+- (BOOL)customElementsEnabled
>+{
>+    return YES;
>+}
>+
> - (void)setVideoPluginProxyEnabled:(BOOL)flag
> {
> }
>Index: Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>===================================================================
>--- Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h	(revision 267069)
>+++ Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h	(working copy)
>@@ -537,9 +537,6 @@ @interface WebPreferences (WebPrivate)
> - (void)setMediaCaptureRequiresSecureConnection:(BOOL)flag;
> - (BOOL)mediaCaptureRequiresSecureConnection;
> 
>-- (void)setCustomElementsEnabled:(BOOL)flag;
>-- (BOOL)customElementsEnabled;
>-
> - (void)setDataTransferItemsEnabled:(BOOL)flag;
> - (BOOL)dataTransferItemsEnabled;
> 
>@@ -705,6 +702,9 @@ @interface WebPreferences (WebPrivateDep
> - (void)setShadowDOMEnabled:(BOOL)flag;
> - (BOOL)shadowDOMEnabled;
> 
>+- (void)setCustomElementsEnabled:(BOOL)flag;
>+- (BOOL)customElementsEnabled;
>+
> - (void)setVideoPluginProxyEnabled:(BOOL)flag;
> - (BOOL)isVideoPluginProxyEnabled;
> 
>Index: Source/WebKitLegacy/win/ChangeLog
>===================================================================
>--- Source/WebKitLegacy/win/ChangeLog	(revision 267069)
>+++ Source/WebKitLegacy/win/ChangeLog	(working copy)
>@@ -1,3 +1,20 @@
>+2020-09-14  Sam Weinig  <weinig@apple.com>
>+
>+        Remove runtime setting for enabling/disabling custom elements
>+        https://bugs.webkit.org/show_bug.cgi?id=216518
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove runtime setting for enabling/disabling custom elements. There is no
>+        reason one need to disable it now, and it has been on by default for
>+        a long enough time.
>+
>+        * WebPreferences.cpp:
>+        (WebPreferences::customElementsEnabled):
>+        (WebPreferences::setCustomElementsEnabled):
>+        * WebView.cpp:
>+        (WebView::notifyPreferencesChanged):
>+
> 2020-09-14  Sam Weinig  <weinig@apple.com>
> 
>         Remove runtime setting for enabling/disabling ShadowDOM
>Index: Source/WebKitLegacy/win/WebPreferences.cpp
>===================================================================
>--- Source/WebKitLegacy/win/WebPreferences.cpp	(revision 267069)
>+++ Source/WebKitLegacy/win/WebPreferences.cpp	(working copy)
>@@ -2077,13 +2077,12 @@ HRESULT WebPreferences::customElementsEn
> {
>     if (!enabled)
>         return E_POINTER;
>-    *enabled = boolValueForKey(WebKitCustomElementsEnabledPreferenceKey);
>+    *enabled = true;
>     return S_OK;
> }
> 
>-HRESULT WebPreferences::setCustomElementsEnabled(BOOL enabled)
>+HRESULT WebPreferences::setCustomElementsEnabled(BOOL)
> {
>-    setBoolValue(WebKitCustomElementsEnabledPreferenceKey, enabled);
>     return S_OK;
> }
> 
>Index: Source/WebKitLegacy/win/WebView.cpp
>===================================================================
>--- Source/WebKitLegacy/win/WebView.cpp	(revision 267069)
>+++ Source/WebKitLegacy/win/WebView.cpp	(working copy)
>@@ -5234,11 +5234,6 @@ HRESULT WebView::notifyPreferencesChange
>         return hr;
>     RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled(!!enabled);
> 
>-    hr = prefsPrivate->customElementsEnabled(&enabled);
>-    if (FAILED(hr))
>-        return hr;
>-    settings.setCustomElementsEnabled(!!enabled);
>-
>     hr = prefsPrivate->menuItemElementEnabled(&enabled);
>     if (FAILED(hr))
>         return hr;
>Index: Tools/ChangeLog
>===================================================================
>--- Tools/ChangeLog	(revision 267069)
>+++ Tools/ChangeLog	(working copy)
>@@ -1,3 +1,19 @@
>+2020-09-14  Sam Weinig  <weinig@apple.com>
>+
>+        Remove runtime setting for enabling/disabling custom elements
>+        https://bugs.webkit.org/show_bug.cgi?id=216518
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Remove runtime setting for enabling/disabling custom elements. There is no
>+        reason one need to disable it now, and it has been on by default for
>+        a long enough time.
>+
>+        * DumpRenderTree/mac/DumpRenderTree.mm:
>+        (resetWebPreferencesToConsistentValues):
>+        * DumpRenderTree/win/DumpRenderTree.cpp:
>+        (resetWebPreferencesToConsistentValues):
>+
> 2020-09-14  Sam Weinig  <weinig@apple.com>
> 
>         Remove runtime setting for enabling/disabling ShadowDOM
>Index: Tools/DumpRenderTree/mac/DumpRenderTree.mm
>===================================================================
>--- Tools/DumpRenderTree/mac/DumpRenderTree.mm	(revision 267069)
>+++ Tools/DumpRenderTree/mac/DumpRenderTree.mm	(working copy)
>@@ -935,8 +935,6 @@ static void resetWebPreferencesToConsist
>     [preferences setMediaSourceEnabled:YES];
>     [preferences setSourceBufferChangeTypeEnabled:YES];
> 
>-    [preferences setCustomElementsEnabled:YES];
>-
>     [preferences setDataTransferItemsEnabled:YES];
>     [preferences setCustomPasteboardDataEnabled:YES];
>     [preferences setDialogElementEnabled:YES];
>Index: Tools/DumpRenderTree/win/DumpRenderTree.cpp
>===================================================================
>--- Tools/DumpRenderTree/win/DumpRenderTree.cpp	(revision 267069)
>+++ Tools/DumpRenderTree/win/DumpRenderTree.cpp	(working copy)
>@@ -898,7 +898,6 @@ static void resetWebPreferencesToConsist
>     preferences->setFontSmoothing(FontSmoothingTypeStandard);
> 
>     prefsPrivate->setFetchAPIEnabled(TRUE);
>-    prefsPrivate->setCustomElementsEnabled(TRUE);
>     prefsPrivate->setResourceTimingEnabled(TRUE);
>     prefsPrivate->setUserTimingEnabled(TRUE);
>     prefsPrivate->setDataTransferItemsEnabled(TRUE);

Actions: View | Formatted Diff | Diff

Attachments on bug 216518: 408783 | 408821 | 408836