Attachment 408222 Details for Bug 216271 – Patch

[patch] Patch

bug-216271-20200908130428.patch (text/plain), 14.65 KB, created by Antoine Quint on 2020-09-08 04:04:29 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Antoine Quint

Created: 2020-09-08 04:04:29 PDT

Size: 14.65 KB

patch

obsolete

>Subversion Revision: 266718
>diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
>index 7c77bbf23f70656b21e3bb0eebab49dd2a264fd3..981f0f0db88c9968cead60d38f0f18f2fb4b3d7b 100644
>--- a/Source/WebCore/ChangeLog
>+++ b/Source/WebCore/ChangeLog
>@@ -1,3 +1,14 @@
>+2020-09-08  Antoine Quint  <graouts@webkit.org>
>+
>+        Add an experimental feature flag for CSS individual transform properties
>+        https://bugs.webkit.org/show_bug.cgi?id=216271
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * page/RuntimeEnabledFeatures.h:
>+        (WebCore::RuntimeEnabledFeatures::setCSSIndividualTransformPropertiesEnabled):
>+        (WebCore::RuntimeEnabledFeatures::cssIndividualTransformPropertiesEnabled):
>+
> 2020-09-08  Antti Koivisto  <antti@apple.com>
> 
>         Comparing styles with large but identical custom property maps is slow
>diff --git a/Source/WebKit/ChangeLog b/Source/WebKit/ChangeLog
>index 7b70f5c9beb91e545a14585552acff436b7897b4..84821936a0abff539f04db531a15be3ac63f818a 100644
>--- a/Source/WebKit/ChangeLog
>+++ b/Source/WebKit/ChangeLog
>@@ -1,3 +1,12 @@
>+2020-09-08  Antoine Quint  <graouts@webkit.org>
>+
>+        Add an experimental feature flag for CSS individual transform properties
>+        https://bugs.webkit.org/show_bug.cgi?id=216271
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Shared/WebPreferences.yaml:
>+
> 2020-09-08  Pablo Saavedra  <psaavedra@igalia.com>
> 
>         [GLIB] RemoteInspectorServer is not started if WebKitWebContext is not created already created
>diff --git a/Source/WebKitLegacy/mac/ChangeLog b/Source/WebKitLegacy/mac/ChangeLog
>index 07b7cc2b63bae5c6f6563f6e84c759b442236d4f..e6b375cef4b178ae2156eebe80f7771d8f678b72 100644
>--- a/Source/WebKitLegacy/mac/ChangeLog
>+++ b/Source/WebKitLegacy/mac/ChangeLog
>@@ -1,3 +1,18 @@
>+2020-09-08  Antoine Quint  <graouts@webkit.org>
>+
>+        Add an experimental feature flag for CSS individual transform properties
>+        https://bugs.webkit.org/show_bug.cgi?id=216271
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * WebView/WebPreferenceKeysPrivate.h:
>+        * WebView/WebPreferences.mm:
>+        (-[WebPreferences setCSSIndividualTransformPropertiesEnabled:]):
>+        (-[WebPreferences cssIndividualTransformPropertiesEnabled]):
>+        * WebView/WebPreferencesPrivate.h:
>+        * WebView/WebView.mm:
>+        (-[WebView _preferencesChanged:]):
>+
> 2020-09-02  Darin Adler  <darin@apple.com>
> 
>         Remove EAffinity, UPSTREAM, DOWNSTREAM, SEL_DEFAULT_AFFINITY, and VisibleSelection::selectionType
>diff --git a/Source/WebKitLegacy/win/ChangeLog b/Source/WebKitLegacy/win/ChangeLog
>index 80c83491186e341c7225958904536476777025a2..ed3be53b7f3b3b843a8ccb29d21cfb471902abe6 100644
>--- a/Source/WebKitLegacy/win/ChangeLog
>+++ b/Source/WebKitLegacy/win/ChangeLog
>@@ -1,3 +1,20 @@
>+2020-09-08  Antoine Quint  <graouts@webkit.org>
>+
>+        Add an experimental feature flag for CSS individual transform properties
>+        https://bugs.webkit.org/show_bug.cgi?id=216271
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * Interfaces/IWebPreferencesPrivate.idl:
>+        * WebPreferenceKeysPrivate.h:
>+        * WebPreferences.cpp:
>+        (WebPreferences::initializeDefaultSettings):
>+        (WebPreferences::CSSIndividualTransformPropertiesEnabled):
>+        (WebPreferences::setCSSIndividualTransformPropertiesEnabled):
>+        * WebPreferences.h:
>+        * WebView.cpp:
>+        (WebView::notifyPreferencesChanged):
>+
> 2020-09-02  Darin Adler  <darin@apple.com>
> 
>         Remove EAffinity, UPSTREAM, DOWNSTREAM, SEL_DEFAULT_AFFINITY, and VisibleSelection::selectionType
>diff --git a/Source/WebCore/page/RuntimeEnabledFeatures.h b/Source/WebCore/page/RuntimeEnabledFeatures.h
>index 9cfdd63270072cad524b991524c760ac3c2ad0db..ac5734d07c29b1e3c7de4061035ed300085c42d7 100644
>--- a/Source/WebCore/page/RuntimeEnabledFeatures.h
>+++ b/Source/WebCore/page/RuntimeEnabledFeatures.h
>@@ -289,6 +289,9 @@ public:
>     bool webMParserEnabled() const { return m_webMParserEnabled; }
> #endif
> 
>+    void setCSSIndividualTransformPropertiesEnabled(bool isEnabled) { m_cssIndividualTransformPropertiesEnabled = isEnabled; }
>+    bool cssIndividualTransformPropertiesEnabled() { return m_cssIndividualTransformPropertiesEnabled; }
>+
> private:
>     // Never instantiate.
>     RuntimeEnabledFeatures();
>@@ -430,6 +433,8 @@ private:
>     bool m_webMParserEnabled { false };
> #endif
> 
>+    bool m_cssIndividualTransformPropertiesEnabled { false };
>+
>     friend class WTF::NeverDestroyed<RuntimeEnabledFeatures>;
> };
> 
>diff --git a/Source/WebKit/Shared/WebPreferences.yaml b/Source/WebKit/Shared/WebPreferences.yaml
>index 55154a495f2946c8b00b16cb58c11027ebee83fa..8f51136fa4233877b322e8e7991675de6414b85e 100644
>--- a/Source/WebKit/Shared/WebPreferences.yaml
>+++ b/Source/WebKit/Shared/WebPreferences.yaml
>@@ -2157,3 +2157,11 @@ CoreImageAcceleratedFilterRenderEnabled:
>   humanReadableDescription: "Accelerated CSS and SVG filter rendering using CoreImage"
>   category: experimental
>   condition: ENABLE(CORE_IMAGE_ACCELERATED_FILTER_RENDER)
>+
>+CSSIndividualTransformPropertiesEnabled:
>+  type: bool
>+  defaultValue: DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
>+  humanReadableName: "CSS Individual Transform Properties"
>+  humanReadableDescription: "Support for the translate, scale and rotate CSS properties"
>+  category: experimental
>+  webcoreBinding: RuntimeEnabledFeatures
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>index 0868047f955f73dc277466052206b3c30437eafb..091ea168bc62a2ec46ea0490c904064bc10f6d74 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h
>@@ -291,3 +291,4 @@
> #define WebKitLinkPreloadResponsiveImagesEnabledPreferenceKey @"WebKitLinkPreloadResponsiveImagesEnabled"
> #define WebKitDebugInAppBrowserPrivacyEnabledPreferenceKey @"WebKitDebugInAppBrowserPrivacyEnabled"
> #define WebKitAspectRatioOfImgFromWidthAndHeightEnabledPreferenceKey @"WebKitAspectRatioOfImgFromWidthAndHeightEnabled"
>+#define WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey @"WebKitCSSIndividualTransformPropertiesEnabled"
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>index d813c2de3d3feb60878558c465eabdb002770e0d..31b6208b22872fafde3ec1f43e0ec0a88476aa7c 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferences.mm
>@@ -3725,6 +3725,16 @@ - (void)setUserGesturePromisePropagationEnabled:(BOOL)flag
>     [self _setBoolValue:flag forKey:WebKitUserGesturePromisePropagationEnabledPreferenceKey];
> }
> 
>+- (void)setCSSIndividualTransformPropertiesEnabled:(BOOL)flag
>+{
>+    [self _setBoolValue:flag forKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
>+}
>+
>+- (BOOL)cssIndividualTransformPropertiesEnabled
>+{
>+    return [self _boolValueForKey:WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey];
>+}
>+
> @end
> 
> @implementation WebPreferences (WebInternal)
>diff --git a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>index eaf95563bcef788ff12f7083dffcdef93688b06e..7491f13b6b12aba8ccb16d1cae6fbed39b11a8c4 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>+++ b/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h
>@@ -658,6 +658,9 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification WEBKIT_DEPR
> - (void)setUserGesturePromisePropagationEnabled:(BOOL)flag;
> - (BOOL)userGesturePromisePropagationEnabled;
> 
>+- (void)setCSSIndividualTransformPropertiesEnabled:(BOOL)flag;
>+- (BOOL)cssIndividualTransformPropertiesEnabled;
>+
> @property (nonatomic) BOOL visualViewportAPIEnabled;
> @property (nonatomic) BOOL CSSOMViewScrollingAPIEnabled;
> @property (nonatomic) BOOL CSSOMViewSmoothScrollingEnabled;
>diff --git a/Source/WebKitLegacy/mac/WebView/WebView.mm b/Source/WebKitLegacy/mac/WebView/WebView.mm
>index 3a954f54f888b30f8f1ec00fed41ec2b51e0a28f..b9d5defdf581bc2413c855ac931bbd1a32f16baa 100644
>--- a/Source/WebKitLegacy/mac/WebView/WebView.mm
>+++ b/Source/WebKitLegacy/mac/WebView/WebView.mm
>@@ -3464,6 +3464,8 @@ - (void)_preferencesChanged:(WebPreferences *)preferences
>     settings.setResizeObserverEnabled([preferences resizeObserverEnabled]);
> #endif
>     settings.setAspectRatioOfImgFromWidthAndHeightEnabled([preferences aspectRatioOfImgFromWidthAndHeightEnabled]);
>+
>+    RuntimeEnabledFeatures::sharedFeatures().setCSSIndividualTransformPropertiesEnabled([preferences cssIndividualTransformPropertiesEnabled]);
> }
> 
> static inline IMP getMethod(id o, SEL s)
>diff --git a/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl b/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl
>index 9a875d479e7bfad7361a6f2f8a4d319337ee57f2..207c0b1f3d41442e61235bed807ce5fcd9b37192 100644
>--- a/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl
>+++ b/Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl
>@@ -269,4 +269,6 @@ interface IWebPreferencesPrivate8 : IWebPreferencesPrivate7
>     HRESULT setAllowTopNavigationToDataURLs([in] BOOL enabled);
>     HRESULT modernUnprefixedWebAudioEnabled([out, retval] BOOL* enabled);
>     HRESULT setModernUnprefixedWebAudioEnabled([in] BOOL enabled);
>+    HRESULT CSSIndividualTransformPropertiesEnabled([out, retval] BOOL* enabled);
>+    HRESULT setCSSIndividualTransformPropertiesEnabled([in] BOOL enabled);
> }
>diff --git a/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h b/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
>index 2a2121adb9686984121c0e4ba8daffca7bcc6cab..aea5387bc57b6ba5453f10d71aaae75ead820943 100644
>--- a/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
>+++ b/Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h
>@@ -231,3 +231,5 @@
> #define WebKitAspectRatioOfImgFromWidthAndHeightEnabledPreferenceKey "WebKitAspectRatioOfImgFromWidthAndHeightEnabled"
> 
> #define WebKitWebSQLEnabledPreferenceKey "WebKitWebSQLEnabled"
>+
>+#define WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey "WebKitCSSIndividualTransformPropertiesEnabled"
>diff --git a/Source/WebKitLegacy/win/WebPreferences.cpp b/Source/WebKitLegacy/win/WebPreferences.cpp
>index 93de8a320aa158349a07205d04e2ea4c4149f294..a891ee59011f44438cdebc51a8a6058baaab4c04 100644
>--- a/Source/WebKitLegacy/win/WebPreferences.cpp
>+++ b/Source/WebKitLegacy/win/WebPreferences.cpp
>@@ -357,6 +357,8 @@ void WebPreferences::initializeDefaultSettings()
> 
>     CFDictionaryAddValue(defaults, CFSTR(WebKitWebSQLEnabledPreferenceKey), kCFBooleanFalse);
> 
>+    CFDictionaryAddValue(defaults, CFSTR(WebKitCSSIndividualTransformPropertiesEnabled), kCFBooleanFalse);
>+
>     defaultSettings = defaults;
> #endif
> }
>@@ -2514,3 +2516,17 @@ HRESULT WebPreferences::setModernUnprefixedWebAudioEnabled(BOOL enabled)
>     setBoolValue(WebKitWebAudioEnabledPreferenceKey, enabled);
>     return S_OK;
> }
>+
>+HRESULT WebPreferences::CSSIndividualTransformPropertiesEnabled(_Out_ BOOL* enabled)
>+{
>+    if (!enabled)
>+        return E_POINTER;
>+    *enabled = boolValueForKey(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey);
>+    return S_OK;
>+}
>+
>+HRESULT WebPreferences::setCSSIndividualTransformPropertiesEnabled(BOOL enabled)
>+{
>+    setBoolValue(WebKitCSSIndividualTransformPropertiesEnabledPreferenceKey, enabled);
>+    return S_OK;
>+}
>diff --git a/Source/WebKitLegacy/win/WebPreferences.h b/Source/WebKitLegacy/win/WebPreferences.h
>index 2437b0e76289506c26404886bd2c03f583253c51..d6d5bb8a36b42e13d798aee77d0b3173d93810d7 100644
>--- a/Source/WebKitLegacy/win/WebPreferences.h
>+++ b/Source/WebKitLegacy/win/WebPreferences.h
>@@ -307,6 +307,8 @@ public:
>     virtual HRESULT STDMETHODCALLTYPE setAllowTopNavigationToDataURLs(BOOL);
>     virtual HRESULT STDMETHODCALLTYPE modernUnprefixedWebAudioEnabled(_Out_ BOOL*);
>     virtual HRESULT STDMETHODCALLTYPE setModernUnprefixedWebAudioEnabled(BOOL);
>+    virtual HRESULT STDMETHODCALLTYPE CSSIndividualTransformPropertiesEnabled(_Out_ BOOL*);
>+    virtual HRESULT STDMETHODCALLTYPE setCSSIndividualTransformPropertiesEnabled(BOOL);
> 
>     // WebPreferences
> 
>diff --git a/Source/WebKitLegacy/win/WebView.cpp b/Source/WebKitLegacy/win/WebView.cpp
>index 4edde54244ce4aee09793b205771feeeaff6203a..99381abd2dd79120e2b2bd0da337927226b519e5 100644
>--- a/Source/WebKitLegacy/win/WebView.cpp
>+++ b/Source/WebKitLegacy/win/WebView.cpp
>@@ -5344,6 +5344,11 @@ HRESULT WebView::notifyPreferencesChanged(IWebNotification* notification)
>         return hr;
>     settings.setCSSOMViewSmoothScrollingEnabled(!!enabled);
> 
>+    hr = prefsPrivate->CSSIndividualTransformPropertiesEnabled(&enabled);
>+    if (FAILED(hr))
>+        return hr;
>+    RuntimeEnabledFeatures::sharedFeatures().setCSSIndividualTransformPropertiesEnabled(!!enabled);
>+
>     hr = preferences->privateBrowsingEnabled(&enabled);
>     if (FAILED(hr))
>         return hr;
>diff --git a/Tools/ChangeLog b/Tools/ChangeLog
>index a12da58ad23f1c7b2c6565f1b5e01175dcb7852a..611b72e60ff610423a0b7c5307febfdc5314a314 100644
>--- a/Tools/ChangeLog
>+++ b/Tools/ChangeLog
>@@ -1,3 +1,15 @@
>+2020-09-08  Antoine Quint  <graouts@webkit.org>
>+
>+        Add an experimental feature flag for CSS individual transform properties
>+        https://bugs.webkit.org/show_bug.cgi?id=216271
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        * DumpRenderTree/mac/DumpRenderTree.mm:
>+        (enableExperimentalFeatures):
>+        * DumpRenderTree/win/DumpRenderTree.cpp:
>+        (enableExperimentalFeatures):
>+
> 2020-09-06  Ryosuke Niwa  <rniwa@webkit.org>
> 
>         Make CompactUniquePtrTuple actually work with subclassing and custom deleter
>diff --git a/Tools/DumpRenderTree/mac/DumpRenderTree.mm b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>index 6f7df069c1acc177ee3b30d58c9e5633a84d0d7a..fd8b353d3f4264bab302ae759c15560cdcc374c0 100644
>--- a/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>+++ b/Tools/DumpRenderTree/mac/DumpRenderTree.mm
>@@ -839,6 +839,7 @@ static void enableExperimentalFeatures(WebPreferences* preferences)
>     [preferences setCSSShadowPartsEnabled:YES];
>     [preferences setAspectRatioOfImgFromWidthAndHeightEnabled:YES];
>     [preferences setCSSOMViewSmoothScrollingEnabled:YES];
>+    [preferences setCSSIndividualTransformPropertiesEnabled:YES];
> }
> 
> // Called before each test.
>diff --git a/Tools/DumpRenderTree/win/DumpRenderTree.cpp b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>index 14dc3d343ad82de6f2ccdddf4742b273f91d7295..d9f6a4a42260f6f5da9515c203eebd930efe0623 100644
>--- a/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>+++ b/Tools/DumpRenderTree/win/DumpRenderTree.cpp
>@@ -805,6 +805,7 @@ static void enableExperimentalFeatures(IWebPreferences* preferences)
>     // FIXME: WebGL2
>     // FIXME: WebRTC
>     prefsPrivate->setCSSOMViewSmoothScrollingEnabled(TRUE);
>+    prefsPrivate->setCSSIndividualTransformPropertiesEnabled(TRUE);
> }
> 
> static void resetWebPreferencesToConsistentValues(IWebPreferences* preferences)

Actions: View | Formatted Diff | Diff

Attachments on bug 216271: 408222 | 408231 | 409669 | 409689 | 409696 | 409700 | 409701 | 409712 | 409714 | 409718 | 409731 | 409732