Attachment 407584 Details for Bug 215995 – Patch

[patch] Patch

bug-215995-20200830191537.patch (text/plain), 9.56 KB, created by Sam Weinig on 2020-08-30 19:15:38 PDT

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Weinig

Created: 2020-08-30 19:15:38 PDT

Size: 9.56 KB

patch

obsolete

>Index: Source/WebCore/ChangeLog
>===================================================================
>--- Source/WebCore/ChangeLog	(revision 266341)
>+++ Source/WebCore/ChangeLog	(working copy)
>@@ -1,3 +1,23 @@
>+2020-08-30  Sam Weinig  <weinig@apple.com>
>+
>+        Update generateEmptyHeaderAndCpp in generate-bindings.pl to use proper English and use an #error to catch accidental compilation
>+        https://bugs.webkit.org/show_bug.cgi?id=215995
>+
>+        Reviewed by NOBODY (OOPS!).
>+        
>+        Update c++ content generated by generate-bindings.pl for supplemental IDLs.
>+
>+        * bindings/scripts/generate-bindings.pl:
>+        (generateEmptyHeaderAndCpp):
>+        * bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.cpp:
>+        * bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.h:
>+        * bindings/scripts/test/JS/JSTestImplements.cpp:
>+        * bindings/scripts/test/JS/JSTestImplements.h:
>+        * bindings/scripts/test/JS/JSTestOperationBase.cpp:
>+        * bindings/scripts/test/JS/JSTestOperationBase.h:
>+        * bindings/scripts/test/JS/JSTestSupplemental.cpp:
>+        * bindings/scripts/test/JS/JSTestSupplemental.h:
>+
> 2020-08-30  Sam Weinig  <weinig@apple.com>
> 
>         EnabledBySetting extended attributes on a partial interface do not get merged with EnabledBySetting extended attributes on properties of that partial interface
>Index: Source/WebCore/bindings/scripts/generate-bindings.pl
>===================================================================
>--- Source/WebCore/bindings/scripts/generate-bindings.pl	(revision 266339)
>+++ Source/WebCore/bindings/scripts/generate-bindings.pl	(working copy)
>@@ -161,13 +161,7 @@ sub generateEmptyHeaderAndCpp
> 
>     my $headerName = "${prefix}${targetInterfaceName}.h";
>     my $cppName = "${prefix}${targetInterfaceName}.cpp";
>-    my $contents = "/*
>-    This file is generated just to tell build scripts that $headerName and
>-    $cppName are created for ${targetInterfaceName}.idl, and thus
>-    prevent the build scripts from trying to generate $headerName and
>-    $cppName at every build. This file must not be tried to compile.
>-*/
>-";
>+    my $contents = "#error This file was generated to indicate to build scripts that $headerName and $cppName were created for ${targetInterfaceName}.idl and prevent regeneration on every build. It should not be compiled.\n";
>     open FH, "> ${outputHeadersDirectory}/${headerName}" or die "Cannot open $headerName\n";
>     print FH $contents;
>     close FH;
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.cpp
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.cpp	(revision 266339)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.cpp	(working copy)
>@@ -1,6 +1 @@
>-/*
>-    This file is generated just to tell build scripts that JSTestEnabledBySettingSupplemental.h and
>-    JSTestEnabledBySettingSupplemental.cpp are created for TestEnabledBySettingSupplemental.idl, and thus
>-    prevent the build scripts from trying to generate JSTestEnabledBySettingSupplemental.h and
>-    JSTestEnabledBySettingSupplemental.cpp at every build. This file must not be tried to compile.
>-*/
>+#error This file was generated to indicate to build scripts that JSTestEnabledBySettingSupplemental.h and JSTestEnabledBySettingSupplemental.cpp were created for TestEnabledBySettingSupplemental.idl and prevent regeneration on every build. It should not be compiled.
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.h	(revision 266339)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestEnabledBySettingSupplemental.h	(working copy)
>@@ -1,6 +1 @@
>-/*
>-    This file is generated just to tell build scripts that JSTestEnabledBySettingSupplemental.h and
>-    JSTestEnabledBySettingSupplemental.cpp are created for TestEnabledBySettingSupplemental.idl, and thus
>-    prevent the build scripts from trying to generate JSTestEnabledBySettingSupplemental.h and
>-    JSTestEnabledBySettingSupplemental.cpp at every build. This file must not be tried to compile.
>-*/
>+#error This file was generated to indicate to build scripts that JSTestEnabledBySettingSupplemental.h and JSTestEnabledBySettingSupplemental.cpp were created for TestEnabledBySettingSupplemental.idl and prevent regeneration on every build. It should not be compiled.
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestImplements.cpp
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestImplements.cpp	(revision 266339)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestImplements.cpp	(working copy)
>@@ -1,6 +1 @@
>-/*
>-    This file is generated just to tell build scripts that JSTestImplements.h and
>-    JSTestImplements.cpp are created for TestImplements.idl, and thus
>-    prevent the build scripts from trying to generate JSTestImplements.h and
>-    JSTestImplements.cpp at every build. This file must not be tried to compile.
>-*/
>+#error This file was generated to indicate to build scripts that JSTestImplements.h and JSTestImplements.cpp were created for TestImplements.idl and prevent regeneration on every build. It should not be compiled.
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestImplements.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestImplements.h	(revision 266339)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestImplements.h	(working copy)
>@@ -1,6 +1 @@
>-/*
>-    This file is generated just to tell build scripts that JSTestImplements.h and
>-    JSTestImplements.cpp are created for TestImplements.idl, and thus
>-    prevent the build scripts from trying to generate JSTestImplements.h and
>-    JSTestImplements.cpp at every build. This file must not be tried to compile.
>-*/
>+#error This file was generated to indicate to build scripts that JSTestImplements.h and JSTestImplements.cpp were created for TestImplements.idl and prevent regeneration on every build. It should not be compiled.
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestOperationBase.cpp
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestOperationBase.cpp	(revision 266339)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestOperationBase.cpp	(working copy)
>@@ -1,6 +1 @@
>-/*
>-    This file is generated just to tell build scripts that JSTestOperationBase.h and
>-    JSTestOperationBase.cpp are created for TestOperationBase.idl, and thus
>-    prevent the build scripts from trying to generate JSTestOperationBase.h and
>-    JSTestOperationBase.cpp at every build. This file must not be tried to compile.
>-*/
>+#error This file was generated to indicate to build scripts that JSTestOperationBase.h and JSTestOperationBase.cpp were created for TestOperationBase.idl and prevent regeneration on every build. It should not be compiled.
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestOperationBase.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestOperationBase.h	(revision 266339)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestOperationBase.h	(working copy)
>@@ -1,6 +1 @@
>-/*
>-    This file is generated just to tell build scripts that JSTestOperationBase.h and
>-    JSTestOperationBase.cpp are created for TestOperationBase.idl, and thus
>-    prevent the build scripts from trying to generate JSTestOperationBase.h and
>-    JSTestOperationBase.cpp at every build. This file must not be tried to compile.
>-*/
>+#error This file was generated to indicate to build scripts that JSTestOperationBase.h and JSTestOperationBase.cpp were created for TestOperationBase.idl and prevent regeneration on every build. It should not be compiled.
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestSupplemental.cpp
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestSupplemental.cpp	(revision 266339)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestSupplemental.cpp	(working copy)
>@@ -1,6 +1 @@
>-/*
>-    This file is generated just to tell build scripts that JSTestSupplemental.h and
>-    JSTestSupplemental.cpp are created for TestSupplemental.idl, and thus
>-    prevent the build scripts from trying to generate JSTestSupplemental.h and
>-    JSTestSupplemental.cpp at every build. This file must not be tried to compile.
>-*/
>+#error This file was generated to indicate to build scripts that JSTestSupplemental.h and JSTestSupplemental.cpp were created for TestSupplemental.idl and prevent regeneration on every build. It should not be compiled.
>Index: Source/WebCore/bindings/scripts/test/JS/JSTestSupplemental.h
>===================================================================
>--- Source/WebCore/bindings/scripts/test/JS/JSTestSupplemental.h	(revision 266339)
>+++ Source/WebCore/bindings/scripts/test/JS/JSTestSupplemental.h	(working copy)
>@@ -1,6 +1 @@
>-/*
>-    This file is generated just to tell build scripts that JSTestSupplemental.h and
>-    JSTestSupplemental.cpp are created for TestSupplemental.idl, and thus
>-    prevent the build scripts from trying to generate JSTestSupplemental.h and
>-    JSTestSupplemental.cpp at every build. This file must not be tried to compile.
>-*/
>+#error This file was generated to indicate to build scripts that JSTestSupplemental.h and JSTestSupplemental.cpp were created for TestSupplemental.idl and prevent regeneration on every build. It should not be compiled.

Actions: View | Formatted Diff | Diff

Attachments on bug 215995: 407584